RE: [PATCH] Fix FFI return type for closures in the java interpreter

2016-07-13 Thread Matthew Fortune
Tom Tromey writes: > > "Matthew" == Matthew Fortune writes: > > Matthew> Sorry for the long delay... > > No problem. > > >> This is ok. > >> Could you check? I think a -m32 build ought to show it. Maybe your > >> x86-64 build already did

Re: [PATCH] Fix FFI return type for closures in the java interpreter

2016-07-12 Thread Tom Tromey
> "Matthew" == Matthew Fortune writes: Matthew> Sorry for the long delay... No problem. >> This is ok. >> Could you check? I think a -m32 build ought to show it. Maybe your >> x86-64 build already did this? Matthew> Still OK to commit? Yes, thanks. Tom

RE: [PATCH] Fix FFI return type for closures in the java interpreter

2016-07-12 Thread Matthew Fortune
Tom Tromey writes: > > "Matthew" == Matthew Fortune writes: > > Matthew> I'm not sure this will matter if the only arch is x86 as > Matthew> ffi_arg will be 32-bit anyway there. > > Aha, right. Thanks for looking. > > Matthew> There would need

Re: [PATCH] Fix FFI return type for closures in the java interpreter

2016-06-28 Thread Tom Tromey
> "Matthew" == Matthew Fortune writes: Matthew> I'm not sure this will matter if the only arch is x86 as Matthew> ffi_arg will be 32-bit anyway there. Aha, right. Thanks for looking. Matthew> There would need to be a Matthew> 64bit arch using the raw api. I

RE: [PATCH] Fix FFI return type for closures in the java interpreter

2016-06-28 Thread Matthew Fortune
Tom Tromey writes: > > "Matthew" == Matthew Fortune writes: > Matthew> I've identified a latent bug in the java interpreter that affects > MIPS > Matthew> n32 and n64 ABIs both little and big endian and, I presume, any > 64-bit > Matthew> big

Re: [PATCH] Fix FFI return type for closures in the java interpreter

2016-06-28 Thread Tom Tromey
> "Matthew" == Matthew Fortune writes: Matthew> I've identified a latent bug in the java interpreter that affects MIPS Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit Matthew> big endian target with int as 32-bit. [...] Matthew>

Re: [PATCH] Fix FFI return type for closures in the java interpreter

2016-06-27 Thread Tom Tromey
> "Matthew" == Matthew Fortune writes: Matthew> I've identified a latent bug in the java interpreter that affects MIPS Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit Matthew> big endian target with int as 32-bit. Thanks. Matthew>