Re: [PATCH] Fix PR64078

2016-09-22 Thread Bernd Edlinger
On 09/19/16 23:27, Jeff Law wrote: > On 09/19/2016 03:08 PM, Bernd Edlinger wrote: >>> >>> Would it work to break this up into distinct tests, exit()-ing from each >>> function rather than returning back to main? >>> >> >> Yes. I think how this test is designed, each function must be inlined, >>

Re: [PATCH] Fix PR64078

2016-09-19 Thread Jeff Law
On 09/19/2016 03:08 PM, Bernd Edlinger wrote: Would it work to break this up into distinct tests, exit()-ing from each function rather than returning back to main? Yes. I think how this test is designed, each function must be inlined, or it will fail anyway. It was for instance impossible

Re: [PATCH] Fix PR64078

2016-09-19 Thread Bernd Edlinger
On 09/19/16 22:19, Jeff Law wrote: > On 09/15/2016 04:29 AM, Tom de Vries wrote: >> On 31/08/16 07:42, Tom de Vries wrote: >>> On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: > On 29/08/16 18:43, Bernd Edlinger wrote: >> Thanks! >> >> Actually

Re: [PATCH] Fix PR64078

2016-09-19 Thread Jeff Law
On 09/15/2016 04:29 AM, Tom de Vries wrote: On 31/08/16 07:42, Tom de Vries wrote: On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make

Re: [PATCH] Fix PR64078

2016-09-15 Thread Tom de Vries
On 31/08/16 07:42, Tom de Vries wrote: On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL:

Re: [PATCH] Fix PR64078

2016-08-30 Thread Bernd Edlinger
On 08/30/16 10:21, Tom de Vries wrote: > On 29/08/16 18:43, Bernd Edlinger wrote: >> Thanks! >> >> Actually my patch missed to fix one combination: -m32 with -fpic >> >> make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts >> '-m32 -fpic'" >> >> FAIL:

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 29/08/16 18:43, Bernd Edlinger wrote: make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL: c-c++-common/ubsan/object-size-9.c -O2 -flto -fno-use-linker-plugin -flto-partition=none

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL:

Re: [PATCH] Fix PR64078

2016-08-29 Thread Bernd Edlinger
Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL: c-c++-common/ubsan/object-size-9.c -O2 -flto

Re: [PATCH] Fix PR64078

2016-08-29 Thread Tom de Vries
On 17/09/15 20:08, Marek Polacek wrote: On Thu, Sep 17, 2015 at 08:06:48PM +0200, Bernd Edlinger wrote: Hi, On Thu, 17 Sep 2015 10:39:04, Jeff Law wrote: On 09/17/2015 09:00 AM, Marek Polacek wrote: On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: Hi, On Wed, 9 Sep 2015

Re: [PATCH] Fix PR64078

2015-09-17 Thread Jeff Law
On 09/17/2015 09:00 AM, Marek Polacek wrote: On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: Hi, On Wed, 9 Sep 2015 09:31:33, Jeff Law wrote: You could probably make the function static or change its visibility via a function attribute (there's a visibility attribute which can

Re: [PATCH] Fix PR64078

2015-09-17 Thread Marek Polacek
On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: > Hi, > > On Wed, 9 Sep 2015 09:31:33, Jeff Law wrote: > > You could probably make the function static or change its visibility via > > a function attribute (there's a visibility attribute which can take the > > values default,

RE: [PATCH] Fix PR64078

2015-09-17 Thread Bernd Edlinger
Hi, On Thu, 17 Sep 2015 10:39:04, Jeff Law wrote: > > On 09/17/2015 09:00 AM, Marek Polacek wrote: >> On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: >>> Hi, >>> >>> On Wed, 9 Sep 2015 09:31:33, Jeff Law wrote: You could probably make the function static or change its

Re: [PATCH] Fix PR64078

2015-09-17 Thread Marek Polacek
On Thu, Sep 17, 2015 at 08:06:48PM +0200, Bernd Edlinger wrote: > Hi, > > On Thu, 17 Sep 2015 10:39:04, Jeff Law wrote: > > > > On 09/17/2015 09:00 AM, Marek Polacek wrote: > >> On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: > >>> Hi, > >>> > >>> On Wed, 9 Sep 2015 09:31:33, Jeff

RE: [PATCH] Fix PR64078

2015-09-09 Thread Bernd Edlinger
Hi Jeff, On Tue, 8 Sep 2015 13:27:12, Jeff Law wrote: > > On 09/07/2015 07:46 AM, Bernd Edlinger wrote: >> Hi, >> >> On Mon, 7 Sep 2015 12:07:00, Marek Polacek wrote: >>> >>> On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: Hi, we observed sporadic failures of the

Re: [PATCH] Fix PR64078

2015-09-09 Thread Jeff Law
On 09/09/2015 03:10 AM, Bernd Edlinger wrote: Hi Jeff, On Tue, 8 Sep 2015 13:27:12, Jeff Law wrote: On 09/07/2015 07:46 AM, Bernd Edlinger wrote: Hi, On Mon, 7 Sep 2015 12:07:00, Marek Polacek wrote: On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: Hi, we observed

RE: [PATCH] Fix PR64078

2015-09-09 Thread Bernd Edlinger
Hi, On Wed, 9 Sep 2015 09:31:33, Jeff Law wrote: > You could probably make the function static or change its visibility via > a function attribute (there's a visibility attribute which can take the > values default, hidden protected or internal). Default visibility > essentially means the

Re: [PATCH] Fix PR64078

2015-09-08 Thread Jeff Law
On 09/07/2015 07:46 AM, Bernd Edlinger wrote: Hi, On Mon, 7 Sep 2015 12:07:00, Marek Polacek wrote: On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: Hi, we observed sporadic failures of the following two test cases (see PR64078): c-c++-common/ubsan/object-size-9.c and

Re: [PATCH] Fix PR64078

2015-09-07 Thread Marek Polacek
On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: > Hi, > > we observed sporadic failures of the following two test cases (see PR64078): > c-c++-common/ubsan/object-size-9.c and c-c++-common/ubsan/object-size-10.c > > For object-size-9.c this happens in a reproducible way when

RE: [PATCH] Fix PR64078

2015-09-07 Thread Bernd Edlinger
Hi, On Mon, 7 Sep 2015 12:07:00, Marek Polacek wrote: > > On Sun, Sep 06, 2015 at 07:21:13PM +0200, Bernd Edlinger wrote: >> Hi, >> >> we observed sporadic failures of the following two test cases (see PR64078): >> c-c++-common/ubsan/object-size-9.c and c-c++-common/ubsan/object-size-10.c >> >>