RE: [PATCH] MIPS: Correctly update the isa and arch_test_option_p variables after the arch dependency handling code in mips.exp

2015-07-10 Thread Matthew Fortune
Andrew Bennett writes: > I have noticed that in the mips.exp dg-option handling code the isa and > arch_test_option_p variables are not updated after the pre-arch to arch > dependency handling. This means that if this code changes the > architecture the post-arch dependency handling code (which r

Re: [PATCH] MIPS: Correctly update the isa and arch_test_option_p variables after the arch dependency handling code in mips.exp

2015-07-12 Thread Richard Sandiford
Matthew Fortune writes: > Andrew Bennett writes: >> I have noticed that in the mips.exp dg-option handling code the isa and >> arch_test_option_p variables are not updated after the pre-arch to arch >> dependency handling. This means that if this code changes the >> architecture the post-arch de

RE: [PATCH] MIPS: Correctly update the isa and arch_test_option_p variables after the arch dependency handling code in mips.exp

2015-07-14 Thread Andrew Bennett
> Yeah, I agree that this doesn't really fit the model that well, > but like you say, we're stretching the logic a bit :-). When I wrote it, > the architectures formed a nice tree in which moving to leaf nodes only > added features. So in the pre-r6 days: > > # Handle dependencies between th

RE: [PATCH] MIPS: Correctly update the isa and arch_test_option_p variables after the arch dependency handling code in mips.exp

2015-07-14 Thread Moore, Catherine
> -Original Message- > From: Andrew Bennett [mailto:andrew.benn...@imgtec.com] > Sent: Tuesday, July 14, 2015 9:24 AM > To: Richard Sandiford; Matthew Fortune > Cc: gcc-patches@gcc.gnu.org; Moore, Catherine > Subject: RE: [PATCH] MIPS: Correctly update the isa and

RE: [PATCH] MIPS: Correctly update the isa and arch_test_option_p variables after the arch dependency handling code in mips.exp

2015-07-15 Thread Andrew Bennett
> > Ok to commit? > > Yes, this is OK. Committed as SVN 225813. Regards, Andrew