Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-07-12 Thread Jeff Law
age- >> From: Jeff Law >> Sent: Saturday, June 22, 2019 12:10 AM >> To: Richard Biener >> Cc: JiangNing OS ; gcc- >> patc...@gcc.gnu.org >> Subject: Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430) >> >> On 6/21/19 6:23 AM, Richard Bi

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-07-12 Thread Jeff Law
On 7/11/19 10:08 PM, Andrew Pinski wrote: > On Mon, Jul 8, 2019 at 12:39 AM JiangNing OS > wrote: >> >> Hi Jeff and Richard B., >> >> Following your tips, I've found a much simpler solution in >> tree-ssa-phiopt.c. Attached is the new patch. Review again, please! > > /* Prove that we can move

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-07-11 Thread Andrew Pinski
g > > > -Original Message- > > From: Jeff Law > > Sent: Saturday, June 22, 2019 12:10 AM > > To: Richard Biener > > Cc: JiangNing OS ; gcc- > > patc...@gcc.gnu.org > > Subject: Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430) > > &g

RE: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-07-08 Thread JiangNing OS
hard Biener > Cc: JiangNing OS ; gcc- > patc...@gcc.gnu.org > Subject: Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430) > > On 6/21/19 6:23 AM, Richard Biener wrote: > > > > That looks like a pretty easy form to analyze. I'd suggest looking > &

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-21 Thread Jeff Law
On 6/21/19 6:23 AM, Richard Biener wrote: > > That looks like a pretty easy form to analyze. I'd suggest looking > through tree-ssa-phiopt.c closely. There's several transformations > in there that share similarities with yours. > > > More specifically there is the conditional store eliminati

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-21 Thread Richard Biener
On Fri, Jun 21, 2019 at 1:13 AM Jeff Law wrote: > On 6/20/19 3:53 AM, JiangNing OS wrote: > > Hi Jeff, > > > > Appreciate your effort to review my patch! I've updated my patch as > attached. See my answers below. > > > >> in current function, so the store speculation can be avoided. > >> So at a

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-20 Thread Jeff Law
On 6/20/19 3:53 AM, JiangNing OS wrote: > Hi Jeff, > > Appreciate your effort to review my patch! I've updated my patch as attached. > See my answers below. > >> in current function, so the store speculation can be avoided. >> So at a high level should we be doing this in gimple rather than RTL?

RE: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-20 Thread JiangNing OS
Hi Jeff, Appreciate your effort to review my patch! I've updated my patch as attached. See my answers below. > in current function, so the store speculation can be avoided. > So at a high level should we be doing this in gimple rather than RTL? > We're going to have a lot more information about

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-17 Thread Jeff Law
On 3/14/19 10:46 PM, JiangNing OS wrote: > This patch is to fix a missing ifcvt opportunity in back-end. For the simple > case below, > > if (...) > x = a; /* x is memory */ > /* no else */ > > We can generate conditional move and remove the branch as below if the target > cost is acceptab

RE: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-06-16 Thread JiangNing OS
Hi, May I know any feedback comments to this patch? Thanks, -Jiangning From: Kyrill Tkachov Sent: Friday, May 24, 2019 10:55 PM To: JiangNing OS ; gcc-patches@gcc.gnu.org Cc: ebotca...@adacore.com; ste...@gcc.gnu.org; l...@redhat.com Subject: Re: [PATCH] improve ifcvt optimization (PR rtl

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-05-24 Thread Kyrill Tkachov
Hi Jiangning On 3/15/19 4:46 AM, JiangNing OS wrote: This patch is to fix a missing ifcvt opportunity in back-end. For the simple case below, if (...)     x = a;  /* x is memory */ /* no else */ We can generate conditional move and remove the branch as below if the target cost is acceptable.

RE: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-05-04 Thread JiangNing OS
: JiangNing OS ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430) On 3/14/19 10:46 PM, JiangNing OS wrote: > This patch is to fix a missing ifcvt opportunity in back-end. For the > simple case below, > > if (...) > x = a; /* x i

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-04-30 Thread Jeff Law
On 3/14/19 10:46 PM, JiangNing OS wrote: > This patch is to fix a missing ifcvt opportunity in back-end. For the simple > case below, > > if (...) > x = a; /* x is memory */ > /* no else */ > > We can generate conditional move and remove the branch as below if the target > cost is acceptab

Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)

2019-03-18 Thread Jeff Law
On 3/14/19 10:46 PM, JiangNing OS wrote: > This patch is to fix a missing ifcvt opportunity in back-end. For the simple > case below, > > if (...) > x = a; /* x is memory */ > /* no else */ > > We can generate conditional move and remove the branch as below if the target > cost is acceptab