Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2021-01-21 Thread Jan Hubicka
istina ; Martin Jambor > > ; Richard Sandiford ; > > luoxhu via Gcc-patches > > Cc: seg...@kernel.crashing.org; wschm...@linux.ibm.com; > > li...@gcc.gnu.org; Jan Hubicka ; dje@gmail.com > > Subject: Re: [PATCH] ipa-inline: Improve growth accumulation for recursive > > cal

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2021-01-21 Thread Tamar Christina via Gcc-patches
tin Jambor > ; Richard Sandiford ; > luoxhu via Gcc-patches > Cc: seg...@kernel.crashing.org; wschm...@linux.ibm.com; > li...@gcc.gnu.org; Jan Hubicka ; dje....@gmail.com > Subject: Re: [PATCH] ipa-inline: Improve growth accumulation for recursive > calls > > > > On 2

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-10-16 Thread Xionghu Luo via Gcc-patches
On 2020/9/12 01:36, Tamar Christina wrote: > Hi Martin, > >> >> can you please confirm that the difference between these two is all due to >> the last option -fno-inline-functions-called-once ? Is LTo necessary? >> I.e., can >> you run the benchmark also built with the branch compiler and -m

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-09-16 Thread Hongyu Wang via Gcc-patches
Tamar Christina 于2020年9月12日周六 上午1:39写道: > Hi Martin, > > > > > can you please confirm that the difference between these two is all due > to > > the last option -fno-inline-functions-called-once ? Is LTo necessary? > I.e., can > > you run the benchmark also built with the branch compiler and > -m

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-09-11 Thread Tamar Christina
Hi Martin, > > can you please confirm that the difference between these two is all due to > the last option -fno-inline-functions-called-once ? Is LTo necessary? I.e., > can > you run the benchmark also built with the branch compiler and -mcpu=native > -Ofast -fomit-frame-pointer -fno-inline-f

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-09-11 Thread Martin Jambor
Hi, On Fri, Sep 11 2020, Tamar Christina wrote: > Hi Martin, > >> On Fri, Aug 21 2020, Tamar Christina wrote: >> >> >> >> Honza's changes have been motivated to big extent as an enabler for >> >> IPA-CP heuristics changes to actually speed up 548.exchange2_r. >> >> >> >> On my AMD Zen2 machine, th

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-09-11 Thread Tamar Christina
gcc.gnu.org; Jan Hubicka > ; dje....@gmail.com > Subject: RE: [PATCH] ipa-inline: Improve growth accumulation for recursive > calls > > Hi, > > On Fri, Aug 21 2020, Tamar Christina wrote: > >> > >> Honza's changes have been motivated to big extent as an

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-09-08 Thread Martin Jambor
Hi, On Fri, Aug 21 2020, Tamar Christina wrote: >> >> Honza's changes have been motivated to big extent as an enabler for IPA-CP >> heuristics changes to actually speed up 548.exchange2_r. >> >> On my AMD Zen2 machine, the run-time of exchange2 was 358 seconds two >> weeks ago, this week it is 4

RE: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-21 Thread Tamar Christina
Hi Martin, > Hi, > > On Thu, Aug 20 2020, Richard Sandiford wrote: > >> > >> > >> Really appreciate for your detailed explanation. BTW, My previous > >> patch for PGO build on exchange2 takes this similar method by setting > >> each cloned node to 1/10th of the frequency several month agao :) >

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-20 Thread Martin Jambor
Hi, On Thu, Aug 20 2020, Richard Sandiford wrote: >> >> >> Really appreciate for your detailed explanation. BTW, My previous patch >> for PGO build on exchange2 takes this similar method by setting each cloned >> node to 1/10th of the frequency several month agao :) >> >> https://gcc.gnu.org/pipe

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-20 Thread Richard Sandiford
Xionghu, thanks for working on fixing the exchange regression. luoxhu via Gcc-patches writes: > On 2020/8/13 20:52, Jan Hubicka wrote: >>> Since there are no other callers outside of these specialized nodes, the >>> guessed profile count should be same equal? Perf tool shows that even >>> each s

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-14 Thread luoxhu via Gcc-patches
Hi, On 2020/8/13 20:52, Jan Hubicka wrote: >> Since there are no other callers outside of these specialized nodes, the >> guessed profile count should be same equal? Perf tool shows that even >> each specialized node is called only once, none of them take same time for >> each call: >> >>40.6

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-13 Thread Jan Hubicka
> > Thanks for the information :) Tamar replied that there is another > regression *on exchange2 is 11%.*, I've also rebased my code and confirmed > it really getting even slower than before (revert the patch could pull the > performance back)... Yep, we need to figure out how to fix this - the

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-13 Thread Jan Hubicka
> Hi! > > On Wed, Aug 12, 2020 at 09:03:35PM +0200, Richard Biener wrote: > > On August 12, 2020 7:53:07 PM GMT+02:00, Jan Hubicka wrote: > > >> From: Xiong Hu Luo > > >> 523.xalancbmk_r +1.32% > > >> 541.leela_r +1.51% > > >> 548.exchange2_r +31.87% > > >> 507.cactuBSSN_r +0.80% > > >> 526.

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread luoxhu via Gcc-patches
Hi, On 2020/8/13 01:53, Jan Hubicka wrote: > Hello, > with Martin we spent some time looking into exchange2 and my > understanding of the problem is the following: > > There is the self recursive function digits_2 with the property that it > has 10 nested loops and calls itself from the innermost

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Feng Xue OS via Gcc-patches
> Hello, > with Martin we spent some time looking into exchange2 and my > understanding of the problem is the following: > > There is the self recursive function digits_2 with the property that it > has 10 nested loops and calls itself from the innermost. > Now we do not do amazing job on guessing

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Segher Boessenkool
Hi! On Wed, Aug 12, 2020 at 09:03:35PM +0200, Richard Biener wrote: > On August 12, 2020 7:53:07 PM GMT+02:00, Jan Hubicka wrote: > >> From: Xiong Hu Luo > >> 523.xalancbmk_r +1.32% > >> 541.leela_r +1.51% > >> 548.exchange2_r +31.87% > >> 507.cactuBSSN_r +0.80% > >> 526.blender_r +1.25% >

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Richard Biener via Gcc-patches
On August 12, 2020 7:53:07 PM GMT+02:00, Jan Hubicka wrote: >Hello, >with Martin we spent some time looking into exchange2 and my >understanding of the problem is the following: > >There is the self recursive function digits_2 with the property that it >has 10 nested loops and calls itself from th

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Jan Hubicka
Hello, with Martin we spent some time looking into exchange2 and my understanding of the problem is the following: There is the self recursive function digits_2 with the property that it has 10 nested loops and calls itself from the innermost. Now we do not do amazing job on guessing the profile s