RE: [PATCH 1/1] libiberty(argv.c): Fix memory leak in expandargv.

2021-02-18 Thread Maninder Singh via Gcc-patches
Hi Martin, >> Dynamic memory referenced by 'buffer' was allocated using xmalloc but fails >> to free it >> when jump to 'error' label. >> >> Issue as per static analysis tool. > >The change looks okay to me although I can't approve it. Since GCC >is a regression fixing stage, unless the leak i

Re: [PATCH 1/1] libiberty(argv.c): Fix memory leak in expandargv.

2021-02-18 Thread Martin Sebor via Gcc-patches
On 2/18/21 3:58 AM, Ayush Mittal via Gcc-patches wrote: Dynamic memory referenced by 'buffer' was allocated using xmalloc but fails to free it when jump to 'error' label. Issue as per static analysis tool. The change looks okay to me although I can't approve it. Since GCC is a regression fix

Re: [PATCH 1/1] libiberty(argv.c): Fix memory leak in expandargv.

2021-02-18 Thread Prathamesh Kulkarni via Gcc-patches
On Thu, 18 Feb 2021 at 16:32, Ayush Mittal via Gcc-patches wrote: > > Dynamic memory referenced by 'buffer' was allocated using xmalloc but fails > to free it > when jump to 'error' label. > > Issue as per static analysis tool. > > Signed-off-by: Ayush Mittal > Signed-off-by: Maninder Singh > -