> -----Original Message----- > From: Andrea Corallo <andrea.cora...@arm.com> > Sent: Thursday, November 24, 2022 2:44 PM > To: Kyrylo Tkachov <kyrylo.tkac...@arm.com> > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw > <richard.earns...@arm.com> > Subject: [PATCH 35/35 V2] arm: improve tests for vsetq_lane* > > Kyrylo Tkachov <kyrylo.tkac...@arm.com> writes: > > [...] > > >> diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vsetq_lane_f16.c > >> b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vsetq_lane_f16.c > >> index e03e9620528..b5c9f4d5eb8 100644 > >> --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vsetq_lane_f16.c > >> +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vsetq_lane_f16.c > >> @@ -1,15 +1,45 @@ > >> -/* { dg-skip-if "Incompatible float ABI" { *-*-* } { "-mfloat-abi=soft" } > >> {""} } > */ > >> /* { dg-require-effective-target arm_v8_1m_mve_fp_ok } */ > >> /* { dg-add-options arm_v8_1m_mve_fp } */ > >> /* { dg-additional-options "-O2" } */ > >> +/* { dg-final { check-function-bodies "**" "" } } */ > >> > >> #include "arm_mve.h" > >> > >> +/* > >> +**foo: > >> +** ... > >> +** vmov.16 q[0-9]+\[[0-9]+\], (?:ip|fp|r[0-9]+)(?: @.*|) > >> +** ... > >> +*/ > >> float16x8_t > >> foo (float16_t a, float16x8_t b) > >> { > >> - return vsetq_lane_f16 (a, b, 0); > >> + return vsetq_lane_f16 (a, b, 1); > >> } > >> > > > > Hmm, for these tests we should be able to scan for more specific codegen > as we're setting individual lanes, so we should be able to scan for lane 1 in > the vmov instruction, though it may need to be flipped for big-endian. > > Thanks, > > Kyrill > > Hi Kyrill, > > please find attached the updated version of this patch. > > Big-endian should not be a problem as for my understanding is just not > supported with MVE intrinsics. Huh, that's right. This version is ok. Thanks! Kyrill > > Thanks! > > Andrea
RE: [PATCH 35/35 V2] arm: improve tests for vsetq_lane*
Kyrylo Tkachov via Gcc-patches Thu, 24 Nov 2022 07:29:21 -0800
- [PATCH 10/35] arm: improve tests for vabav... Andrea Corallo via Gcc-patches
- RE: [PATCH 10/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- Re: [PATCH 10/35] arm: improve te... Andrea Corallo via Gcc-patches
- [PATCH 05/35] arm: improve vidupq* tests Andrea Corallo via Gcc-patches
- RE: [PATCH 05/35] arm: improve vidupq... Kyrylo Tkachov via Gcc-patches
- [PATCH 06/35] arm: improve tests and fix v... Andrea Corallo via Gcc-patches
- RE: [PATCH 06/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- [PATCH 35/35] arm: improve tests for vsetq... Andrea Corallo via Gcc-patches
- RE: [PATCH 35/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- [PATCH 35/35 V2] arm: improve tes... Andrea Corallo via Gcc-patches
- RE: [PATCH 35/35 V2] arm: imp... Kyrylo Tkachov via Gcc-patches
- [PATCH 31/35] arm: improve tests for vqrdm... Andrea Corallo via Gcc-patches
- RE: [PATCH 31/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- [PATCH 20/35] arm: improve tests for vfmas... Andrea Corallo via Gcc-patches
- RE: [PATCH 20/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- [PATCH 12/35] arm: improve tests and fix v... Andrea Corallo via Gcc-patches
- RE: [PATCH 12/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- [PATCH 11/35] arm: improve tests for vabdq... Andrea Corallo via Gcc-patches
- RE: [PATCH 11/35] arm: improve tests ... Kyrylo Tkachov via Gcc-patches
- [PATCH 16/35] arm: Add integer vector over... Andrea Corallo via Gcc-patches
- Re: [PATCH 16/35] arm: Add integer ve... Christophe Lyon via Gcc-patches