Re: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-24 Thread Richard Biener via Gcc-patches
> gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH PR94708] rtl combine should consider NaNs when generate > > fp min/max > > > > On Fri, Apr 24, 2020 at 5:05 AM Zhanghaijian (A) > > wrote: > > > > > > Thanks for your suggestions. For safety,

RE: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-24 Thread Zhanghaijian (A)
> -Original Message- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: Friday, April 24, 2020 2:19 PM > To: Zhanghaijian (A) > Cc: Segher Boessenkool ; > gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR94708] rtl combine should consider NaNs when

Re: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-24 Thread Richard Biener via Gcc-patches
,varb,varc > + REAL, INTENT(out) :: res > + > + res = vara > + if (res .lt. varb) res = varb > + if (res .gt. varc) res = varc > +end subroutine > + > +! { dg-final { scan-rtl-dump-not "smin" "combine" } } > -- > 2.19.1 > >

RE: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-23 Thread Zhanghaijian (A)
uot; "combine" } } -- 2.19.1 -Original Message- From: Segher Boessenkool [mailto:seg...@kernel.crashing.org] Sent: Friday, April 24, 2020 1:05 AM To: Zhanghaijian (A) Cc: Richard Biener ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH PR94708] rtl combine should consider NaNs when gener

Re: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-23 Thread Segher Boessenkool
Hi! On Thu, Apr 23, 2020 at 02:34:03PM +, Zhanghaijian (A) wrote: > Thanks for your suggestions. I have modified accordingly. > Attached please find the adapted patch. Bootstrap and tested on aarch64 Linux > platform. > Does the v2 patch look batter? > > diff --git a/gcc/combine.c

RE: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-23 Thread Zhanghaijian (A)
-patches@gcc.gnu.org Subject: Re: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max Hi! On Thu, Apr 23, 2020 at 11:05:22AM +0200, Richard Biener wrote: > On Thu, Apr 23, 2020 at 10:42 AM Zhanghaijian (A) > wrote: > > This is a simple fix for pr94708. > &

Re: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-23 Thread Segher Boessenkool
Hi! On Thu, Apr 23, 2020 at 11:05:22AM +0200, Richard Biener wrote: > On Thu, Apr 23, 2020 at 10:42 AM Zhanghaijian (A) > wrote: > > This is a simple fix for pr94708. > > It's unsafe for rtl combine to generate fp min/max under > > -funsafe-math-optimizations, considering NaNs. > > We can only

Re: [PATCH PR94708] rtl combine should consider NaNs when generate fp min/max

2020-04-23 Thread Richard Biener via Gcc-patches
On Thu, Apr 23, 2020 at 10:42 AM Zhanghaijian (A) wrote: > > Hi > > This is a simple fix for pr94708. > It's unsafe for rtl combine to generate fp min/max under > -funsafe-math-optimizations, considering NaNs. > We can only do this kind of transformation under -funsafe-math-optimizations > and