RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-18 Thread Bin Cheng
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Wednesday, October 17, 2012 1:02 AM > To: Bin Cheng > Cc: 'Steven Bosscher'; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH RFA] Implement register pressure directed hoist pass > >

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-16 Thread Jeff Law
On 10/16/2012 01:44 AM, Bin Cheng wrote: Hi Steven, Jeff, I found a flaw in original patch, which results in inaccurate register pressure. Here comes the updated patches, improving code size a little bit on Thumb2/powerpc comparing to original patches. Please review. Thanks 2012-10-16 Bin Chen

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-16 Thread Bin Cheng
m: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of Bin Cheng > Sent: Friday, October 12, 2012 4:09 PM > To: 'Steven Bosscher' > Cc: Jeff Law; gcc-patches@gcc.gnu.org > Subject: RE: [PATCH RFA] Implement register pressure directed hoist pass

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-12 Thread Bin Cheng
Hi, This is the updated patches split from original one according to Steven's suggestion. Also fixed spelling errors. Apart from this, I also implemented a draft patch simulating register pressure accurately during hoisting, unfortunately the size data isn't better than this patch. If it's right,

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-11 Thread Bin Cheng
> -Original Message- > From: Steven Bosscher [mailto:stevenb@gmail.com] > Sent: Friday, October 12, 2012 7:04 AM > To: Bin Cheng > Cc: Jeff Law; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH RFA] Implement register pressure directed hoist pass > > On Thu,

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-11 Thread Steven Bosscher
On Thu, Oct 11, 2012 at 8:50 AM, Bin Cheng wrote: > + /* x+y won't be hoisted without defaultly enabled "-fira-hoist-pressure", defaulty comment. > + kinds of code motion(including code hoisting) in a unified way. needs space between "motion" and "(". > + flow graph, given if it can rea

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-10 Thread Bin Cheng
2 8:58 PM > To: Bin Cheng > Cc: 'Steven Bosscher'; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH RFA] Implement register pressure directed hoist pass > > On 09/29/2012 12:37 AM, Bin Cheng wrote: > > Hi Steven, > > > > This is the updated patch according to y

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-07 Thread Bin Cheng
Hi Jeff, Thanks for reviewing and sorry for this delayed message. > > > + /* Only decrease distance if bb has high register pressure or EXPR > > +is const expr, otherwise EXPR can be hoisted through bb without > > +cost. */ > ?!? This comment makes no sense to me. To accurately kn

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-07 Thread Bin Cheng
Hi Steven, Thanks for the comments and sorry for the delay with this message. > -Original Message- > > Hello, > > Thanks for the update. The first look wasn't a very thorough review, so I have > more comments now. Sorry for that, I should have taken the time for this the > first time rou

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-02 Thread Jeff Law
On 09/29/2012 12:37 AM, Bin Cheng wrote: Hi Steven, This is the updated patch according to your comments. Please review. I also re-collected code size data and found it is improved by about 0.24% for mips, which is better than previous data. I believe this should be caused by recent changes in t

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-10-01 Thread Steven Bosscher
On Sat, Sep 29, 2012 at 8:37 AM, Bin Cheng wrote: > This is the updated patch according to your comments. Please review. > I also re-collected code size data and found it is improved by about 0.24% > for mips, which is better than previous data. I believe this should be > caused by recent changes

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-09-28 Thread Bin Cheng
> -Original Message- > From: Steven Bosscher [mailto:stevenb@gmail.com] > Sent: Friday, September 28, 2012 4:29 PM > To: Bin Cheng > Cc: gcc-patches@gcc.gnu.org; Eric Botcazou; Richard Sandiford; > vmaka...@redhat.com > Subject: Re: [PATCH RFA] Implement regis

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-09-28 Thread Pedro Alves
On 09/28/2012 09:29 AM, Steven Bosscher wrote: > On Fri, Sep 28, 2012 at 9:18 AM, Bin Cheng wrote: >> (get_regno_pressure_class, get_pressure_class_and_nregs) > > Broken long lines in a ChangeLog entry end with a ",". >From >

RE: [PATCH RFA] Implement register pressure directed hoist pass

2012-09-28 Thread Bin Cheng
Thanks for comments. > -Original Message- > From: Steven Bosscher [mailto:stevenb@gmail.com] > Sent: Friday, September 28, 2012 4:29 PM > To: Bin Cheng > Cc: gcc-patches@gcc.gnu.org; Eric Botcazou; Richard Sandiford; > vmaka...@redhat.com > Subject: Re: [PATCH RF

Re: [PATCH RFA] Implement register pressure directed hoist pass

2012-09-28 Thread Steven Bosscher
On Fri, Sep 28, 2012 at 9:18 AM, Bin Cheng wrote: > (get_regno_pressure_class, get_pressure_class_and_nregs) Broken long lines in a ChangeLog entry end with a ",". > (change_pressure, mark_regno_live, mark_regno_death, mark_reg_death) > (mark_reg_store, mark_reg_clobber,