RE: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread Li, Pan2 via Gcc-patches
; pal...@rivosinc.com Subject: Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119] On 6/14/23 05:56, Lehua Ding wrote: > The V2 patch address comments from Juzhe, thanks. > > Hi, > > The reason for this bug is that in the case where the

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread Jeff Law via Gcc-patches
On 6/14/23 05:56, Lehua Ding wrote: The V2 patch address comments from Juzhe, thanks. Hi, The reason for this bug is that in the case where the vector register is set to a fixed length (with `--param=riscv-autovec-preference=fixed-vlmax` option), TARGET_PASS_BY_REFERENCE thinks that

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread Jeff Law via Gcc-patches
On 6/14/23 06:05, Robin Dapp via Gcc-patches wrote: Oh. I see Robin's email is also wrong. CC Robin too for you It still arrived via the mailing list ;) Good to see a Fix patch of the ICE before Vector ABI patch. Let's wait for more comments. LGTM, this way I don't even need to

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread Jeff Law via Gcc-patches
On 6/14/23 06:01, juzhe.zh...@rivai.ai wrote: LGTM now. Thanks for fixing it. Good to see a Fix patch of the ICE before Vector ABI patch. Let's wait for more comments. Lehua Ding takes care of Vector ABI implementation and hopefully will send it soon. It seems the email of Jeff is wrong.

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread Robin Dapp via Gcc-patches
> Oh. I see Robin's email is also wrong. CC Robin too for you  It still arrived via the mailing list ;) > Good to see a Fix patch of the ICE before Vector ABI patch. > Let's wait for more comments. LGTM, this way I don't even need to rewrite my tests. Regards Robin

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread juzhe.zh...@rivai.ai
LGTM now. Thanks for fixing it. Good to see a Fix patch of the ICE before Vector ABI patch. Let's wait for more comments. Lehua Ding takes care of Vector ABI implementation and hopefully will send it soon. It seems the email of Jeff is wrong. CC Jeff .for you. Oh. I see Robin's email is

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread juzhe.zh...@rivai.ai
LGTM now. Thanks for fixing it. Good to see a Fix patch of the ICE before Vector ABI patch. Let's wait for more comments. Lehua Ding takes care of Vector ABI implementation and hopefully will send it soon. It seems the email of Jeff is wrong. CC Jeff .for you. Thanks.

Re: [PATCH V2] RISC-V: Ensure vector args and return use function stack to pass [PR110119]

2023-06-14 Thread juzhe.zh...@rivai.ai
LGTM now. Thanks for fixing it. Good to see a Fix patch of the ICE before Vector ABI patch. Let's wait for more comments. Lehua Ding takes care of Vector ABI implementation and hopefully will send it soon. Thanks. juzhe.zh...@rivai.ai From: Lehua Ding Date: 2023-06-14 19:56 To: gcc-patches