Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-14 Thread juzhe.zh...@rivai.ai
For conversion API, I would prefer kito review since I am not sure about this stuff. juzhe.zh...@rivai.ai From: pan2.li Date: 2023-08-15 10:55 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API Fr

Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-15 Thread Kito Cheng via Gcc-patches
Just a random idea came to my mind, maybe we could introduce one more template argument to reduce those codes for rounding mode intrinsic stuff? example: diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc index 2074dac0f16..9cc60842a5b 1

RE: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-15 Thread Li, Pan2 via Gcc-patches
: + bool has_rounding_mode_operand_p () const override { return true; } +}; Pan -Original Message- From: Kito Cheng Sent: Tuesday, August 15, 2023 11:34 PM To: juzhe.zh...@rivai.ai Cc: Li, Pan2 ; gcc-patches ; Wang, Yanzhang Subject: Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic

Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-15 Thread Kito Cheng via Gcc-patches
Or using an enum value rather than bool? I am thinking we could also simplify/remove most other frm classes, some practical example: diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc index 2074dac0f16..ace63e963a5 100644 --- a/gcc/conf

RE: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-15 Thread Li, Pan2 via Gcc-patches
- From: Kito Cheng Sent: Wednesday, August 16, 2023 11:30 AM To: Li, Pan2 Cc: juzhe.zh...@rivai.ai; gcc-patches ; Wang, Yanzhang Subject: Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API Or using an enum value rather than bool? I am thinking we could also simplify/remove

Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-15 Thread Kito Cheng via Gcc-patches
Cc: juzhe.zh...@rivai.ai; gcc-patches ; Wang, > Yanzhang > Subject: Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode > intrinsic API > > Or using an enum value rather than bool? > > I am thinking we could also simplify/remove most other frm classes, > som

RE: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode intrinsic API

2023-08-15 Thread Li, Pan2 via Gcc-patches
16, 2023 11:30 AM > To: Li, Pan2 > Cc: juzhe.zh...@rivai.ai; gcc-patches ; Wang, > Yanzhang > Subject: Re: [PATCH v1] RISC-V: Support RVV VFCVT.X.F.V rounding mode > intrinsic API > > Or using an enum value rather than bool? > > I am thinking we could also simplify/r