Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-07 Thread Jakub Jelinek
On Mon, Sep 07, 2015 at 05:46:12PM +0300, Ilya Verbin wrote: > On Sat, Sep 05, 2015 at 00:45:36 +0300, Ilya Verbin wrote: > > 2015-09-04 22:27 GMT+03:00 Mike Stump : > > > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas > > > wrote: > > >* intelmic-mkoffload.c (prepare_target_image): Fix if t

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-07 Thread Ilya Verbin
On Sat, Sep 05, 2015 at 00:45:36 +0300, Ilya Verbin wrote: > 2015-09-04 22:27 GMT+03:00 Mike Stump : > > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas > > wrote: > >* intelmic-mkoffload.c (prepare_target_image): Fix if the temp path > >contains a '-‘. > > > > So, out of curiosity, d

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Ilya Verbin
2015-09-05 1:50 GMT+03:00 Mike Stump : > > On Sep 4, 2015, at 2:45 PM, Ilya Verbin wrote: > >> 2015-09-04 22:27 GMT+03:00 Mike Stump : >>> On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas >>> wrote: >>> * intelmic-mkoffload.c (prepare_target_image): Fix if the temp path >>> contains a '-‘

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Mike Stump
On Sep 4, 2015, at 2:45 PM, Ilya Verbin wrote: > 2015-09-04 22:27 GMT+03:00 Mike Stump : >> On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas >> wrote: >> * intelmic-mkoffload.c (prepare_target_image): Fix if the temp path >> contains a '-‘. >> >> So, out of curiosity, did you test all

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Ilya Verbin
2015-09-04 22:27 GMT+03:00 Mike Stump : > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas > wrote: >* intelmic-mkoffload.c (prepare_target_image): Fix if the temp path >contains a '-‘. > > So, out of curiosity, did you test all characters other than null? If - > doesn’t work, there

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Mike Stump
On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas wrote: * intelmic-mkoffload.c (prepare_target_image): Fix if the temp path contains a '-‘. So, out of curiosity, did you test all characters other than null? If - doesn’t work, there is a good chance that no such test has been done, an

RE: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Hahnfeld, Jonas
> -Original Message- > From: Ilya Verbin [mailto:iver...@gmail.com] > Sent: Friday, September 04, 2015 1:23 PM > To: Hahnfeld, Jonas; Jakub Jelinek > Cc: gcc-patches@gcc.gnu.org; Kirill Yukhin > Subject: Re: Fix intelmic-mkoffload.c if the temp path contains a '-

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Ilya Verbin
On Fri, Sep 04, 2015 at 11:10:13 +, Hahnfeld, Jonas wrote: > *ping* > I don't have write access to the repository... I've committed it to trunk: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227489 What about gcc-5-branch? -- Ilya

RE: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-04 Thread Hahnfeld, Jonas
> -Original Message- > From: Hahnfeld, Jonas > Sent: Tuesday, September 01, 2015 1:54 PM > To: 'Jakub Jelinek' > Cc: gcc-patches@gcc.gnu.org; Ilya Verbin; Kirill Yukhin > Subject: RE: Fix intelmic-mkoffload.c if the temp path contains a '-' > >

RE: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-01 Thread Hahnfeld, Jonas
> -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Tuesday, September 01, 2015 1:50 PM > To: Hahnfeld, Jonas > Cc: gcc-patches@gcc.gnu.org; Ilya Verbin; Kirill Yukhin > Subject: Re: Fix intelmic-mkoffload.c if the temp path contains a '-

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-01 Thread Jakub Jelinek
On Tue, Sep 01, 2015 at 11:35:15AM +, Hahnfeld, Jonas wrote: > >From 884b6199179e7a604474bc6a828a6861d3ff4501 Mon Sep 17 00:00:00 2001 > From: Jonas Hahnfeld > Date: Thu, 20 Aug 2015 12:13:55 +0200 > Subject: [PATCH] Fix intelmic-mkoffload.c if the temp path contains a '-' > > 2015-08-20 Jon

Re: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-01 Thread Ilya Verbin
On Tue, Sep 01, 2015 at 11:35:15 +, Hahnfeld, Jonas wrote: > > during my test of OpenMP 4.0 offloading features I have found a bug in > > intelmic-mkoffload.c when the temp path contains a '-'. > > objcopy will in this case replace it with a '_' which wasn't reflected in > > the original code a

RE: Fix intelmic-mkoffload.c if the temp path contains a '-'

2015-09-01 Thread Hahnfeld, Jonas
Hopefully CC'ing the right people... > -Original Message- > From: Hahnfeld, Jonas > Sent: Thursday, August 20, 2015 12:25 PM > To: 'gcc-patches@gcc.gnu.org' > Subject: Fix intelmic-mkoffload.c if the temp path contains a '-' > > Hi all, > > during my test of OpenMP 4.0 offloading feature