RE: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-27 Thread Li, Pan2 via Gcc-patches
Law ; rdapp.gcc ; kito.cheng Cc: gcc-patches ; Wang, Yanzhang Subject: RE: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding Thanks Juzhe and Jeff for suggestion. The approach like emit_insn_before_noloc will result in below ICE here. ../../../.././gcc/libs

RE: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread Li, Pan2 via Gcc-patches
handling when end bb is CALL. Pan From: 钟居哲 Sent: Thursday, July 27, 2023 6:56 AM To: Jeff Law ; rdapp.gcc ; kito.cheng ; Li, Pan2 Cc: gcc-patches ; Wang, Yanzhang Subject: Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding Thanks Jeff. Hi, Pan: Plz try (insert

Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread 钟居哲
Thanks Jeff. Hi, Pan: Plz try (insert edge and put 'frrm' on that edge) instead of insert end of block to see whether it works (I have tried onece but I don't remember what happens). Try that with following codes: edge eg; edge_iterator ei; FOR_EACH_EDGE (eg, ei, bb->succs) { start_sequence ();

Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread 钟居哲
Hi, Jeff. insert_insn_end_basic_block is to handle this following case: bb 1: ... CALL.>BB_END of bb bb 2: vfadd rne You can see there is no instructions after CALL. So you we use insert_insn_end_basic_block insert a "frrm" at the end of the bb 1. I know typically it's better to insert a

Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread Palmer Dabbelt
钟居哲 *Sent:* Wednesday, July 26, 2023 10:18 PM *To:* rdapp.gcc ; Li, Pan2 *Cc:* rdapp.gcc ; kito.cheng ; gcc-patches ; Wang, Yanzhang < yanzhang.w...@intel.com> *Subject:* Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding Explicitly backup and restore for

Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread Kito Cheng via Gcc-patches
cc-patches ; Wang, Yanzhang < > yanzhang.w...@intel.com> > *Subject:* Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point > dynamic rounding > > > > Explicitly backup and restore for each intrinsic just the same as we did > for CALL in this patch. > > >

RE: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread Li, Pan2 via Gcc-patches
fully tests depend on this. Of course, I am working on PATCH v8 and thanks again for Robin’s comments. Pan From: 钟居哲 Sent: Wednesday, July 26, 2023 10:18 PM To: rdapp.gcc ; Li, Pan2 Cc: rdapp.gcc ; kito.cheng ; gcc-patches ; Wang, Yanzhang Subject: Re: Re: [PATCH v7] RISC-V: Support CALL for

Re: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding

2023-07-26 Thread 钟居哲
Explicitly backup and restore for each intrinsic just the same as we did for CALL in this patch. I can't have the data to prove how good we use LCM/PRE of mode switching but I trust it. Since the the LCM/PRE is the key optimization method of VSETVL PASS which is doing good job on VSETVL instru