RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-07 Thread Prathamesh Kulkarni
> -Original Message- > From: Jakub Jelinek > Sent: Wednesday, August 7, 2024 11:27 PM > To: Prathamesh Kulkarni > Cc: Richard Biener ; Richard Sandiford > ; gcc-patches@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it&

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-07 Thread Jakub Jelinek
On Wed, Aug 07, 2024 at 05:53:00PM +, Prathamesh Kulkarni wrote: > > Two spaces after . rather than just one, and because of that move in > > on the next line. > > > > > + host_num_poly_int_coeffs. */ > > > > Otherwise LGTM. > Thanks, I have adjusted the formatting of the comment and a typ

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-07 Thread Prathamesh Kulkarni
> -Original Message- > From: Jakub Jelinek > Sent: Monday, August 5, 2024 8:01 PM > To: Prathamesh Kulkarni > Cc: Richard Biener ; Richard Sandiford > ; gcc-patches@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it's > degree &

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-05 Thread Jakub Jelinek
On Mon, Aug 05, 2024 at 02:24:00PM +, Prathamesh Kulkarni wrote: > gcc/ChangeLog: > PR ipa/96265 > PR ipa/111937 > * data-streamer-in.cc (streamer_read_poly_uint64): Remove code for > streaming, and call poly_int_read_common instead. > (streamer_read_poly_int64):

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-05 Thread Prathamesh Kulkarni
> -Original Message- > From: Jakub Jelinek > Sent: Friday, August 2, 2024 5:43 PM > To: Prathamesh Kulkarni > Cc: Richard Biener ; Richard Sandiford > ; gcc-patches@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it's > degree &

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-02 Thread Jakub Jelinek
On Fri, Aug 02, 2024 at 11:58:19AM +, Prathamesh Kulkarni wrote: > diff --git a/gcc/data-streamer-in.cc b/gcc/data-streamer-in.cc > index 7dce2928ef0..7b9d8cc0129 100644 > --- a/gcc/data-streamer-in.cc > +++ b/gcc/data-streamer-in.cc > @@ -182,10 +182,8 @@ streamer_read_hwi (class lto_input_blo

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-02 Thread Prathamesh Kulkarni
> -Original Message- > From: Jakub Jelinek > Sent: Wednesday, July 31, 2024 8:46 PM > To: Prathamesh Kulkarni > Cc: Richard Biener ; Richard Sandiford > ; gcc-patches@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it&

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-31 Thread Jakub Jelinek
On Wed, Jul 31, 2024 at 02:58:34PM +, Prathamesh Kulkarni wrote: > There are a couple of issues in the patch: > (1) The patch streams out NUM_POLY_INT_COEFFS at beginning of mode_table, > which should work for bp_unpack_poly_value, > (since AFAIK, it's only called by lto_input_mode_table). How

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-31 Thread Prathamesh Kulkarni
> -Original Message- > From: Tobias Burnus > Sent: Tuesday, July 30, 2024 6:08 PM > To: Prathamesh Kulkarni ; gcc- > patc...@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it's > degree <= accel's NUM_POLY_INT_COEFFS >

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-31 Thread Prathamesh Kulkarni
> -Original Message- > From: Prathamesh Kulkarni > Sent: Tuesday, July 30, 2024 4:44 PM > To: Jakub Jelinek ; Richard Biener > > Cc: Richard Sandiford ; gcc- > patc...@gcc.gnu.org > Subject: RE: Support streaming of poly_int for offloading when

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Tobias Burnus
Prathamesh Kulkarni wrote: Thanks for your suggestions on RFC email, the attached patch adds support for streaming of poly_int when it's degree <= accel's NUM_POLY_INT_COEFFS. First, thanks a lot for your patch! Secondly, it seems as if this patch is indented to fully or partially fix the fo

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Prathamesh Kulkarni
> -Original Message- > From: Jakub Jelinek > Sent: Tuesday, July 30, 2024 3:16 PM > To: Richard Biener > Cc: Richard Sandiford ; Prathamesh Kulkarni > ; gcc-patches@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it&

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Richard Sandiford
Jakub Jelinek writes: > On Tue, Jul 30, 2024 at 11:25:42AM +0200, Richard Biener wrote: >> Only "relevant" stuff should be streamed - the offload code and all >> trees refered to. > > Yeah. > >> > > I think all current issues are because of poly-* leaking in for cases >> > > where a non-poly would

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Jakub Jelinek
On Tue, Jul 30, 2024 at 11:25:42AM +0200, Richard Biener wrote: > Only "relevant" stuff should be streamed - the offload code and all > trees refered to. Yeah. > > > I think all current issues are because of poly-* leaking in for cases > > > where a non-poly would have worked fine, but I have not

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Richard Biener
gt;> >> > >> >> > -Original Message- > >> >> > From: Richard Sandiford > >> >> > Sent: Monday, July 29, 2024 9:43 PM > >> >> > To: Richard Biener > >> >> > Cc: Prathamesh Kul

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Richard Sandiford
> From: Richard Sandiford >> >> > Sent: Monday, July 29, 2024 9:43 PM >> >> > To: Richard Biener >> >> > Cc: Prathamesh Kulkarni ; gcc- >> >> > patc...@gcc.gnu.org >> >> > Subject: Re: Support streami

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Richard Biener
uly 29, 2024 9:43 PM > >> > To: Richard Biener > >> > Cc: Prathamesh Kulkarni ; gcc- > >> > patc...@gcc.gnu.org > >> > Subject: Re: Support streaming of poly_int for offloading when it's > >> > degree <= accel's NUM_POLY_INT

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Richard Sandiford
karni ; gcc- >> > patc...@gcc.gnu.org >> > Subject: Re: Support streaming of poly_int for offloading when it's >> > degree <= accel's NUM_POLY_INT_COEFFS >> > >> > External email: Use caution opening links or attachments >> > >&

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-30 Thread Richard Biener
On Tue, 30 Jul 2024, Prathamesh Kulkarni wrote: > > > > -Original Message- > > From: Richard Sandiford > > Sent: Monday, July 29, 2024 9:43 PM > > To: Richard Biener > > Cc: Prathamesh Kulkarni ; gcc- > > patc...@gcc.gnu.org > >

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-29 Thread Prathamesh Kulkarni
> -Original Message- > From: Richard Sandiford > Sent: Monday, July 29, 2024 9:43 PM > To: Richard Biener > Cc: Prathamesh Kulkarni ; gcc- > patc...@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it's > degree <= accel

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-29 Thread Richard Sandiford
Richard Biener writes: > On Mon, 29 Jul 2024, Prathamesh Kulkarni wrote: > >> Hi Richard, >> Thanks for your suggestions on RFC email, the attached patch adds support >> for streaming of poly_int when it's degree <= accel's NUM_POLY_INT_COEFFS. >> The patch changes streaming of poly_int as follow

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-07-29 Thread Richard Biener
On Mon, 29 Jul 2024, Prathamesh Kulkarni wrote: > Hi Richard, > Thanks for your suggestions on RFC email, the attached patch adds support for > streaming of poly_int when it's degree <= accel's NUM_POLY_INT_COEFFS. > The patch changes streaming of poly_int as follows: > > Streaming out poly_int: