Re: RFC (gimplify, openmp): PATCH to is_gimple_reg to check DECL_HAS_VALUE_EXPR_P

2016-06-13 Thread Jason Merrill
On Mon, Jun 13, 2016 at 5:03 AM, Richard Biener wrote: > On Sat, Jun 11, 2016 at 9:30 PM, Jakub Jelinek wrote: >> On Sat, Jun 11, 2016 at 08:43:06PM +0200, Richard Biener wrote: >>> On June 10, 2016 9:48:45 PM GMT+02:00, Jason Merrill

Re: RFC (gimplify, openmp): PATCH to is_gimple_reg to check DECL_HAS_VALUE_EXPR_P

2016-06-13 Thread Jakub Jelinek
On Mon, Jun 13, 2016 at 11:03:54AM +0200, Richard Biener wrote: > > I'm afraid that would break OpenMP badly. > > During gimplification, outside of OpenMP contexts we always replace decls > > for their DECL_VALUE_EXPR, but inside of OpenMP contexts we do it only for > > some decls. In particular,

Re: RFC (gimplify, openmp): PATCH to is_gimple_reg to check DECL_HAS_VALUE_EXPR_P

2016-06-13 Thread Richard Biener
On Sat, Jun 11, 2016 at 9:30 PM, Jakub Jelinek wrote: > On Sat, Jun 11, 2016 at 08:43:06PM +0200, Richard Biener wrote: >> On June 10, 2016 9:48:45 PM GMT+02:00, Jason Merrill >> wrote: >> >While working on another issue I noticed that is_gimple_reg was

Re: RFC (gimplify, openmp): PATCH to is_gimple_reg to check DECL_HAS_VALUE_EXPR_P

2016-06-11 Thread Jakub Jelinek
On Sat, Jun 11, 2016 at 08:43:06PM +0200, Richard Biener wrote: > On June 10, 2016 9:48:45 PM GMT+02:00, Jason Merrill wrote: > >While working on another issue I noticed that is_gimple_reg was happily > > > >accepting VAR_DECLs with DECL_VALUE_EXPR even when later gimplification

Re: RFC (gimplify, openmp): PATCH to is_gimple_reg to check DECL_HAS_VALUE_EXPR_P

2016-06-11 Thread Richard Biener
On June 10, 2016 9:48:45 PM GMT+02:00, Jason Merrill wrote: >While working on another issue I noticed that is_gimple_reg was happily > >accepting VAR_DECLs with DECL_VALUE_EXPR even when later gimplification > >would replace them with something that is_gimple_reg doesn't like,

RFC (gimplify, openmp): PATCH to is_gimple_reg to check DECL_HAS_VALUE_EXPR_P

2016-06-10 Thread Jason Merrill
While working on another issue I noticed that is_gimple_reg was happily accepting VAR_DECLs with DECL_VALUE_EXPR even when later gimplification would replace them with something that is_gimple_reg doesn't like, leading to trouble. So I've modified is_gimple_reg to check the VALUE_EXPR. But