Re: [RS6000] fix for RTL cprop vs. fixed hard regs

2015-02-01 Thread David Edelsohn
On Fri, Jan 30, 2015 at 1:57 AM, Alan Modra wrote: > On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123776.html >> shows gcc-5 miscompiling a powerpc64 linux kernel. The executive >> summary is that the rs6000 backend h

[RS6000] fix for RTL cprop vs. fixed hard regs

2015-01-29 Thread Alan Modra
On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: > https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123776.html > shows gcc-5 miscompiling a powerpc64 linux kernel. The executive > summary is that the rs6000 backend has a bug in its RTL description of > indirect calls. We

Re: RTL cprop vs. fixed hard regs

2015-01-29 Thread Segher Boessenkool
On Thu, Jan 29, 2015 at 01:27:24PM -0600, Segher Boessenkool wrote: > On Fri, Jan 30, 2015 at 01:05:54AM +1030, Alan Modra wrote: > > Segher, does this one look better to you? The previous patch turned > > off constant propagation for fixed registers as well as register copy > > propagation. The

Re: RTL cprop vs. fixed hard regs

2015-01-29 Thread Segher Boessenkool
On Fri, Jan 30, 2015 at 01:05:54AM +1030, Alan Modra wrote: > Segher, does this one look better to you? The previous patch turned > off constant propagation for fixed registers as well as register copy > propagation. The latter is all I really meant to do. I'm still not happy about not constant

Re: RTL cprop vs. fixed hard regs

2015-01-29 Thread Alan Modra
On Sat, Jan 17, 2015 at 01:12:49PM +0100, Richard Biener wrote: > On January 17, 2015 1:37:12 AM CET, Alan Modra wrote: > >On Fri, Jan 16, 2015 at 11:03:24AM -0600, Segher Boessenkool wrote: > >> On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: > >> > OK, so we need to fix this in the r

Re: RTL cprop vs. fixed hard regs

2015-01-17 Thread Richard Biener
On January 17, 2015 1:37:12 AM CET, Alan Modra wrote: >On Fri, Jan 16, 2015 at 11:03:24AM -0600, Segher Boessenkool wrote: >> On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: >> > OK, so we need to fix this in the rs6000 backend, but it occurs to >me >> > that cprop also has a bug here.

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Alan Modra
On Sat, Jan 17, 2015 at 11:16:57AM +1030, Alan Modra wrote: > On Fri, Jan 16, 2015 at 09:35:16AM -0700, Jeff Law wrote: > > On 01/16/15 02:42, Alan Modra wrote: > > > * cprop.c (do_local_cprop): Disallow replacement of fixed > > > hard registers. > > OK. Extra credit for a testcase, ppc specif

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Alan Modra
On Fri, Jan 16, 2015 at 08:09:51PM -0600, Segher Boessenkool wrote: > On Sat, Jan 17, 2015 at 11:07:12AM +1030, Alan Modra wrote: > > On Fri, Jan 16, 2015 at 11:03:24AM -0600, Segher Boessenkool wrote: > > > On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: > > > > OK, so we need to fix t

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Segher Boessenkool
On Sat, Jan 17, 2015 at 11:07:12AM +1030, Alan Modra wrote: > On Fri, Jan 16, 2015 at 11:03:24AM -0600, Segher Boessenkool wrote: > > On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: > > > OK, so we need to fix this in the rs6000 backend, but it occurs to me > > > that cprop also has a b

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Alan Modra
On Fri, Jan 16, 2015 at 09:35:16AM -0700, Jeff Law wrote: > On 01/16/15 02:42, Alan Modra wrote: > > * cprop.c (do_local_cprop): Disallow replacement of fixed > > hard registers. > OK. Extra credit for a testcase, ppc specific is obviously OK. Thanks. Committed revision 219786. I'll see

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Alan Modra
On Fri, Jan 16, 2015 at 11:03:24AM -0600, Segher Boessenkool wrote: > On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: > > OK, so we need to fix this in the rs6000 backend, but it occurs to me > > that cprop also has a bug here. It shouldn't be touching fixed hard > > registers. > > Wh

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Segher Boessenkool
On Fri, Jan 16, 2015 at 08:12:27PM +1030, Alan Modra wrote: > https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123776.html > shows gcc-5 miscompiling a powerpc64 linux kernel. The executive > summary is that the rs6000 backend has a bug in its RTL description of > indirect calls. We

Re: RTL cprop vs. fixed hard regs

2015-01-16 Thread Jeff Law
On 01/16/15 02:42, Alan Modra wrote: https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123776.html shows gcc-5 miscompiling a powerpc64 linux kernel. The executive summary is that the rs6000 backend has a bug in its RTL description of indirect calls. We specify a parallel containing

RTL cprop vs. fixed hard regs

2015-01-16 Thread Alan Modra
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123776.html shows gcc-5 miscompiling a powerpc64 linux kernel. The executive summary is that the rs6000 backend has a bug in its RTL description of indirect calls. We specify a parallel containing both the actual call and an action tha