Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-21 Thread Patrick O'Neill
On 9/21/23 09:14, Patrick O'Neill wrote: On 9/21/23 03:20, Palmer Dabbelt wrote: On Wed, 20 Sep 2023 10:47:23 PDT (-0700), Patrick O'Neill wrote: ... [1]: Executing on host: /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/build-gcc-linux-stage2/gcc/xgcc

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-21 Thread Patrick O'Neill
On 9/21/23 03:20, Palmer Dabbelt wrote: On Wed, 20 Sep 2023 10:47:23 PDT (-0700), Patrick O'Neill wrote: ... [1]: Executing on host: /github/ewlu-runner-2/_work/riscv-gnu-toolchain/riscv-gnu-toolchain/build/build-gcc-linux-stage2/gcc/xgcc

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-21 Thread Palmer Dabbelt
On Thu, 21 Sep 2023 04:24:48 PDT (-0700), kito.ch...@sifive.com wrote: GCC has built in function[1] for those math function stuff, e.g. __builtin_ceilf, so we don't really need math.h :) [1] https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html That's probably the right way to go for the

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-21 Thread Kito Cheng
GCC has built in function[1] for those math function stuff, e.g. __builtin_ceilf, so we don't really need math.h :) [1] https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html On Thu, Sep 21, 2023 at 11:20 AM Palmer Dabbelt wrote: > > On Wed, 20 Sep 2023 10:47:23 PDT (-0700), Patrick O'Neill

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-21 Thread Palmer Dabbelt
On Wed, 20 Sep 2023 10:47:23 PDT (-0700), Patrick O'Neill wrote: Juzhe, On a more general note, are we expecting #include to cause a testcase to fail? My motivation is to make the testsuite less noisy when checking for regressions. For example, a patch like this one:

Re: Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-20 Thread 钟居哲
rom: Patrick O'Neill Date: 2023-09-21 01:47 To: juzhe.zh...@rivai.ai CC: Robin Dapp; gcc-patches; Kito.cheng; jeffreyalaw; palmer; Edwin Lu; joern.rennecke; jeremy.bennett; gnu-toolchain; Kito Cheng Subject: Re: [Committed] RISC-V: Support VLS unary floating-point patterns Juzhe, On a more general

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-20 Thread Patrick O'Neill
Juzhe, On a more general note, are we expecting #include to cause a testcase to fail? My motivation is to make the testsuite less noisy when checking for regressions. For example, a patch like this one:

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-19 Thread Patrick O'Neill
mbecosm.com>; jeremy.bennett <mailto:jeremy.benn...@embecosm.com>; gnu-toolchain <mailto:gnu-toolch...@rivosinc.com> *Subject:* Re: [Committed] RISC-V: Support VLS unary floating-point patterns Hi,

Re: Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-19 Thread juzhe.zh...@rivai.ai
; jeremy.bennett; gnu-toolchain Subject: Re: Re: [Committed] RISC-V: Support VLS unary floating-point patterns It seems because math.h, similar issue as stdint.h, does math.h necessary for the test case? juzhe.zh...@rivai.ai 於 2023年9月20日 週三 08:44 寫道: I didn't see this issue. They should be the bogus FAILs

Re: Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-19 Thread Kito Cheng
> juzhe.zh...@rivai.ai > > > *From:* Patrick O'Neill > *Date:* 2023-09-20 08:34 > *To:* Juzhe-Zhong ; Robin Dapp ; > gcc-patches > *CC:* kito.cheng ; kito.cheng > ; jeffreyalaw ; Palmer > Dabbelt ; Edwin Lu ; > joern.rennecke ; jeremy.bennett > ; gnu-tool

Re: Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-19 Thread juzhe.zh...@rivai.ai
; jeremy.bennett; gnu-toolchain Subject: Re: [Committed] RISC-V: Support VLS unary floating-point patterns Hi, This patch highlights an issue Edwin and I have been having with the testsuite where rv64 testcases are run when testing rv32gcv. There's a large number of new failures in the rv32gcv

Re: [Committed] RISC-V: Support VLS unary floating-point patterns

2023-09-19 Thread Patrick O'Neill
Hi, This patch highlights an issue Edwin and I have been having with the testsuite where rv64 testcases are run when testing rv32gcv. There's a large number of new failures in the rv32gcv testsuite from this seemingly innocuous patch. https://github.com/ewlu/riscv-gnu-toolchain/issues/166 (The