Re: [OpenACC 4/11] C FE changes

2015-10-27 Thread Nathan Sidwell
On 10/26/15 15:27, Cesar Philippidis wrote: On 10/26/2015 01:59 AM, Jakub Jelinek wrote: Ok for trunk with those changes fixed. Here's the patch with those changes. Nathan will commit this patch the rest of the openacc execution model patches. This is the patch I've committed. nathan

Re: [OpenACC 4/11] C FE changes

2015-10-26 Thread Jakub Jelinek
On Mon, Oct 26, 2015 at 09:59:49AM +0100, Jakub Jelinek wrote: > Ok for trunk with those changes fixed. Oops, I've missed that there is no checking of the type (that the expressions have INTEGRAL_TYPE_P); in the C FE, this is sometimes done already during the parsing, sometimes during

Re: [OpenACC 4/11] C FE changes

2015-10-26 Thread Jakub Jelinek
On Sat, Oct 24, 2015 at 02:10:26PM -0700, Cesar Philippidis wrote: > +static tree > +c_parser_oacc_shape_clause (c_parser *parser, omp_clause_code kind, > + const char *str, tree list) > +{ > + const char *id = "num"; > + tree ops[2] = { NULL_TREE, NULL_TREE }, c; > +

Re: [OpenACC 4/11] C FE changes

2015-10-26 Thread Cesar Philippidis
On 10/26/2015 01:59 AM, Jakub Jelinek wrote: > Ok for trunk with those changes fixed. Here's the patch with those changes. Nathan will commit this patch the rest of the openacc execution model patches. Thanks, Cesar 2015-10-26 Cesar Philippidis Thomas Schwinge

Re: [OpenACC 4/11] C FE changes

2015-10-25 Thread Nathan Sidwell
On 10/23/15 17:25, Nathan Sidwell wrote: On 10/23/15 16:17, Cesar Philippidis wrote: Nathan, can you try out this patch with your updated patch set? I saw some test cases getting stuck when expanding expand_GOACC_DIM_SIZE in on the host compiler, which is wrong. I don't see that happening in

Re: [OpenACC 4/11] C FE changes

2015-10-24 Thread Cesar Philippidis
On 10/24/2015 01:03 AM, Jakub Jelinek wrote: > On Fri, Oct 23, 2015 at 07:31:51PM -0700, Cesar Philippidis wrote: > >> +static tree >> +c_parser_oacc_shape_clause (c_parser *parser, omp_clause_code kind, >> +const char *str, tree list) >> +{ >> + const char *id = "num";

Re: [OpenACC 4/11] C FE changes

2015-10-24 Thread Jakub Jelinek
On Fri, Oct 23, 2015 at 07:31:51PM -0700, Cesar Philippidis wrote: > +static tree > +c_parser_oacc_shape_clause (c_parser *parser, omp_clause_code kind, > + const char *str, tree list) > +{ > + const char *id = "num"; > + tree op0 = NULL_TREE, op1 = NULL_TREE, c; > +

Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Cesar Philippidis
On 10/23/2015 02:31 PM, Cesar Philippidis wrote: > On 10/23/2015 01:31 PM, Jakub Jelinek wrote: >> On Fri, Oct 23, 2015 at 01:17:07PM -0700, Cesar Philippidis wrote: >>> Good idea, thanks. This patch also corrects the problems parsing weird >>> combinations of num, static and length arguments that

Re: Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Cesar Philippidis
On 10/22/2015 01:22 AM, Jakub Jelinek wrote: > On Wed, Oct 21, 2015 at 03:16:20PM -0400, Nathan Sidwell wrote: >> 2015-10-20 Cesar Philippidis >> Thomas Schwinge >> James Norris >> Joseph

Re: Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Jakub Jelinek
On Fri, Oct 23, 2015 at 01:17:07PM -0700, Cesar Philippidis wrote: > Good idea, thanks. This patch also corrects the problems parsing weird > combinations of num, static and length arguments that you mentioned > elsewhere. > > Is this OK for trunk? I'd strongly prefer to see always patches

Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Cesar Philippidis
On 10/23/2015 01:31 PM, Jakub Jelinek wrote: > On Fri, Oct 23, 2015 at 01:17:07PM -0700, Cesar Philippidis wrote: >> Good idea, thanks. This patch also corrects the problems parsing weird >> combinations of num, static and length arguments that you mentioned >> elsewhere. >> >> Is this OK for

Re: Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Jakub Jelinek
On Fri, Oct 23, 2015 at 10:31:55PM +0200, Jakub Jelinek wrote: > Doesn't this mean that you happily parse > gang (static: * abc) > or > gang (static:*num:1) > etc.? I'd say the comma should be non-optional (i.e. either accept > CPP_COMMA, or CPP_CLOSE_PARENT, but nothing else) in that case (at

Re: [OpenACC 4/11] C FE changes

2015-10-23 Thread Nathan Sidwell
On 10/23/15 16:17, Cesar Philippidis wrote: Nathan, can you try out this patch with your updated patch set? I saw some test cases getting stuck when expanding expand_GOACC_DIM_SIZE in on the host compiler, which is wrong. I don't see that happening in gomp-4_0-branch with this patch. Also, can

Re: [OpenACC 4/11] C FE changes

2015-10-22 Thread Jakub Jelinek
On Wed, Oct 21, 2015 at 03:16:20PM -0400, Nathan Sidwell wrote: > 2015-10-20 Cesar Philippidis > Thomas Schwinge > James Norris > Joseph Myers >

Re: [OpenACC 4/11] C FE changes

2015-10-21 Thread Nathan Sidwell
This patch implements changes to the C parser to deal with the 'gang', 'worker', 'vector', 'seq' and 'auto' clauses on an OpenACC loop directive. The first 3 can take a numeric argument, which is used within a kernels offload region and the gang clause can take an additional 'static'