Re: [PATCH][RFC] Canonize names of attributes.

2017-06-28 Thread Jason Merrill
On Wed, Jun 28, 2017 at 12:05 PM, Joseph Myers wrote: > On Wed, 28 Jun 2017, Martin Liška wrote: > >> On 06/14/2017 07:24 PM, Jason Merrill wrote: >> > On Tue, Jun 13, 2017 at 8:32 AM, Martin Liška wrote: >> >> (canonize_attr_name): New function. >> > >> > I think this should be "canonica

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-28 Thread Joseph Myers
On Wed, 28 Jun 2017, Martin Liška wrote: > On 06/14/2017 07:24 PM, Jason Merrill wrote: > > On Tue, Jun 13, 2017 at 8:32 AM, Martin Liška wrote: > >> (canonize_attr_name): New function. > > > > I think this should be "canonicalize"; "canonize" means something else. > > > > Jason > > >

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-28 Thread Martin Liška
On 06/14/2017 07:24 PM, Jason Merrill wrote: > On Tue, Jun 13, 2017 at 8:32 AM, Martin Liška wrote: >> (canonize_attr_name): New function. > > I think this should be "canonicalize"; "canonize" means something else. > > Jason > Yes, I hope it's a cosmetic problem. In general, do you wel

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-28 Thread Martin Liška
On 06/14/2017 06:40 PM, Joseph Myers wrote: > On Wed, 14 Jun 2017, Richard Biener wrote: > are you sure this is needed? This seems to be solely arguments to attributes. >>> >>> It's need for cases like: >>> __intN_t (8, __QI__); >> >> But __QI__ is not processed in lookup_attribute, is

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-15 Thread Martin Sebor
On 06/14/2017 11:24 AM, Jason Merrill wrote: On Tue, Jun 13, 2017 at 8:32 AM, Martin Liška wrote: (canonize_attr_name): New function. I think this should be "canonicalize"; "canonize" means something else. Right. I was about to make the same observation but then grepped GCC sources

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-14 Thread Jason Merrill
On Tue, Jun 13, 2017 at 8:32 AM, Martin Liška wrote: > (canonize_attr_name): New function. I think this should be "canonicalize"; "canonize" means something else. Jason

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-14 Thread Joseph Myers
On Wed, 14 Jun 2017, Richard Biener wrote: > >> are you sure this is needed? This seems to be solely arguments to > >> attributes. > > > > It's need for cases like: > > __intN_t (8, __QI__); > > But __QI__ is not processed in lookup_attribute, is it? So canonizing that > looks unrelated? I di

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-14 Thread Richard Biener
On Wed, Jun 14, 2017 at 1:03 PM, Martin Liška wrote: > On 06/14/2017 11:07 AM, Richard Biener wrote: >> On Wed, Jun 14, 2017 at 9:48 AM, Martin Liška wrote: >>> On 06/13/2017 03:20 PM, Richard Biener wrote: On Tue, Jun 13, 2017 at 2:32 PM, Martin Liška wrote: > Hello. > > After

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-14 Thread Martin Liška
On 06/14/2017 11:07 AM, Richard Biener wrote: > On Wed, Jun 14, 2017 at 9:48 AM, Martin Liška wrote: >> On 06/13/2017 03:20 PM, Richard Biener wrote: >>> On Tue, Jun 13, 2017 at 2:32 PM, Martin Liška wrote: Hello. After some discussions with Richi, I would like to propose patch tha

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-14 Thread Richard Biener
On Wed, Jun 14, 2017 at 9:48 AM, Martin Liška wrote: > On 06/13/2017 03:20 PM, Richard Biener wrote: >> On Tue, Jun 13, 2017 at 2:32 PM, Martin Liška wrote: >>> Hello. >>> >>> After some discussions with Richi, I would like to propose patch that will >>> come up with a canonical name of attribute

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-14 Thread Martin Liška
On 06/13/2017 03:20 PM, Richard Biener wrote: > On Tue, Jun 13, 2017 at 2:32 PM, Martin Liška wrote: >> Hello. >> >> After some discussions with Richi, I would like to propose patch that will >> come up with a canonical name of attribute names. That means >> __attribute__((__abi_tag__)) >> will b

Re: [PATCH][RFC] Canonize names of attributes.

2017-06-13 Thread Richard Biener
On Tue, Jun 13, 2017 at 2:32 PM, Martin Liška wrote: > Hello. > > After some discussions with Richi, I would like to propose patch that will > come up with a canonical name of attribute names. That means > __attribute__((__abi_tag__)) > will be given 'abi_tag' as IDENTIFIER_NAME of the attribute.