Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Thu, Nov 5, 2020 at 3:37 AM Jozef Lawrynowicz wrote: > > On Thu, Nov 05, 2020 at 06:21:21AM -0500, Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > .retain is ill-defined. For example, > > > > > > [hjl@gnu-cfl-2 gcc]$ cat /tmp/x.c > > > static int xyzzy __attribute__((__

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On 11/5/20 4:00 AM, Jozef Lawrynowicz wrote: > On Wed, Nov 04, 2020 at 03:58:56PM -0800, H.J. Lu wrote: >> On Wed, Nov 4, 2020 at 3:00 PM Hans-Peter Nilsson wrote: >>> On Wed, 4 Nov 2020, H.J. Lu wrote: On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson wrote: > On Wed, 4 Nov 2020

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On 11/5/20 7:34 AM, H.J. Lu via Gcc-patches wrote: > On Thu, Nov 5, 2020 at 3:37 AM Jozef Lawrynowicz > wrote: >> On Thu, Nov 05, 2020 at 06:21:21AM -0500, Hans-Peter Nilsson wrote: >>> On Wed, 4 Nov 2020, H.J. Lu wrote: .retain is ill-defined. For example, [hjl@gnu-cfl-2 gcc]$

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Fri, Nov 6, 2020 at 3:22 PM Jeff Law wrote: > > > On 11/5/20 7:34 AM, H.J. Lu via Gcc-patches wrote: > > On Thu, Nov 5, 2020 at 3:37 AM Jozef Lawrynowicz > > wrote: > >> On Thu, Nov 05, 2020 at 06:21:21AM -0500, Hans-Peter Nilsson wrote: > >>> On Wed, 4 Nov 2020, H.J. Lu wrote: > .retain

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On 11/6/20 4:29 PM, H.J. Lu wrote: > On Fri, Nov 6, 2020 at 3:22 PM Jeff Law wrote: >> >> On 11/5/20 7:34 AM, H.J. Lu via Gcc-patches wrote: >>> On Thu, Nov 5, 2020 at 3:37 AM Jozef Lawrynowicz >>> wrote: On Thu, Nov 05, 2020 at 06:21:21AM -0500, Hans-Peter Nilsson wrote: > On Wed, 4 N

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Fri, Nov 6, 2020 at 3:37 PM Jeff Law wrote: > > > On 11/6/20 4:29 PM, H.J. Lu wrote: > > On Fri, Nov 6, 2020 at 3:22 PM Jeff Law wrote: > >> > >> On 11/5/20 7:34 AM, H.J. Lu via Gcc-patches wrote: > >>> On Thu, Nov 5, 2020 at 3:37 AM Jozef Lawrynowicz > >>> wrote: > On Thu, Nov 05, 2020

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On 11/6/20 4:45 PM, H.J. Lu wrote: > On Fri, Nov 6, 2020 at 3:37 PM Jeff Law wrote: >> >> On 11/6/20 4:29 PM, H.J. Lu wrote: >>> On Fri, Nov 6, 2020 at 3:22 PM Jeff Law wrote: On 11/5/20 7:34 AM, H.J. Lu via Gcc-patches wrote: > On Thu, Nov 5, 2020 at 3:37 AM Jozef Lawrynowicz > w

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: > > > On 11/6/20 4:45 PM, H.J. Lu wrote: > > On Fri, Nov 6, 2020 at 3:37 PM Jeff Law wrote: > >> > >> On 11/6/20 4:29 PM, H.J. Lu wrote: > >>> On Fri, Nov 6, 2020 at 3:22 PM Jeff Law wrote: > On 11/5/20 7:34 AM, H.J. Lu via Gcc-patches wrote: >

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On 11/6/20 5:13 PM, H.J. Lu wrote: > On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: >> >> On 11/6/20 4:45 PM, H.J. Lu wrote: >>> On Fri, Nov 6, 2020 at 3:37 PM Jeff Law wrote: On 11/6/20 4:29 PM, H.J. Lu wrote: > On Fri, Nov 6, 2020 at 3:22 PM Jeff Law wrote: >> On 11/5/20 7:34 AM

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > On 11/6/20 5:13 PM, H.J. Lu wrote: > > On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: > >> > >> On 11/6/20 4:45 PM, H.J. Lu wrote: > >>> On Fri, Nov 6, 2020 at 3:37 PM Jeff Law wrote: > On 11/6/20 4:29 PM, H.J. Lu wrote: > > On Fri, N

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > > > > On 11/6/20 5:13 PM, H.J. Lu wrote: > > > On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: > > >> > > >> On 11/6/20 4:45 PM, H.J. Lu wrote: > > >>> On Fri, Nov 6, 202

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz wrote: > > On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > > On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > > > > > > > On 11/6/20 5:13 PM, H.J. Lu wrote: > > > > On Fri, Nov 6, 2020 at 4:01 PM Jeff Law wrote: > >

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Mon, Nov 09, 2020 at 10:36:07AM -0800, H.J. Lu via Gcc-patches wrote: > On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz > wrote: > > > > On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > > > On Fri, Nov 6, 2020 at 4:17 PM Jeff Law wrote: > > > > > > > > > > > > On 11/

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Mon, Nov 9, 2020 at 11:56 AM Jozef Lawrynowicz wrote: > > On Mon, Nov 09, 2020 at 10:36:07AM -0800, H.J. Lu via Gcc-patches wrote: > > On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz > > wrote: > > > > > > On Fri, Nov 06, 2020 at 04:39:33PM -0800, H.J. Lu via Gcc-patches wrote: > > > > On Fri

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Mon, Nov 09, 2020 at 12:31:09PM -0800, H.J. Lu via Gcc-patches wrote: > On Mon, Nov 9, 2020 at 11:56 AM Jozef Lawrynowicz > wrote: > > > > On Mon, Nov 09, 2020 at 10:36:07AM -0800, H.J. Lu via Gcc-patches wrote: > > > On Mon, Nov 9, 2020 at 9:41 AM Jozef Lawrynowicz > > > wrote: > > > > > > >

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 3, 2020 at 9:41 AM Jozef Lawrynowicz wrote: > > The attached patch implements TARGET_ASM_MARK_DECL_PRESERVED for ELF GNU > OSABI targets, so that declarations that have the "used" attribute > applied will be saved from linker garbage collection. > > TARGET_ASM_MARK_DECL_PRESERVED will

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 03, 2020 at 09:57:58AM -0800, H.J. Lu via Gcc-patches wrote: > On Tue, Nov 3, 2020 at 9:41 AM Jozef Lawrynowicz > wrote: > > > > The attached patch implements TARGET_ASM_MARK_DECL_PRESERVED for ELF GNU > > OSABI targets, so that declarations that have the "used" attribute > > applied w

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 3, 2020 at 10:22 AM Jozef Lawrynowicz wrote: > > On Tue, Nov 03, 2020 at 09:57:58AM -0800, H.J. Lu via Gcc-patches wrote: > > On Tue, Nov 3, 2020 at 9:41 AM Jozef Lawrynowicz > > wrote: > > > > > > The attached patch implements TARGET_ASM_MARK_DECL_PRESERVED for ELF GNU > > > OSABI ta

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 03, 2020 at 11:58:04AM -0800, H.J. Lu via Gcc-patches wrote: > On Tue, Nov 3, 2020 at 10:22 AM Jozef Lawrynowicz > wrote: > > > > On Tue, Nov 03, 2020 at 09:57:58AM -0800, H.J. Lu via Gcc-patches wrote: > > > On Tue, Nov 3, 2020 at 9:41 AM Jozef Lawrynowicz > > > wrote: > > > > > > >

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 3, 2020 at 12:46 PM Jozef Lawrynowicz wrote: > > On Tue, Nov 03, 2020 at 11:58:04AM -0800, H.J. Lu via Gcc-patches wrote: > > On Tue, Nov 3, 2020 at 10:22 AM Jozef Lawrynowicz > > wrote: > > > > > > On Tue, Nov 03, 2020 at 09:57:58AM -0800, H.J. Lu via Gcc-patches wrote: > > > > On Tu

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 3, 2020 at 1:00 PM H.J. Lu wrote: > > On Tue, Nov 3, 2020 at 12:46 PM Jozef Lawrynowicz > wrote: > > > > On Tue, Nov 03, 2020 at 11:58:04AM -0800, H.J. Lu via Gcc-patches wrote: > > > On Tue, Nov 3, 2020 at 10:22 AM Jozef Lawrynowicz > > > wrote: > > > > > > > > On Tue, Nov 03, 2020

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 03, 2020 at 01:09:43PM -0800, H.J. Lu via Gcc-patches wrote: > On Tue, Nov 3, 2020 at 1:00 PM H.J. Lu wrote: > > > > On Tue, Nov 3, 2020 at 12:46 PM Jozef Lawrynowicz > > wrote: > > > > > > On Tue, Nov 03, 2020 at 11:58:04AM -0800, H.J. Lu via Gcc-patches wrote: > > > > On Tue, Nov 3,

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 3, 2020 at 1:57 PM Jozef Lawrynowicz wrote: > > On Tue, Nov 03, 2020 at 01:09:43PM -0800, H.J. Lu via Gcc-patches wrote: > > On Tue, Nov 3, 2020 at 1:00 PM H.J. Lu wrote: > > > > > > On Tue, Nov 3, 2020 at 12:46 PM Jozef Lawrynowicz > > > wrote: > > > > > > > > On Tue, Nov 03, 2020 a

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Tue, Nov 3, 2020 at 2:11 PM H.J. Lu wrote: > > On Tue, Nov 3, 2020 at 1:57 PM Jozef Lawrynowicz > wrote: > > > > On Tue, Nov 03, 2020 at 01:09:43PM -0800, H.J. Lu via Gcc-patches wrote: > > > On Tue, Nov 3, 2020 at 1:00 PM H.J. Lu wrote: > > > > > > > > On Tue, Nov 3, 2020 at 12:46 PM Jozef L

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 04, 2020 at 05:47:28AM -0800, H.J. Lu wrote: > On Tue, Nov 3, 2020 at 2:11 PM H.J. Lu wrote: > > > > On Tue, Nov 3, 2020 at 1:57 PM Jozef Lawrynowicz > > wrote: > > > > > > On Tue, Nov 03, 2020 at 01:09:43PM -0800, H.J. Lu via Gcc-patches wrote: > > > > On Tue, Nov 3, 2020 at 1:00 PM

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 4, 2020 at 6:41 AM Jozef Lawrynowicz wrote: > > On Wed, Nov 04, 2020 at 05:47:28AM -0800, H.J. Lu wrote: > > On Tue, Nov 3, 2020 at 2:11 PM H.J. Lu wrote: > > > > > > On Tue, Nov 3, 2020 at 1:57 PM Jozef Lawrynowicz > > > wrote: > > > > > > > > On Tue, Nov 03, 2020 at 01:09:43PM -080

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > I personally do not see the problem with the .retain attribute, however > if it is going to be a barrier to getting the functionality committed, I > am happy to change it, since I really just want the functionality in > upstream sources. > > If a globa

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > I personally do not see the problem with the .retain attribute, however > > if it is going to be a barrier to getting the functionality committed, I > > am happy to change it, since I rea

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, 4 Nov 2020, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > > I personally do not see the problem with the .retain attribute, however > > > if it is going to be a barrier to getting the functionality commit

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson > > wrote: > > > > > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > > > I personally do not see the problem with the .retain attribute, howev

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, 4 Nov 2020, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson > > > wrote: > > > > > > > > On Wed, 4 Nov 2020, Jozef Lawrynowicz wrote: > > > > > I personally d

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson wrote: > > > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > On Wed, Nov 4, 2020 at 10:09 AM Hans-Peter Nilsson > > > > wrote: > > > > > >

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, 4 Nov 2020, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson > > > wrote: > > > > > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > > On Wed, Nov 4, 2020 at 10:09

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 4, 2020 at 3:00 PM Hans-Peter Nilsson wrote: > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson wrote: > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > > > > On Wed, Nov 4, 2020 at 1:03 PM Hans-Peter Nilsson > > > > wrote: > > > > > > > > >

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, Nov 04, 2020 at 03:58:56PM -0800, H.J. Lu wrote: > On Wed, Nov 4, 2020 at 3:00 PM Hans-Peter Nilsson wrote: > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > On Wed, Nov 4, 2020 at 1:56 PM Hans-Peter Nilsson > > > wrote: > > > > On Wed, 4 Nov 2020, H.J. Lu wrote: > > > > > > > > > On Wed,

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Wed, 4 Nov 2020, H.J. Lu wrote: > .retain is ill-defined. For example, > > [hjl@gnu-cfl-2 gcc]$ cat /tmp/x.c > static int xyzzy __attribute__((__used__)); > [hjl@gnu-cfl-2 gcc]$ ./xgcc -B./ -S /tmp/x.c -fcommon > [hjl@gnu-cfl-2 gcc]$ cat x.s > .file "x.c" > .text > .retain xyzzy < Wha

Re: [PATCH] "used" attribute saves decl from linker garbage collection

On Thu, Nov 05, 2020 at 06:21:21AM -0500, Hans-Peter Nilsson wrote: > On Wed, 4 Nov 2020, H.J. Lu wrote: > > .retain is ill-defined. For example, > > > > [hjl@gnu-cfl-2 gcc]$ cat /tmp/x.c > > static int xyzzy __attribute__((__used__)); > > [hjl@gnu-cfl-2 gcc]$ ./xgcc -B./ -S /tmp/x.c -fcommon > >