Re: [PATCH] [RISC-V] fix zcmp popretz [PR113715]

2024-07-09 Thread Jeff Law
On 7/8/24 11:30 PM, Fei Gao wrote: On 2024-07-09 01:49  Jeff Law wrote: On 7/8/24 2:39 AM, Fei Gao wrote: Root cause: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b27d323a368033f0b37e93c57a57a35fd9997864 Commit above tries in targetm.gen_epilogue () to detect if there's li a0,0 insn at

Re: Re: [PATCH] [RISC-V] fix zcmp popretz [PR113715]

2024-07-08 Thread Fei Gao
On 2024-07-09 01:49  Jeff Law wrote: > > > >On 7/8/24 2:39 AM, Fei Gao wrote: >> Root cause: >> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b27d323a368033f0b37e93c57a57a35fd9997864 >> Commit above tries in targetm.gen_epilogue () to detect if >> there's li a0,0 insn at the end of insn chain, if

Re: [PATCH] [RISC-V] fix zcmp popretz [PR113715]

2024-07-08 Thread Jeff Law
On 7/8/24 7:33 PM, Fei Gao wrote: On 2024-07-09 01:49  Jeff Law wrote: Has the ESWIN team ever considered doing a bootstrap test of the zcmp* extensions?  ie, turn them all on by default, then build GCC natively on an rv32 system (or qemu emulated rv32 system)? I've found that kind of

Re: Re: [PATCH] [RISC-V] fix zcmp popretz [PR113715]

2024-07-08 Thread Fei Gao
On 2024-07-09 01:49  Jeff Law wrote: >Has the ESWIN team ever considered doing a bootstrap test of the zcmp* >extensions?  ie, turn them all on by default, then build GCC natively on >an rv32 system (or qemu emulated rv32 system)? > >I've found that kind of test amazingly helpful through the

Re: [PATCH] [RISC-V] fix zcmp popretz [PR113715]

2024-07-08 Thread Jeff Law
On 7/8/24 2:39 AM, Fei Gao wrote: Root cause: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b27d323a368033f0b37e93c57a57a35fd9997864 Commit above tries in targetm.gen_epilogue () to detect if there's li a0,0 insn at the end of insn chain, if so, cm.popret is replaced by cm.popretz and li a0,0