Re: [PATCH] Avoid extending lifetime of likely spilled hard regs in ifcvt before reload (PR rtl-optimization/56484)

2013-03-05 Thread Jeff Law
On 03/05/2013 09:26 AM, Jakub Jelinek wrote: Hi! Without this patch, ifcvt extends lifetime of %eax hard register, which causes reload/LRA ICE later on. Combiner and other passes try hard not to do that, even ifcvt has code for it if x is a hard register a few lines below it, but in this case

Re: [PATCH] Avoid extending lifetime of likely spilled hard regs in ifcvt before reload (PR rtl-optimization/56484)

2013-03-05 Thread Eric Botcazou
Without this patch, ifcvt extends lifetime of %eax hard register, which causes reload/LRA ICE later on. Combiner and other passes try hard not to do that, even ifcvt has code for it if x is a hard register a few lines below it, but in this case the hard register is SET_SRC (set_b). With

Re: [PATCH] Avoid extending lifetime of likely spilled hard regs in ifcvt before reload (PR rtl-optimization/56484)

2013-03-05 Thread Jakub Jelinek
On Tue, Mar 05, 2013 at 06:28:13PM +0100, Eric Botcazou wrote: Without this patch, ifcvt extends lifetime of %eax hard register, which causes reload/LRA ICE later on. Combiner and other passes try hard not to do that, even ifcvt has code for it if x is a hard register a few lines below

Re: [PATCH] Avoid extending lifetime of likely spilled hard regs in ifcvt before reload (PR rtl-optimization/56484)

2013-03-05 Thread Jakub Jelinek
On Tue, Mar 05, 2013 at 11:03:13PM +0100, Jakub Jelinek wrote: ifcvt.c tests only small_register_classes_for_mode_p in the other places, so do you really need class_likely_spilled_p here? I guess I don't. I've grepped for small_register_classes_for_mode_p and didn't see anything in