Re: [PATCH] gcov: Fix -fprofile-update=atomic

2022-12-16 Thread Sebastian Huber
On 16.12.22 13:09, Richard Biener wrote: On Fri, Dec 16, 2022 at 11:39 AM Sebastian Huber wrote: On 16.12.22 10:47, Richard Biener wrote: No, if you select -fprofile-update=atomic, then the updates shall be atomic from my point of view. If a fallback is acceptable, then you can use

Re: [PATCH] gcov: Fix -fprofile-update=atomic

2022-12-16 Thread Richard Biener via Gcc-patches
On Fri, Dec 16, 2022 at 11:39 AM Sebastian Huber wrote: > > On 16.12.22 10:47, Richard Biener wrote: > >> No, if you select -fprofile-update=atomic, then the updates shall be > >> atomic from my point of view. If a fallback is acceptable, then you can > >> use -fprofile-update=prefer-atomic.

Re: [PATCH] gcov: Fix -fprofile-update=atomic

2022-12-16 Thread Sebastian Huber
On 16.12.22 10:47, Richard Biener wrote: No, if you select -fprofile-update=atomic, then the updates shall be atomic from my point of view. If a fallback is acceptable, then you can use -fprofile-update=prefer-atomic. Using the fallback in -fprofile-update=atomic is a bug which prevents the use

Re: [PATCH] gcov: Fix -fprofile-update=atomic

2022-12-16 Thread Richard Biener via Gcc-patches
On Thu, Dec 15, 2022 at 9:34 AM Sebastian Huber wrote: > > On 13/12/2022 15:30, Richard Biener wrote: > > On Fri, Dec 9, 2022 at 2:56 PM Sebastian Huber > > wrote: > >> The code coverage support uses counters to determine which edges in the > >> control > >> flow graph were executed. If a

Re: [PATCH] gcov: Fix -fprofile-update=atomic

2022-12-15 Thread Sebastian Huber
On 13/12/2022 15:30, Richard Biener wrote: On Fri, Dec 9, 2022 at 2:56 PM Sebastian Huber wrote: The code coverage support uses counters to determine which edges in the control flow graph were executed. If a counter overflows, then the code coverage information is invalid. Therefore the

Re: [PATCH] gcov: Fix -fprofile-update=atomic

2022-12-13 Thread Richard Biener via Gcc-patches
On Fri, Dec 9, 2022 at 2:56 PM Sebastian Huber wrote: > > The code coverage support uses counters to determine which edges in the > control > flow graph were executed. If a counter overflows, then the code coverage > information is invalid. Therefore the counter type should be a 64-bit >