Re: [PATCH] sccvn: Punt on overflows during vn_reference_lookup_3

2020-02-27 Thread Richard Biener
On Thu, 27 Feb 2020, Jakub Jelinek wrote: > On Thu, Feb 27, 2020 at 10:30:21AM +0100, Richard Biener wrote: > > Obviously I don't like the repetitive boiler-plate after > > the ranges_known_overlap_p checks so I wonder if we can at least > > factor those into a VN-local

Re: [PATCH] sccvn: Punt on overflows during vn_reference_lookup_3

2020-02-27 Thread Jakub Jelinek
On Thu, Feb 27, 2020 at 10:30:21AM +0100, Richard Biener wrote: > Obviously I don't like the repetitive boiler-plate after > the ranges_known_overlap_p checks so I wonder if we can at least > factor those into a VN-local ranges_known_overlap_for_pd_p predicate. I can do that. > Wouldn't it be

Re: [PATCH] sccvn: Punt on overflows during vn_reference_lookup_3

2020-02-27 Thread Richard Biener
On Thu, 27 Feb 2020, Jakub Jelinek wrote: > Hi! > > I admit I don't have testcases, but I'm afraid very bad things will happen > if either the offset2i - offseti or pd.offset + pd.size computations > overflow. All are computed in (signed) HOST_WIDE_INT, and at least for the > memset or