Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-31 Thread Ian Taylor
On Fri, Oct 31, 2014 at 2:11 AM, Dominik Vogt wrote: > On Thu, Oct 30, 2014 at 07:51:45AM -0700, Ian Taylor wrote: >> On Thu, Oct 30, 2014 at 12:25 AM, Dominik Vogt >> wrote: >> > See attached patch. >> >> I don't mind skipping the test on other platforms, but xfail is not >> correct. When an x

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-31 Thread Dominik Vogt
On Thu, Oct 30, 2014 at 07:51:45AM -0700, Ian Taylor wrote: > On Thu, Oct 30, 2014 at 12:25 AM, Dominik Vogt > wrote: > > See attached patch. > > I don't mind skipping the test on other platforms, but xfail is not > correct. When an xfail test passes, we get an XPASS error from the > testsuite.

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-31 Thread Dominik Vogt
On Thu, Oct 30, 2014 at 08:20:20AM -0700, Ian Taylor wrote: > /* { dg-skip-if "not supported for target" { ! "s390*-*-* x86_64-*-*" } } */ > +/* { dg-skip-if "not supported for target" { ! lp64 } } */ Hm, but then the test will be skipped on s390 (31 bit) too where it should work. The current so

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-30 Thread Joseph S. Myers
On Thu, 30 Oct 2014, Dominik Vogt wrote: > platforms need to be added. Personally I cannot provide fixed > tests for all the Abis either, so my suggestion is to "xfail" the > test on all targets except s390[x] and x86_64 and leave it to the You should never do something in a test for x86_64 and

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-30 Thread Ian Taylor
On Thu, Oct 30, 2014 at 8:05 AM, Uros Bizjak wrote: > > /* { dg-options "-c -fdump-go-spec=godump-1.out" } */ > /* { dg-do compile } */ > +/* { dg-skip-if "not supported for target" { ! "s390*-*-* x86_64-*-*" } } */ > > x86_64 also needs && lp64, otherwise -m32 will defeat this condition. Thank

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-30 Thread Uros Bizjak
Hello! > I don't mind skipping the test on other platforms, but xfail is not > correct. When an xfail test passes, we get an XPASS error from the > testsuite. We need dg-skip-if. I committed this patch. > > > 2014-10-30 Dominik Vogt > > * gcc.misc-tests/godump-1.c: Skip -fdump-go-spec tests

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-30 Thread Ian Taylor
On Thu, Oct 30, 2014 at 12:25 AM, Dominik Vogt wrote: > On Wed, Oct 29, 2014 at 10:16:40AM -0700, Ian Taylor wrote: >> Thanks. Part of the problem is that the m68k max alignment is 16 >> bits, but the godump test expects it to be at least 64 bits. This is >> BIGGEST_ALIGNMENT in config/m68k/m68k

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-30 Thread Dominik Vogt
On Wed, Oct 29, 2014 at 10:16:40AM -0700, Ian Taylor wrote: > Thanks. Part of the problem is that the m68k max alignment is 16 > bits, but the godump test expects it to be at least 64 bits. This is > BIGGEST_ALIGNMENT in config/m68k/m68k.h. Another part of the problem > seems to be that structs

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-29 Thread Ian Taylor
Thanks. Part of the problem is that the m68k max alignment is 16 bits, but the godump test expects it to be at least 64 bits. This is BIGGEST_ALIGNMENT in config/m68k/m68k.h. Another part of the problem seems to be that structs are sometimes aligned to 16 bits although there is no obvious reason

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-29 Thread Andreas Schwab
// unknowndefine __SIZE_TYPE__ unsigned int // unknowndefine __PTRDIFF_TYPE__ int // unknowndefine __WCHAR_TYPE__ long int // unknowndefine __WINT_TYPE__ unsigned int // unknowndefine __INTMAX_TYPE__ long long int // unknowndefine __UINTMAX_TYPE__ long long unsigned int // unknowndefine __CHAR16_TY

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-29 Thread Ian Taylor
On Wed, Oct 29, 2014 at 9:38 AM, Andreas Schwab wrote: > I'm getting these test failures on m68k-linux: Can you send the file BUILDDIR/gcc/testsuite/gcc/godump-1.out? Ian

Re: [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-29 Thread Andreas Schwab
I'm getting these test failures on m68k-linux: FAIL: gcc.misc-tests/godump-1.c scan-file (?n)^type _tsbf_anon_pad1 struct { c uint[0-9]*; }$ FAIL: gcc.misc-tests/godump-1.c scan-file (?n)^type _tsbf_anon_pad5 struct { c uint[0-9]*; }$ FAIL: gcc.misc-tests/godump-1.c scan-file (?n)^type _tsbf_pad