On Thu, 10 Aug 2023, Robin Dapp wrote:
> > Hmm, I think VEC_EXTRACT and VEC_SET should be ECF_CONST. Maybe the
> > GIMPLE ISEL
> > comments do not match the implementation, but then that should be fixed?
> >
> > /* Expand all ARRAY_REF(VIEW_CONVERT_EXPR) gimple assignments into calls
> > to
>
> Hmm, I think VEC_EXTRACT and VEC_SET should be ECF_CONST. Maybe the
> GIMPLE ISEL
> comments do not match the implementation, but then that should be fixed?
>
> /* Expand all ARRAY_REF(VIEW_CONVERT_EXPR) gimple assignments into calls
> to
>internal function based on vector type of
gcc-patches; richard.sandiford
Subject: Re: Re: [PATCH V2] VECT: Support loop len control on EXTRACT_LAST
vectorization
On Thu, 10 Aug 2023, juzhe.zh...@rivai.ai wrote:
> Hi, Richi.
>
> >> What inserts the required LC SSA PHI in that case?
>
> Here is the flow how GCC insert LC SSA PH
Maybe the
GIMPLE ISEL
comments do not match the implementation, but then that should be fixed?
/* Expand all ARRAY_REF(VIEW_CONVERT_EXPR) gimple assignments into calls
to
internal function based on vector type of selected expansion.
For vec_set:
VIEW_CONVERT_EXPR(u)[_1] =
h is
suitable for us.
Thanks.
juzhe.zh...@rivai.ai
From: Richard Biener
Date: 2023-08-10 19:09
To: juzhe.zh...@rivai.ai
CC: gcc-patches; richard.sandiford
Subject: Re: Re: [PATCH V2] VECT: Support loop len control on EXTRACT_LAST
vectorization
On Thu, 10 Aug 2023, juzhe.zh...@rivai.ai
What
inserts the required LC SSA PHI in that case?
> Thanks.
>
>
> juzhe.zh...@rivai.ai
>
> From: Richard Biener
> Date: 2023-08-10 15:58
> To: Ju-Zhe Zhong
> CC: gcc-patches; richard.sandiford
> Subject: Re: [PATCH V2] VECT: Support loop len control on EXTRACT_LAST
= true ?
After it's fixed then this patch with removing
'vinfo->any_known_not_updated_vssa = true' is ok for trunk, am I right?
Thanks.
juzhe.zh...@rivai.ai
From: Richard Biener
Date: 2023-08-10 15:58
To: Ju-Zhe Zhong
CC: gcc-patches; richard.sandiford
Subject: Re: [PATCH V2] VECT:
ut that the LC SSA is
created by:
'rewrite_into_loop_closed_ssa'
Thanks.
juzhe.zh...@rivai.ai
From: Richard Biener
Date: 2023-08-10 15:58
To: Ju-Zhe Zhong
CC: gcc-patches; richard.sandiford
Subject: Re: [PATCH V2] VECT: Support loop len control on EXTRACT_LAST
vectorization
On Thu, 10 Aug 20
On Thu, 10 Aug 2023, juzhe.zh...@rivai.ai wrote:
> From: Ju-Zhe Zhong
>
> Hi, Richard and Richi.
>
> This patch add support live vectorization by VEC_EXTRACT for LEN loop control.
>
> Consider this following case:
>
> #include
>
> #define EXTRACT_LAST(TYPE)\
> TYPE
