Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2019-01-08 Thread Jakub Jelinek
On Tue, Jan 08, 2019 at 01:30:45PM +, Julian Brown wrote: > commit 2ee3f8d09a7b2af6c9ba29cdd8e8587db1946c0b > Author: Julian Brown > Date: Wed Dec 19 05:01:58 2018 -0800 > > Add testcase from PR71959 > > libgomp/ > > PR lto/71959 > * testsuite/libgomp.oacc-c+

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2019-01-08 Thread Julian Brown
On Sat, 22 Dec 2018 15:09:34 + Iain Sandoe wrote: > Hi Julian, > > > On 21 Dec 2018, at 16:47, Julian Brown > > wrote: > > > On Fri, 21 Dec 2018 14:31:19 +0100 > > Jakub Jelinek wrote: > > > >> On Fri, Dec 21, 2018 at 01:23:03PM +, Julian Brown wrote: > >>> 2018-xx-yy Nathan Si

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-22 Thread Iain Sandoe
Hi Julian, > On 21 Dec 2018, at 16:47, Julian Brown wrote: > > On Fri, 21 Dec 2018 14:31:19 +0100 > Jakub Jelinek wrote: > >> On Fri, Dec 21, 2018 at 01:23:03PM +, Julian Brown wrote: >>> 2018-xx-yy Nathan Sidwell > >>> * testsuite/libgomp.oacc-c++/pr71959-a.C: New. >>> * tes

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-21 Thread Julian Brown
Hi Jakub, Thanks for review! On Fri, 21 Dec 2018 14:31:19 +0100 Jakub Jelinek wrote: > On Fri, Dec 21, 2018 at 01:23:03PM +, Julian Brown wrote: > > 2018-xx-yy Nathan Sidwell > > > > PR lto/71959 > > libgomp/ > > * testsuite/libgomp.oacc-c++/pr71959-a.C: New. > >

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-21 Thread Jakub Jelinek
On Fri, Dec 21, 2018 at 01:23:03PM +, Julian Brown wrote: > 2018-xx-yy Nathan Sidwell > > PR lto/71959 > libgomp/ > * testsuite/libgomp.oacc-c++/pr71959-a.C: New. > * testsuite/libgomp.oacc-c++/pr71959.C: New. Just nits, better use pr71959-aux.cc (*.cc files

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-21 Thread Julian Brown
On Fri, 21 Dec 2018 02:56:36 + Julian Brown wrote: > On Tue, 25 Sep 2018 14:59:18 +0200 > Martin Jambor wrote: > > > Hi, > > > > I have noticed a few things... > > > > On Thu, Sep 20 2018, Cesar Philippidis wrote: > > > This is another old gomp4 patch that demotes an ICE in PR71959 to >

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-20 Thread Julian Brown
On Tue, 25 Sep 2018 14:59:18 +0200 Martin Jambor wrote: > Hi, > > I have noticed a few things... > > On Thu, Sep 20 2018, Cesar Philippidis wrote: > > This is another old gomp4 patch that demotes an ICE in PR71959 to a > > linker warning. One problem here is that it is not clear if OpenACC > >

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-09-25 Thread Martin Jambor
Hi, I have noticed a few things... On Thu, Sep 20 2018, Cesar Philippidis wrote: > This is another old gomp4 patch that demotes an ICE in PR71959 to a > linker warning. One problem here is that it is not clear if OpenACC > allows individual member functions in C++ classes to be marked as acc > ro