Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-19 Thread Jakub Jelinek
On Thu, Feb 19, 2015 at 08:45:08AM -0800, Aldy Hernandez wrote: > [And this time, actually CCing the list :)]. > > Gentlemen! > > Reading in the compiler state for pch (gt_pch_restore) obliterates the > DIE table, and consequently the DW_TAG_GNU_[BE]INCL* DIEs that may have > been in it. This ca

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-19 Thread Aldy Hernandez
On 02/19/2015 08:50 AM, Jakub Jelinek wrote: On Thu, Feb 19, 2015 at 08:45:08AM -0800, Aldy Hernandez wrote: [And this time, actually CCing the list :)]. Gentlemen! Reading in the compiler state for pch (gt_pch_restore) obliterates the DIE table, and consequently the DW_TAG_GNU_[BE]INCL* DIEs

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-19 Thread Jakub Jelinek
On Thu, Feb 19, 2015 at 10:33:20AM -0800, Aldy Hernandez wrote: > Well, any PCH file we generate will have some sort of early DIE in it (at > the very least the compilation unit DIE) and we will read these in at PCH > read-in time, obliterating whatever was already there. But most > importantly, w

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Jason Merrill
On 02/19/2015 11:50 AM, Jakub Jelinek wrote: Wouldn't it be better to disable PCH reading if -feliminate-dwarf2-dups is used? In the abstract, perhaps, but given https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53118 I'd prefer to disable the useless thing. :) We might actually disable -felimin

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Aldy Hernandez
On 02/25/2015 07:59 AM, Jason Merrill wrote: On 02/19/2015 11:50 AM, Jakub Jelinek wrote: Wouldn't it be better to disable PCH reading if -feliminate-dwarf2-dups is used? In the abstract, perhaps, but given https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53118 I'd prefer to disable the useless

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Jason Merrill
On 02/25/2015 12:02 PM, Aldy Hernandez wrote: + if (flag_eliminate_dwarf2_dups) +{ + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); + flag_eliminate_dwarf2_dups = 0; +} I think we only want to disable it for C++, not all languages. Jason

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Mike Stump
On Feb 25, 2015, at 1:13 PM, Jason Merrill wrote: > On 02/25/2015 12:02 PM, Aldy Hernandez wrote: >> + if (flag_eliminate_dwarf2_dups) >> +{ >> + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); >> + flag_eliminate_dwarf2_dups = 0; >> +} > > I think we only

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Aldy Hernandez
On 02/25/2015 01:13 PM, Jason Merrill wrote: On 02/25/2015 12:02 PM, Aldy Hernandez wrote: + if (flag_eliminate_dwarf2_dups) +{ + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); + flag_eliminate_dwarf2_dups = 0; +} I think we only want to disable it for

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Jason Merrill
On 02/25/2015 09:16 PM, Aldy Hernandez wrote: + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); Similarly, I'd rather say it's broken for C++. OK with that change. Jason

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Aldy Hernandez
On 02/25/2015 06:47 PM, Jason Merrill wrote: On 02/25/2015 09:16 PM, Aldy Hernandez wrote: + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); Similarly, I'd rather say it's broken for C++. OK with that change. Interesting. As in "ignoring broken C++ option -felimi

Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-26 Thread Jason Merrill
On 02/25/2015 09:53 PM, Aldy Hernandez wrote: On 02/25/2015 06:47 PM, Jason Merrill wrote: On 02/25/2015 09:16 PM, Aldy Hernandez wrote: + warning (0, "ignoring unimplemented option -feliminate-dwarf2-dups"); Similarly, I'd rather say it's broken for C++. OK with that change. Interest

PING Re: [patch] PR debug/46102 Disable -feliminate-dwarf2-dups when reading a PCH

2015-02-25 Thread Aldy Hernandez
On 02/19/2015 10:41 AM, Jakub Jelinek wrote: On Thu, Feb 19, 2015 at 10:33:20AM -0800, Aldy Hernandez wrote: Well, any PCH file we generate will have some sort of early DIE in it (at the very least the compilation unit DIE) and we will read these in at PCH read-in time, obliterating whatever was