Re: PATCH: Add --with-abi= support to x86_64-*-*

2012-04-02 Thread Nathanael Nerode (GCC)
On 03/28/2012 09:06 PM, H.J. Lu wrote: > On Sun, Mar 25, 2012 at 2:27 PM, Nathanael Nerode (GCC) > wrote: >> >>> Hi, >>> >>> Can any build maintainers review this patch? >> >> I don't feel comfortable reviewing this, because I don't fully >> comprehend the intricacy of the interactions in this are

Re: PATCH: Add --with-abi= support to x86_64-*-*

2012-03-28 Thread H.J. Lu
On Sun, Mar 25, 2012 at 2:27 PM, Nathanael Nerode (GCC) wrote: > >> Hi, >> >> Can any build maintainers review this patch? > > I don't feel comfortable reviewing this, because I don't fully > comprehend the intricacy of the interactions in this area.  It *looks* > good, but I don't trust my review

Re: PATCH: Add --with-abi= support to x86_64-*-*

2012-03-25 Thread Nathanael Nerode (GCC)
On 03/14/2012 12:22 PM, H.J. Lu wrote: > On Fri, Mar 2, 2012 at 10:00 AM, H.J. Lu wrote: >> Hi, >> >> This patch adds --with-abi= support to x86_64-*-* to configure GCC with >> >> --with-abi=x32 >> --with-abi=mx32 >> --with-multilib-list=mx32 >> >> to set the default ABI to x32. In i386 backend,

Re: PATCH: Add --with-abi= support to x86_64-*-*

2012-03-14 Thread H.J. Lu
On Fri, Mar 2, 2012 at 10:00 AM, H.J. Lu wrote: > Hi, > > This patch adds --with-abi= support to x86_64-*-* to configure GCC with > > --with-abi=x32 > --with-abi=mx32 > --with-multilib-list=mx32 > > to set the default ABI to x32.  In i386 backend, ISA_64BIT is used to > generate i386 code or x86-6