Re: Profile mode maintenance patch

2014-10-06 Thread Jonathan Wakely
On 04/10/14 22:54 +0200, François Dumont wrote: On 23/09/2014 13:27, Jonathan Wakely wrote: Yes, OK for trunk - thanks very much. Hi There was in fact one last test failing, ext/profile/mh.cc, a profile mode specific test. It must have been failing for quite a while since malloc hooks

Re: Profile mode maintenance patch

2014-10-04 Thread François Dumont
On 23/09/2014 13:27, Jonathan Wakely wrote: Yes, OK for trunk - thanks very much. Hi There was in fact one last test failing, ext/profile/mh.cc, a profile mode specific test. It must have been failing for quite a while since malloc hooks has been deprecated. It is normally testing the

Re: Profile mode maintenance patch

2014-09-23 Thread Jonathan Wakely
On 21/09/14 23:29 +0200, François Dumont wrote: With all those modifications I have been able to run all testsuite in profile mode with success. I've looked over the patch and it looks fine. I don't know the details of the Profile Mode, so if you're happy that these changes are an

Re: Profile mode maintenance patch

2014-09-23 Thread François Dumont
On 23/09/2014 13:27, Jonathan Wakely wrote: On 21/09/14 23:29 +0200, François Dumont wrote: With all those modifications I have been able to run all testsuite in profile mode with success. I've looked over the patch and it looks fine. I don't know the details of the Profile Mode, so if

Re: Profile mode maintenance patch

2014-09-23 Thread Jonathan Wakely
On 23 September 2014 22:19, François Dumont wrote: On 23/09/2014 13:27, Jonathan Wakely wrote: On 21/09/14 23:29 +0200, François Dumont wrote: With all those modifications I have been able to run all testsuite in profile mode with success. I've looked over the patch and it looks fine.

Re: profile mode maintenance patch

2014-05-25 Thread Paolo Carlini
Hi, On 05/24/2014 11:39 PM, Jonathan Wakely wrote: On 24 May 2014 22:10, François Dumont wrote: Done but I forgot to fix the spelling. I will fix it in the future patch. No problem, it's clear what the comment means. I'm committing the below. Paolo. / 2014-05-25 Paolo

Re: profile mode maintenance patch

2014-05-24 Thread Jonathan Wakely
On 12/05/14 22:14 +0200, François Dumont wrote: Hi Here is a maintenance patch for profile mode. It does: - Use inheritance to limit duplication of code in constructors to register for the different profiling mode diagnostics data structure. - Remove many code keeping only instrumented

Re: profile mode maintenance patch

2014-05-24 Thread François Dumont
On 24/05/2014 13:33, Jonathan Wakely wrote: On 12/05/14 22:14 +0200, François Dumont wrote: Hi Here is a maintenance patch for profile mode. It does: - Use inheritance to limit duplication of code in constructors to register for the different profiling mode diagnostics data structure. -

Re: profile mode maintenance patch

2014-05-24 Thread Jonathan Wakely
On 24 May 2014 22:10, François Dumont wrote: Done but I forgot to fix the spelling. I will fix it in the future patch. No problem, it's clear what the comment means.

Re: profile mode maintenance patch

2014-05-12 Thread Paolo Carlini
Hi, On 05/12/2014 10:14 PM, François Dumont wrote: Regarding Makefile.in I miss last time. I moved to a new system lately, a Ubuntu based one, and still need to find out what version of automake/autoreconf I need to install. For the moment I have updated Makefile.in manually. Isn't this

Re: profile mode maintenance patch

2014-05-12 Thread François Dumont
On 12/05/2014 22:42, Paolo Carlini wrote: Hi, On 05/12/2014 10:14 PM, François Dumont wrote: Regarding Makefile.in I miss last time. I moved to a new system lately, a Ubuntu based one, and still need to find out what version of automake/autoreconf I need to install. For the moment I have