Re: SRA: don't drop clobbers

2014-11-21 Thread Richard Biener
On Thu, Nov 20, 2014 at 7:11 PM, Martin Jambor mjam...@suse.cz wrote: Hi, On Mon, Nov 03, 2014 at 10:46:49PM +0100, Marc Glisse wrote: On Mon, 3 Nov 2014, Marc Glisse wrote: On Mon, 3 Nov 2014, Martin Jambor wrote: I just applied your patch on top of trunk revision 217032 on my Ah,

Re: SRA: don't drop clobbers

2014-11-20 Thread Martin Jambor
Hi, On Mon, Nov 03, 2014 at 10:46:49PM +0100, Marc Glisse wrote: On Mon, 3 Nov 2014, Marc Glisse wrote: On Mon, 3 Nov 2014, Martin Jambor wrote: I just applied your patch on top of trunk revision 217032 on my Ah, that explains it, thanks. This patch is a follow-up to r217034. Still, I

SRA: don't drop clobbers

2014-11-03 Thread Marc Glisse
Hello, now that the update_address_taken patch is in, let me re-post the SRA follow-up. With this patch, testcase pr60517.C (attached) has a use of an undefined variable at the time of the uninit pass. Sadly, while this warned with earlier versions of the other patch (when I was inserting

Re: SRA: don't drop clobbers

2014-11-03 Thread Martin Jambor
Hi, On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: Hello, now that the update_address_taken patch is in, let me re-post the SRA follow-up. With this patch, testcase pr60517.C (attached) has a use of an undefined variable at the time of the uninit pass. Sadly, while this

Re: SRA: don't drop clobbers

2014-11-03 Thread Marc Glisse
On Mon, 3 Nov 2014, Martin Jambor wrote: On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: Hello, now that the update_address_taken patch is in, let me re-post the SRA follow-up. With this patch, testcase pr60517.C (attached) has a use of an undefined variable at the time of the

Re: SRA: don't drop clobbers

2014-11-03 Thread Martin Jambor
Hi, On Mon, Nov 03, 2014 at 05:17:22PM +0100, Marc Glisse wrote: On Mon, 3 Nov 2014, Martin Jambor wrote: On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: now that the update_address_taken patch is in, let me re-post the SRA follow-up. With this patch, testcase pr60517.C

Re: SRA: don't drop clobbers

2014-11-03 Thread Marc Glisse
On Mon, 3 Nov 2014, Martin Jambor wrote: I just applied your patch on top of trunk revision 217032 on my Ah, that explains it, thanks. This patch is a follow-up to r217034. Still, I didn't expect the ICE you are seeing by applying this patch to older trunk, I'll try to reproduce that. --

Re: SRA: don't drop clobbers

2014-11-03 Thread Marc Glisse
On Mon, 3 Nov 2014, Marc Glisse wrote: On Mon, 3 Nov 2014, Martin Jambor wrote: I just applied your patch on top of trunk revision 217032 on my Ah, that explains it, thanks. This patch is a follow-up to r217034. Still, I didn't expect the ICE you are seeing by applying this patch to older

Re: SRA: don't drop clobbers

2014-07-10 Thread Richard Biener
On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally warn for the testcase of PR 60517. The new function is copied from init_subtree_with_zero right above. I guess it

Re: SRA: don't drop clobbers

2014-07-10 Thread Jakub Jelinek
On Thu, Jul 10, 2014 at 04:54:53PM +0200, Richard Biener wrote: + else if (access-grp_to_be_debug_replaced) +{ Why would we care to create clobbers for debug stmts?! Are those even valid? It is not valid. Though, the fields supposedly live nowhere after the clobber, so perhaps one

Re: SRA: don't drop clobbers

2014-07-07 Thread Richard Biener
On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally warn for the testcase of PR 60517. The new function is copied from init_subtree_with_zero right above. I guess it

Re: SRA: don't drop clobbers

2014-07-07 Thread Marc Glisse
On Mon, 7 Jul 2014, Richard Biener wrote: On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally warn for the testcase of PR 60517. The new function is copied from

Re: SRA: don't drop clobbers

2014-07-07 Thread Jeff Law
On 07/07/14 02:56, Richard Biener wrote: On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally warn for the testcase of PR 60517. The new function is copied from

Re: SRA: don't drop clobbers

2014-07-07 Thread Richard Biener
On July 7, 2014 11:32:10 AM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 7 Jul 2014, Richard Biener wrote: On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally

Re: SRA: don't drop clobbers

2014-07-07 Thread Marc Glisse
On Mon, 7 Jul 2014, Richard Biener wrote: The main idea of these patches is that when we read from a place that was clobbered, instead of dropping the clobber and reading what was there before, we can use a variable with a default definition to mark that the content is undefined. This enables

SRA: don't drop clobbers

2014-06-29 Thread Marc Glisse
Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally warn for the testcase of PR 60517. The new function is copied from init_subtree_with_zero right above. I guess it might be possible to merge them into a single function, if desired. I don't