Re: Unreviewed build/libgcc, mudflap patches

2011-06-29 Thread Arnaud Charlet
[ada, build] Link gnattools with $(LIBINTL) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01443.html This needs a build and/or Ada maintainer. I guess this is obvious, though. Can you clarify how LIBINTL is set, and to what value? Will it be empty when not needed? Arno

Re: Unreviewed build/libgcc, mudflap patches

2011-06-29 Thread Rainer Orth
Arnaud, [ada, build] Link gnattools with $(LIBINTL) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01443.html This needs a build and/or Ada maintainer. I guess this is obvious, though. Can you clarify how LIBINTL is set, and to what value? Will it be empty when not needed?

Re: Unreviewed build/libgcc, mudflap patches

2011-06-29 Thread Arnaud Charlet
[ada, build] Link gnattools with $(LIBINTL) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01443.html This needs a build and/or Ada maintainer. I guess this is obvious, though. Can you clarify how LIBINTL is set, and to what value? Will it be empty when not

Re: Unreviewed build/libgcc, mudflap patches

2011-06-29 Thread Paolo Bonzini
On 06/27/2011 01:32 PM, Rainer Orth wrote: Support libmudflap on Solaris (PR libmudflap/38738) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html This needs the mudflap maintainer. Build changes are okay, the rest is pretty obvious. For pass-stratcliff I'd rather use

Re: Unreviewed build/libgcc, mudflap patches

2011-06-29 Thread Rainer Orth
Paolo, On 06/27/2011 01:32 PM, Rainer Orth wrote: Support libmudflap on Solaris (PR libmudflap/38738) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html This needs the mudflap maintainer. Build changes are okay, the rest is pretty obvious. For pass-stratcliff I'd

Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
The following three patches have remained unreviewed for a week: [build] Move unwinder to toplevel libgcc http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html This needs at least a build and/or libgcc maintainer, though a global reviewer might be helpful. I'm not Cc'ing the

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Frank Ch. Eigler
Hi - On Mon, Jun 27, 2011 at 01:32:30PM +0200, Rainer Orth wrote: [...] Support libmudflap on Solaris (PR libmudflap/38738) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html Looks good to me, thanks for taking a look at the area. - FChE

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Frank, On Mon, Jun 27, 2011 at 01:32:30PM +0200, Rainer Orth wrote: [...] Support libmudflap on Solaris (PR libmudflap/38738) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html Looks good to me, thanks for taking a look at the area. Could you also comment on the open

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Frank Ch. Eigler
Hi - http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html Looks good to me, thanks for taking a look at the area. Could you also comment on the open questions in the submission so mudflap support on Solaris can be improved further? Sure. Transcribing: One generic issue came

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Iain Sandoe
Hi Rainer, On 27 Jun 2011, at 12:32, Rainer Orth wrote: The following three patches have remained unreviewed for a week: [build] Move unwinder to toplevel libgcc http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html This needs at least a build and/or libgcc maintainer,

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Frank, Support libmudflap on Solaris (PR libmudflap/38738) http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html Looks good to me, thanks for taking a look at the area. I've installed the patch as it, since it at least fixes the libmudflap build on Solaris. Thanks.

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Frank, Sure. Transcribing: One generic issue came up with the port: enabling or disabling libmudflap depends on a factor (linker support for --wrap/-z wrap) that is best checked dynamically, thus doesn't really seem to belong at the toplevel. Is there any precedent for performing such

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Iain, The following three patches have remained unreviewed for a week: [build] Move unwinder to toplevel libgcc http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html This needs at least a build and/or libgcc maintainer, though a global reviewer might be helpful. I'm not

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Mike Stump
On Jun 27, 2011, at 9:54 AM, Iain Sandoe wrote: On 27 Jun 2011, at 12:32, Rainer Orth wrote: The following three patches have remained unreviewed for a week: [build] Move unwinder to toplevel libgcc http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html As far as Darwin is