Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Marc Glisse
On Tue, 28 Feb 2012, Jakub Jelinek wrote: The problem is that config/abi/pre/gnu.ver doesn't end with a newline, [...] Of course we can add a newline to gnu.ver, but the next time somebody forgots to add a newline at the end of the file we'll have the same problem again. I seem to remember s

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Benjamin Kosnik
On Tue, 28 Feb 2012 00:12:33 +0100 Jakub Jelinek wrote: > and $(EGREP) -v '#(#| |$$)' just throws away the whole > };# Appended to version file. > line. I wonder if > sed -e 's/#[# $].*$//' > wouldn't be better, or alternative add ^ before the first # > in the egrep regex. Of course we can add

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Jakub Jelinek
On Mon, Feb 27, 2012 at 02:38:14PM +0100, Rainer Orth wrote: > Paolo Carlini writes: > > >> Jakub Jelinek writes: > >> > >>> On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: > The following patch has remained unreviewed for a week: > > [v3, libgomp, build] Fix Solaris

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Paolo Carlini
On 02/27/2012 02:38 PM, Rainer Orth wrote: While the mechanism introduced is generic, it currently affects Solaris only. And yes, I've compared versioning in libstdc++.so and libgomp.so on x86_64-unknown-linux-gnu without and with the patch as described in the submission: no change. Excellent.

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Rainer Orth
Paolo Carlini writes: >> Jakub Jelinek writes: >> >>> On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Paolo Carlini
Hi, Jakub Jelinek writes: On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Rainer Orth
Jakub Jelinek writes: > On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: >> The following patch has remained unreviewed for a week: >> >> [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) >> http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html >>

Re: Unreviewed libstdc++/libgomp patch

2012-02-22 Thread Jakub Jelinek
On Wed, Feb 22, 2012 at 12:07:39PM +0100, Rainer Orth wrote: > The following patch has remained unreviewed for a week: > > [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) > http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html > > It is critical to avoid br

Unreviewed libstdc++/libgomp patch

2012-02-22 Thread Rainer Orth
The following patch has remained unreviewed for a week: [v3, libgomp, build] Fix Solaris symbol versioning (PR libstdc++/52188) http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00819.html It is critical to avoid breaking libstdc++.so symbol versioning on Solaris and requires libstdc++