Re: Warn about virtual table mismatches

2014-02-12 Thread Jason Merrill
On 02/11/2014 10:27 PM, Jan Hubicka wrote: On 02/11/2014 07:54 PM, Jan Hubicka wrote: + /* Allow combining RTTI and non-RTTI is OK. */ You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, though you need to prefer the -frtti version in case code from that translation

Re: Warn about virtual table mismatches

2014-02-12 Thread Richard Biener
On Wed, Feb 12, 2014 at 7:27 AM, Jan Hubicka hubi...@ucw.cz wrote: On 02/11/2014 07:54 PM, Jan Hubicka wrote: + /* Allow combining RTTI and non-RTTI is OK. */ You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, though you need to prefer the -frtti version in case code

Re: Warn about virtual table mismatches

2014-02-12 Thread Bernhard Reutner-Fischer
On 12 February 2014 07:27:59 Jan Hubicka hubi...@ucw.cz wrote: On 02/11/2014 07:54 PM, Jan Hubicka wrote: +/* Allow combining RTTI and non-RTTI is OK. */ You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, though you need to prefer the -frtti version in case code

Warn about virtual table mismatches

2014-02-11 Thread Jan Hubicka
Hi, this patch implements warning when we merge two virtual tables that do not match. It compares the size and also go into fields. I had to implement my own comparsion code, since the vtables may subtly differ - in RTTI and also I need to do so during DECL merging (since we will forget about

Re: Warn about virtual table mismatches

2014-02-11 Thread Jason Merrill
On 02/11/2014 07:54 PM, Jan Hubicka wrote: + /* Allow combining RTTI and non-RTTI is OK. */ You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, though you need to prefer the -frtti version in case code from that translation unit uses the RTTI info.

Re: Warn about virtual table mismatches

2014-02-11 Thread Jan Hubicka
On 02/11/2014 07:54 PM, Jan Hubicka wrote: + /* Allow combining RTTI and non-RTTI is OK. */ You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, though you need to prefer the -frtti version in case code from that translation unit uses the RTTI info. Is there some