Re: cosmetic change - simplify cse.c:preferable()

2012-08-06 Thread Richard Guenther
On Sat, 4 Aug 2012, Dimitrios Apostolou wrote: On Thu, 19 Jul 2012, Richard Guenther wrote: I don't think it's any good or clearer to understand. Hi Richi, I had forgotten I prepared this for PR #19832, maybe you want to take a look. FWIW, with my patch applied there is a difference of

Re: cosmetic change - simplify cse.c:preferable()

2012-08-03 Thread Dimitrios Apostolou
On Thu, 19 Jul 2012, Richard Guenther wrote: I don't think it's any good or clearer to understand. Hi Richi, I had forgotten I prepared this for PR #19832, maybe you want to take a look. FWIW, with my patch applied there is a difference of ~3 M instr, which is almost unmeasurable in time.

Re: cosmetic change - simplify cse.c:preferable()

2012-07-19 Thread Richard Guenther
On Wed, 18 Jul 2012, Dodji Seketeli wrote: Hey Dimitrios, I can't say much about your patch, so I am CC-ing the maintainers. I don't think it's any good or clearer to understand. Richard. Thanks. Dimitrios Apostolou ji...@gmx.net a ?crit: Hello, I've had this patch some time

cosmetic change - simplify cse.c:preferable()

2012-07-08 Thread Dimitrios Apostolou
Hello, I've had this patch some time now, it's simple and cosmetic only, I had done it while trying to understand expression costs in CSE. I think it's more readable than the previous one. FWIW it passed all tests on x86. Thanks, Dimitris=== modified file 'gcc/cse.c' --- gcc/cse.c