Re: libbacktrace patch RFC: check size passed to backtrace_get_view

2019-01-18 Thread Ian Lance Taylor
On Fri, Jan 18, 2019 at 8:18 AM Tom de Vries wrote: > > On 18-01-19 16:40, Ian Lance Taylor wrote: > > int > > backtrace_get_view (struct backtrace_state *state ATTRIBUTE_UNUSED, > > - int descriptor, off_t offset, size_t size, > > + int descriptor, off_t offset,

Re: libbacktrace patch RFC: check size passed to backtrace_get_view

2019-01-18 Thread Tom de Vries
On 18-01-19 16:40, Ian Lance Taylor wrote: > int > backtrace_get_view (struct backtrace_state *state ATTRIBUTE_UNUSED, > - int descriptor, off_t offset, size_t size, > + int descriptor, off_t offset, uint64_t size, > backtrace_error_callback error

libbacktrace patch RFC: check size passed to backtrace_get_view

2019-01-18 Thread Ian Lance Taylor
I agree that checking the size passed to backtrace_get_view seems like the most reliable approach to avoid problems with large files on 32-bit systems. How does this patch look? Ian 2019-01-18 Ian Lance Taylor PR libbacktrace/88890 * mmapio.c (backtrace_get_view): Change size parameter to u