Re: libgo: fix spurious test failure in libgo/runtime/pprof

2018-08-13 Thread Andreas Schwab
On Aug 09 2018, Ian Lance Taylor wrote: > On Thu, Aug 9, 2018 at 8:03 AM, Andreas Schwab wrote: >> TestMemoryProfiler uses a too restrictive pattern that fails to match >> backtraces that contain two tabs after the function address. That can >> happen when the formatted addresses are of differe

Re: libgo: fix spurious test failure in libgo/runtime/pprof

2018-08-09 Thread Ian Lance Taylor
On Thu, Aug 9, 2018 at 8:03 AM, Andreas Schwab wrote: > TestMemoryProfiler uses a too restrictive pattern that fails to match > backtraces that contain two tabs after the function address. That can > happen when the formatted addresses are of different length: Your patch seems to be whitespace o

libgo: fix spurious test failure in libgo/runtime/pprof

2018-08-09 Thread Andreas Schwab
TestMemoryProfiler uses a too restrictive pattern that fails to match backtraces that contain two tabs after the function address. That can happen when the formatted addresses are of different length: 0: 0 [1: 2097152] @ 0x1746c 0x134a00 0x13450e 0x134fd8 0x84396 0x84892 0x17526