Hi Jakub,
Sorry for the rush of emails, I removed the Copyright part, I will use
DCO.
Note: I filled out the form.
On Wed, May 18, 2022 at 2:55 PM Mohamed Atef
wrote:
>
>
> On Wed, May 18, 2022 at 2:43 PM Jakub Jelinek wrote:
>
>> On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef
On Wed, May 18, 2022 at 2:43 PM Jakub Jelinek wrote:
> On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef wrote:
> > > As I said earlier, as this is just partial implementation of the
> > > OMPD, I think it would be better to commit it to a git branch but
> > > already in the upstream
On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef wrote:
> > As I said earlier, as this is just partial implementation of the
> > OMPD, I think it would be better to commit it to a git branch but
> > already in the upstream repository, say devel/omp/ompd branch.
> >
> > Do you have a FSF
Hi Jakub,
This is the final patch.
I fixed things that you mentioned.
I added two more small functions at ompd-helper.c.
One more thing, the functions in ompd-helper.c are very similar. I can try
to make them generic to a single
function but, I think it's better to get the value of every ICV by
On Wed, May 18, 2022 at 9:35 AM Jakub Jelinek wrote:
> On Mon, May 16, 2022 at 07:35:17PM +0200, Mohamed Atef via Gcc-patches
> wrote:
> > libgomp/ChangeLog
> >
> > 2022-05-15 Mohamed Atef
> >
> > *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
> > *config/hpux/plugin-suffix.h
On Mon, May 16, 2022 at 07:35:17PM +0200, Mohamed Atef via Gcc-patches wrote:
> libgomp/ChangeLog
>
> 2022-05-15 Mohamed Atef
>
> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
> *config/posix/plugin-suffix.h
libgomp/ChangeLog
2022-05-15 Mohamed Atef
*config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*configure: Regenerate.
*Makefile.am (toolexeclib_LTLIBRARIES): Add
On Sun, May 15, 2022 at 04:18:12PM +0200, Mohamed Atef wrote:
> Ping
>
> في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef
> كتب:
>
> > Hello Jakub,
> >I am sorry, but should #ifdef __ELF__ put and separate file and also
> > the actual functions (e.g. extern ompd_dll_location_valid (void))
> > I
في الأحد، ١٥ مايو، ٢٠٢٢ ٤:١٨ م Mohamed Atef كتب:
> Ping
>
> في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef
> كتب:
>
>> Hello Jakub,
>>I am sorry, but should #ifdef __ELF__ put and separate file and also
>> the actual functions (e.g. extern ompd_dll_location_valid (void))
>> I mean both in the
Ping
في الجمعة، ١٣ مايو، ٢٠٢٢ ٩:١٩ م Mohamed Atef
كتب:
> Hello Jakub,
>I am sorry, but should #ifdef __ELF__ put and separate file and also
> the actual functions (e.g. extern ompd_dll_location_valid (void))
> I mean both in the same files or the functions should be in the
> omp-tools.h but
Hello Jakub,
I am sorry, but should #ifdef __ELF__ put and separate file and also the
actual functions (e.g. extern ompd_dll_location_valid (void))
I mean both in the same files or the functions should be in the omp-tools.h
but with #ifndef __ELF__
Mohamed
On Fri, May 13, 2022 at 8:27 PM
On Fri, May 13, 2022 at 08:22:41PM +0200, Mohamed Atef wrote:
> > As I've tried to explain, this #ifdef __ELF__ doesn't belong
> > to the public header, which should contain just
> > extern void ompd_dll_locations_valid (void) __GOMPD_NOTHROW;
> > The #define should be in some internal header that
في الجمعة، ١٣ مايو، ٢٠٢٢ ٣:١٤ م Jakub Jelinek كتب:
> On Tue, May 10, 2022 at 07:40:41AM +0200, Mohamed Atef wrote:
> > --- a/libgomp/env.c
> > +++ b/libgomp/env.c
> > @@ -33,6 +33,7 @@
> > #ifndef LIBGOMP_OFFLOADED_ONLY
> > #include "libgomp_f.h"
> > #include "oacc-int.h"
> > +#include
On Tue, May 10, 2022 at 07:40:41AM +0200, Mohamed Atef wrote:
> --- a/libgomp/env.c
> +++ b/libgomp/env.c
> @@ -33,6 +33,7 @@
> #ifndef LIBGOMP_OFFLOADED_ONLY
> #include "libgomp_f.h"
> #include "oacc-int.h"
> +#include "ompd-support.h"
> #include
> #include
> #include
> @@ -89,6 +90,7 @@
Here is the final change.
On Tue, May 10, 2022 at 7:21 AM Mohamed Atef
wrote:
> Resubmission.
>
> libgomp/ChangeLog
>
> 2022-05-10 Mohamed Atef
>
> *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
> *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
>
Resubmission.
libgomp/ChangeLog
2022-05-10 Mohamed Atef
*config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s.
*configure: Regenerate.
* Makefile.am
16 matches
Mail list logo
