Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 18:21, Nicola Pero wrote: This patch switches all the testcases in the ObjC/ObjC++ testsuite to use the Modern Objective-C runtime API when executing with the GNU runtime. This will allow me to complete removing the Traditional Objective-C runtime API from libobjc. :-)

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Mike Stump
On Jun 6, 2011, at 10:21 AM, Nicola Pero wrote: > This patch switches all the testcases in the ObjC/ObjC++ testsuite to use the > Modern Objective-C runtime API when executing with the GNU runtime. > OK to commit ? Ok, from me with one possible exception, I'd like Iain or Jack to weigh in on weth

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Dominique Dhumieres
Nicola, On x86_64-apple-darwin10 I have the following failures with -m32 FAIL: obj-c++.dg/threedotthree-abi-1.mm -fnext-runtime (test for excess errors) FAIL: obj-c++.dg/torture/strings/const-str-10.mm -O0 -fnext-runtime (test for excess errors) FAIL: obj-c++.dg/torture/strings/const-str-10.m

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 21:07, Nicola Pero wrote: On x86_64-apple-darwin10 I have the following failures with -m32 darwin10 is Mac OS X 10.6, right ? I have access to that. So, how do you test with -m32 ? I thought the testsuite would do that (test both with -m32 and -m64 if they are availabl

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 21:23, IainS wrote: It doesn't... .. if you want to be pedantic the following should cover all bases on a given platform > 10.4: make -k check-objc check-obj-c++ RUNTESTFLAGS="--target_board=unix\{- m32,-m32/-fabi-version=1,-m64\} " duh.. I should check my typing befor

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Dominique Dhumieres
> ... So, how do you test with -m32 ? ... make -k check-obj-c++ RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'" On x86_64-apple-darwin10 (Mac OS X 10.6) -m64 is the default and could be omitted after the comma, but the above works also on ppc for which the default is -m32. > The revamped patch i

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread Mike Stump
On Jun 6, 2011, at 1:32 PM, Dominique Dhumieres wrote: >> The revamped patch in attach should fix them. :-) > > It does, thanks, Ok, Iain chimed in that he's ok with it going in sooner, and since -m32 now works, I think this work can go in now, thanks. Thanks for the testing help Dominique!

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-06 Thread IainS
On 6 Jun 2011, at 22:37, Mike Stump wrote: On Jun 6, 2011, at 1:32 PM, Dominique Dhumieres wrote: The revamped patch in attach should fix them. :-) It does, thanks, Ok, Iain chimed in that he's ok with it going in sooner, and since - m32 now works, I think this work can go in now, thanks.

Re: objc/objc++: switch all testcases to Modern Objective-C runtime API

2011-06-07 Thread Nicola Pero
> I checked on i686-darwin9 with both m32 and m32/abi=1 the only difference I > see is the XPASSes > for m64 torture/forward-1.m for gnu runtime. That is very comforting; I have committed the (revised) patch. Thanks a lot for your help testing and reviewing. :-) > I will try to test on darwin8 d