Re: optabs: Variable index vec_set

2022-11-06 Thread Uros Bizjak via Gcc-patches
On Sat, Nov 5, 2022 at 12:25 PM Richard Biener wrote: > > On Wed, Nov 2, 2022 at 1:46 PM Uros Bizjak wrote: > > > > On Wed, Nov 2, 2022 at 1:45 PM Robin Dapp wrote: > > > > > > > IIRC, I was trying to "fix" modeless operand by giving it a mode, but > > > > since it made no difference for x86, I

Re: optabs: Variable index vec_set

2022-11-05 Thread Richard Biener via Gcc-patches
On Wed, Nov 2, 2022 at 1:46 PM Uros Bizjak wrote: > > On Wed, Nov 2, 2022 at 1:45 PM Robin Dapp wrote: > > > > > IIRC, I was trying to "fix" modeless operand by giving it a mode, but > > > since it made no difference for x86, I later dropped the patch. > > > However, operand with a known mode is

Re: optabs: Variable index vec_set

2022-11-02 Thread Uros Bizjak via Gcc-patches
On Wed, Nov 2, 2022 at 1:45 PM Robin Dapp wrote: > > > IIRC, I was trying to "fix" modeless operand by giving it a mode, but > > since it made no difference for x86, I later dropped the patch. > > However, operand with a known mode is preferred, so if it works for > > you, just include my patch

Re: optabs: Variable index vec_set

2022-11-02 Thread Robin Dapp via Gcc-patches
> IIRC, I was trying to "fix" modeless operand by giving it a mode, but > since it made no difference for x86, I later dropped the patch. > However, operand with a known mode is preferred, so if it works for > you, just include my patch in your submission. My patch is somehow > trivial if we want

Re: optabs: Variable index vec_set

2022-11-02 Thread Uros Bizjak via Gcc-patches
On Wed, Nov 2, 2022 at 1:12 PM Robin Dapp wrote: > > Hi, > > > With the patch my local changes to make better use of vec_set work > > nicely even though I haven't done a full bootstrap yet. Were there > > other issues with the patch or can it still be applied? > > I performed a bootstrap as well

Re: optabs: Variable index vec_set

2022-11-02 Thread Robin Dapp via Gcc-patches
Hi, > With the patch my local changes to make better use of vec_set work > nicely even though I haven't done a full bootstrap yet. Were there > other issues with the patch or can it still be applied? I performed a bootstrap as well as a regtest with -march=z16 on s390. There is no new fallout.

optabs: Variable index vec_set

2022-10-31 Thread Robin Dapp via Gcc-patches
Hi, I'm looking into vec_set with variable index on s390. Uros posted a patch [1] that did not make it upstream in Nov 2020. It changed the mode of the index operand to whatever the target supports in can_vec_set_var_idx_p. I missed it back then but we indeed do not make proper use of vec_set