Re: set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-27 Thread Rong Xu
On Fri, Apr 27, 2012 at 5:06 AM, Jan Hubicka wrote: >> On Fri, Apr 27, 2012 at 12:50 PM, Eric Botcazou >> wrote: >> >> We do not depend on the block structure any more when dealing with >> >> stack layout for variables in GCC 4.7.0 and above.  I am not saying >> >> your patch is incorrect or not

Re: set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-27 Thread Jan Hubicka
> On Fri, Apr 27, 2012 at 12:50 PM, Eric Botcazou wrote: > >> We do not depend on the block structure any more when dealing with > >> stack layout for variables in GCC 4.7.0 and above.  I am not saying > >> your patch is incorrect or not needed.  Just it will not have an > >> effect on variable st

Re: set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-27 Thread Richard Guenther
On Fri, Apr 27, 2012 at 12:50 PM, Eric Botcazou wrote: >> We do not depend on the block structure any more when dealing with >> stack layout for variables in GCC 4.7.0 and above.  I am not saying >> your patch is incorrect or not needed.  Just it will not have an >> effect on variable stack layout

Re: set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-27 Thread Eric Botcazou
> We do not depend on the block structure any more when dealing with > stack layout for variables in GCC 4.7.0 and above. I am not saying > your patch is incorrect or not needed. Just it will not have an > effect on variable stack layout. It might be worth backporting to the 4.6 branch though, t

Re: set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-24 Thread Rong Xu
please the find test case in the attachment. It shows the issue in google-4_6 branch -c -O2 -fno-strict-aliasing ss.C -fdump-rtl-expand-all in the rtl-expand dump, trianglevertices and one the gtest_ar are in the same partition. the problem is found in arm compiler, but we manager to reproduce

Re: set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-24 Thread Andrew Pinski
On Tue, Apr 24, 2012 at 2:57 PM, Rong Xu wrote: > Hi, > > In split_function() (ipa-split.c), for the newly created call stmt, > its block is set to the outermost scope, i.e. > DECL_INITIAL(current_function_decl). When we inline this > partially outlined function, we create the new block based on t

set the correct block info for the call stmt in fnsplit (issue6111050)

2012-04-24 Thread Rong Xu
Hi, In split_function() (ipa-split.c), for the newly created call stmt, its block is set to the outermost scope, i.e. DECL_INITIAL(current_function_decl). When we inline this partially outlined function, we create the new block based on the block for the call stmt (in expand_call_inline()). So th