std::vector default default and move constructors

2017-07-23 Thread François Dumont
Hi Is it time now to consider this patch ? * include/bits/stl_vector.h (_Vector_impl_data): New. (_Vector_impl): Inherit from latter. (_Vertor_impl(_Vector_impl&&, _Tp_alloc_type&&)): New. (_Vector_base(_Vector_base&&, const allocator_type&)): Use latter. (_Vector_bas

Re: std::vector default default and move constructors

2017-07-28 Thread François Dumont
Hi There was a little issue in this patch, here is the correct version. François On 23/07/2017 19:41, François Dumont wrote: Hi Is it time now to consider this patch ? * include/bits/stl_vector.h (_Vector_impl_data): New. (_Vector_impl): Inherit from latter. (_Vertor

Re: std::vector default default and move constructors

2017-08-21 Thread François Dumont
Following feedback on std::list patch this one had the same problem of unused code being deleted. So here is a new version. Ok to commit ? François On 28/07/2017 18:45, François Dumont wrote: Hi There was a little issue in this patch, here is the correct version. François On 23/07/201

Re: std::vector default default and move constructors

2017-09-04 Thread François Dumont
Hi Gentle reminder. Thanks On 21/08/2017 21:15, François Dumont wrote: Following feedback on std::list patch this one had the same problem of unused code being deleted. So here is a new version. Ok to commit ? François On 28/07/2017 18:45, François Dumont wrote: Hi There was a l

Re: std::vector default default and move constructors

2018-06-26 Thread Jonathan Wakely
On 02/06/18 14:00 +0200, François Dumont wrote: Hi     Here is this patch again, I consider all your remarks and also made some changes considering feedback on rbtree patch. + _Vector_impl(_Tp_alloc_type const& __a) _GLIBCXX_NOEXCEPT + : _Tp_alloc_type(__a) + { } + +#if _

Re: std::vector default default and move constructors

2018-06-27 Thread François Dumont
Commited attached patch. It fixes the missing noexcept qualification on a __gnu_debug::vector<> constructor. 2018-06-27  François Dumont      * include/bits/stl_vector.h     (struct _Vector_base<>::_Vector_impl_data): New.     (struct _Vector_base<>::_Vector_impl): Inherit from latter.     (

Re: std::vector default default and move constructors

2018-01-10 Thread François Dumont
Hi     Here is an updated patch.     Tested under Linux x86_64.     Ok to commit ? François On 21/08/2017 21:15, François Dumont wrote: Following feedback on std::list patch this one had the same problem of unused code being deleted. So here is a new version. Ok to commit ? François On

Re: std::vector default default and move constructors

2018-01-10 Thread Marc Glisse
On Thu, 11 Jan 2018, François Dumont wrote: - void _M_swap_data(_Vector_impl& __x) _GLIBCXX_NOEXCEPT + void + _M_swap_data(_Vector_impl_data& __x) _GLIBCXX_NOEXCEPT { std::swap(_M_start, __x._M_start); std::swap(_M_finish, __x._M_finish); st

Re: std::vector default default and move constructors

2018-01-10 Thread Marc Glisse
On Thu, 11 Jan 2018, Marc Glisse wrote: On Thu, 11 Jan 2018, François Dumont wrote: - void _M_swap_data(_Vector_impl& __x) _GLIBCXX_NOEXCEPT + void + _M_swap_data(_Vector_impl_data& __x) _GLIBCXX_NOEXCEPT { std::swap(_M_start, __x._M_start); std::swap(

Re: std::vector default default and move constructors

2018-01-18 Thread François Dumont
On 16/01/2018 01:20, Jonathan Wakely wrote: On 15/01/18 22:32 +0100, François Dumont wrote: On 15/01/2018 13:29, Jonathan Wakely wrote: In fact it introduces a serious regression because of this line: -  vector(vector&& __x) noexcept -  : _Base(std::move(__x)) { } +  vector(vector

Re: std::vector default default and move constructors

2018-01-29 Thread Jonathan Wakely
On 18/01/18 22:01 +0100, François Dumont wrote: On 16/01/2018 01:20, Jonathan Wakely wrote: On 15/01/18 22:32 +0100, François Dumont wrote: On 15/01/2018 13:29, Jonathan Wakely wrote: In fact it introduces a serious regression because of this line: -  vector(vector&& __x) noexcept - 

Re: std::vector default default and move constructors

2018-06-02 Thread François Dumont
Hi     Here is this patch again, I consider all your remarks and also made some changes considering feedback on rbtree patch.     * include/bits/stl_vector.h     (struct _Vector_base<>::_Vector_impl_data): New.     (struct _Vector_base<>::_Vector_impl): Inherit from latter.     (_Vector_base<>