Re: symtab PATCH for c++/61623 (comdat issue in verify_symtab)

2014-07-16 Thread Jan Hubicka
> On 07/15/2014 04:46 AM, Jan Hubicka wrote: > >I think we still want to check that the local comdats are linked into > >the corresponding comdat group, so we probably want > >to test node->definition instead of node->public, or perhaps just clear > >COMDAT_GROUP info when removing symbol? > > Lik

Re: symtab PATCH for c++/61623 (comdat issue in verify_symtab)

2014-07-15 Thread Jason Merrill
On 07/15/2014 04:46 AM, Jan Hubicka wrote: I think we still want to check that the local comdats are linked into the corresponding comdat group, so we probably want to test node->definition instead of node->public, or perhaps just clear COMDAT_GROUP info when removing symbol? Like this? commi

Re: symtab PATCH for c++/61623 (comdat issue in verify_symtab)

2014-07-15 Thread Jan Hubicka
> The problem in this testcase is that we inlined the decloned > constructor into the calling thunks, so it was removed by > symtab_remove_unreachable_nodes. verify_symtab sees that it is no > longer linked to the calling thunks with same_comdat_group and > complains. > > Here I've changed verify

symtab PATCH for c++/61623 (comdat issue in verify_symtab)

2014-07-14 Thread Jason Merrill
The problem in this testcase is that we inlined the decloned constructor into the calling thunks, so it was removed by symtab_remove_unreachable_nodes. verify_symtab sees that it is no longer linked to the calling thunks with same_comdat_group and complains. Here I've changed verify_symtab to