Re: system.h vs. C++ STL headers again

2014-11-14 Thread Jeff Law
On 11/14/14 03:57, Richard Biener wrote: I think we should simply discourage people from using sstream for example. I can live with that -- I've seen sstream stuff fly by in a few places, almost asked the submitters to remove it (I find the style of coding most folks use with sstream horrid t

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 12:27:52PM +0100, Bernd Schmidt wrote: > On 11/14/2014 12:03 PM, Jakub Jelinek wrote: > >On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: > >>>? There are also some comments about stdarg.h and stdio.h ordering, > >>>dunno what it comes from and if it is still

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Bernd Schmidt
On 11/14/2014 12:03 PM, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: ? There are also some comments about stdarg.h and stdio.h ordering, dunno what it comes from and if it is still relevant when we require C++ compiler. I think we should simply discoura

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 12:03 PM, Jakub Jelinek wrote: > On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: >> > ? There are also some comments about stdarg.h and stdio.h ordering, >> > dunno what it comes from and if it is still relevant when we require >> > C++ compiler. >> >> I th

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote: > > ? There are also some comments about stdarg.h and stdio.h ordering, > > dunno what it comes from and if it is still relevant when we require > > C++ compiler. > > I think we should simply discourage people from using sstream for

Re: system.h vs. C++ STL headers again

2014-11-14 Thread Richard Biener
On Fri, Nov 14, 2014 at 8:18 AM, Jakub Jelinek wrote: > On Tue, Nov 11, 2014 at 11:46:55AM +0100, Richard Biener wrote: >> > BTW: There are lots of places where std::swap can be used, a nice >> > search-and-replace task for someone to start with gcc development. ;) >> >> Agreed ;) Note that we ha

system.h vs. C++ STL headers again

2014-11-13 Thread Jakub Jelinek
On Tue, Nov 11, 2014 at 11:46:55AM +0100, Richard Biener wrote: > > BTW: There are lots of places where std::swap can be used, a nice > > search-and-replace task for someone to start with gcc development. ;) > > Agreed ;) Note that we have to be careful to avoid pulling all of libstdc++ > into al