Re: testsuite: introduce hostedlib effective target

2023-11-09 Thread Mike Stump
On Nov 8, 2023, at 8:29 AM, Alexandre Oliva wrote: > > On Nov 5, 2023, Mike Stump wrote: > >> that, otherwise, I'll approve this version. > > FWIW, this version is not usable as is. Something went wrong in my > testing, and several regressions only visible in hosted mode made to the >

Re: testsuite: introduce hostedlib effective target

2023-11-08 Thread Alexandre Oliva
On Nov 5, 2023, Mike Stump wrote: > that, otherwise, I'll approve this version. FWIW, this version is not usable as is. Something went wrong in my testing, and several regressions only visible in hosted mode made to the version I posted, that adds some missing end-of-comment markers for the

Re: testsuite: introduce hostedlib effective target

2023-11-08 Thread Jonathan Wakely
On Wed, 8 Nov 2023 at 15:48, Jonathan Wakely wrote: > > On Wed, 8 Nov 2023 at 15:30, Alexandre Oliva wrote: > > > > On Nov 7, 2023, Jonathan Wakely wrote: > > > > > An alternative approach for the g++ testsuite would be to provide a > > > set of dummy headers for the non-freestanding ones, so

Re: testsuite: introduce hostedlib effective target

2023-11-08 Thread Jonathan Wakely
On Wed, 8 Nov 2023 at 15:30, Alexandre Oliva wrote: > > On Nov 7, 2023, Jonathan Wakely wrote: > > > An alternative approach for the g++ testsuite would be to provide a > > set of dummy headers for the non-freestanding ones, so that all the > > hosted-only headers are provided by the testsuite

Re: testsuite: introduce hostedlib effective target

2023-11-08 Thread Alexandre Oliva
On Nov 7, 2023, Jonathan Wakely wrote: > An alternative approach for the g++ testsuite would be to provide a > set of dummy headers for the non-freestanding ones, so that all the > hosted-only headers are provided by the testsuite itself, but consist > of a single line: > #error not available

Re: testsuite: introduce hostedlib effective target

2023-11-07 Thread Jonathan Wakely
On Tue, 7 Nov 2023 at 10:24, Jonathan Wakely wrote: > > On Tue, 7 Nov 2023 at 10:18, Jonathan Wakely wrote: > > > > On Tue, 7 Nov 2023 at 10:04, Alexandre Oliva wrote: > > > > > > [adding libstdc++@] > > > > > > On Nov 5, 2023, Mike Stump wrote: > > > > > > > Ick. > > > > > > Indeed ;-) > > >

Re: testsuite: introduce hostedlib effective target

2023-11-07 Thread Jonathan Wakely
On Tue, 7 Nov 2023 at 10:18, Jonathan Wakely wrote: > > On Tue, 7 Nov 2023 at 10:04, Alexandre Oliva wrote: > > > > [adding libstdc++@] > > > > On Nov 5, 2023, Mike Stump wrote: > > > > > Ick. > > > > Indeed ;-) > > > > > I wish there were fewer changed lines and not 1 per test > > > case. It

Re: testsuite: introduce hostedlib effective target

2023-11-07 Thread Jonathan Wakely
On Tue, 7 Nov 2023 at 10:04, Alexandre Oliva wrote: > > [adding libstdc++@] > > On Nov 5, 2023, Mike Stump wrote: > > > Ick. > > Indeed ;-) > > > I wish there were fewer changed lines and not 1 per test > > case. It feels like we've painted ourselves into a corner. > > The libstdc++ testsuite

Re: testsuite: introduce hostedlib effective target

2023-11-07 Thread Alexandre Oliva
[adding libstdc++@] On Nov 5, 2023, Mike Stump wrote: > Ick. Indeed ;-) > I wish there were fewer changed lines and not 1 per test > case. It feels like we've painted ourselves into a corner. The libstdc++ testsuite took a different approach, detecting missing headers (and libraries?) at

Re: testsuite: introduce hostedlib effective target

2023-11-05 Thread Mike Stump
On Nov 1, 2023, at 6:11 PM, Alexandre Oliva wrote: > > Several C++ tests fail with --disable-hosted-libstdcxx, whether > because stdc++ext gets linked in despite not being built, because > standard headers are included but that are unavailable in this mode, > or because headers are (mistakenly?)