Re: useless_type_conversion_p vs pointer sizes

2012-01-16 Thread Tristan Gingold
On Jan 13, 2012, at 10:59 PM, DJ Delorie wrote: That should not be necessary as there is a mode check below. Do you hit the issue only when the VOID_TYPE_P check is true? In that case simply delete it - it has become obsolete. That seems to be happening, yes, but there are other checks

Re: useless_type_conversion_p vs pointer sizes

2012-01-16 Thread DJ Delorie
Ah! I read that as pointer to aggregate :-P

Re: useless_type_conversion_p vs pointer sizes

2012-01-16 Thread DJ Delorie
For the record, what is TPF ? One of IBM's s390x operating systems. ../gcc/configure --target=tpf

Re: useless_type_conversion_p vs pointer sizes

2012-01-15 Thread Eric Botcazou
So two different sized pointers to aggregate types will also have a problem? Nope, you misread the test: /* Changes in machine mode are never useless conversions unless we deal with aggregate types in which case we defer to later checks. */ if (TYPE_MODE (inner_type) != TYPE_MODE

Re: useless_type_conversion_p vs pointer sizes

2012-01-13 Thread Richard Guenther
On Fri, Jan 13, 2012 at 12:09 AM, DJ Delorie d...@redhat.com wrote: Another case where one address space may support multiple pointer sizes, so conversions between such must be preserved.        * tree-ssa.c (useless_type_conversion_p): Conversions between        different-sized pointers

Re: useless_type_conversion_p vs pointer sizes

2012-01-13 Thread Tristan Gingold
On Jan 13, 2012, at 10:30 AM, Richard Guenther wrote: On Fri, Jan 13, 2012 at 12:09 AM, DJ Delorie d...@redhat.com wrote: Another case where one address space may support multiple pointer sizes, so conversions between such must be preserved. * tree-ssa.c

Re: useless_type_conversion_p vs pointer sizes

2012-01-13 Thread DJ Delorie
That should not be necessary as there is a mode check below. Do you hit the issue only when the VOID_TYPE_P check is true? In that case simply delete it - it has become obsolete. That seems to be happening, yes, but there are other checks that might let differing modes through... /*

useless_type_conversion_p vs pointer sizes

2012-01-12 Thread DJ Delorie
Another case where one address space may support multiple pointer sizes, so conversions between such must be preserved. * tree-ssa.c (useless_type_conversion_p): Conversions between different-sized pointers aren't useless. Index: tree-ssa.c