Re: regex traits test not testing wchar_t

2013-09-10 Thread Ed Smith-Rowland
Y( t.value(L'7', 10) == 7 ); + VERIFY( t.value(L'7', 16) == 7 ); + VERIFY( t.value(L'9', 8) == -1 ); + VERIFY( t.value(L'9', 10) == 9 ); + VERIFY( t.value(L'9', 16) == 9 ); + VERIFY( t.value(L'd', 8) == -1 ); + VERIFY( t.value(L&

Re: [Patch] match_results::format and regex_replace

2013-09-24 Thread Ed Smith-Rowland
On 09/23/2013 10:09 PM, Tim Shen wrote: On Sun, Sep 22, 2013 at 4:20 PM, Paolo Carlini wrote: If testing goes well patch is Ok to commit. Tested under -m32 and -m64 and committed :) I'll learn how locale in glibc works. Thank you all! Thank *you*! has been dogging us for years. I, for

User-define literals for std::complex.

2013-09-26 Thread Ed Smith-Rowland
strapped and regtested on x86_64-linux. As a general stylistic guide for the library I think I'll put operator""abc(...) with no spaces. Later. OK? 2013-09-27 Ed Smith-Rowland <3dw...@verizon.net> Implement N3779 - User-defined Literals for std::complex,

Re: Add the Hoyt and the arcsine distributions as extensions.

2012-10-12 Thread Ed Smith-Rowland
On 10/12/2012 10:50 AM, Paolo Carlini wrote: On 10/12/2012 04:19 PM, Ed Smith-Rowland wrote: These are my last two random distribution extensions for now. Thanks a lot! The main on is the Hoyt distribution (AKA the Nakagami-q distribution). It uses the arcsine with specified basis. The

Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Ed Smith-Rowland
Committed. 2012-10-26 Edward Smith-Rowland <3dw...@verizon.net> * include/std/system_error (system_error(error_code, const char*), system_error(int, const error_category&, const char*)): New. * include/std/stdexcept ( logic_error(const char*), domain_error(const

Re: Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Ed Smith-Rowland
On 10/26/2012 10:26 AM, Paolo Carlini wrote: On 10/26/2012 04:11 PM, Ed Smith-Rowland wrote: Committed. I can't find the message actually approving the patch. And personally I'm a bit nervous about it. Paolo. Sorry, i though it was OK. Do you want me to roll back? do you want to? Ed

Re: Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Ed Smith-Rowland
On 10/26/2012 10:26 AM, Paolo Carlini wrote: On 10/26/2012 04:11 PM, Ed Smith-Rowland wrote: Committed. I can't find the message actually approving the patch. And personally I'm a bit nervous about it. Paolo. Well, the commit had failed anyway... ChangeLog out of date. So I'll wait. Ed

PR libstdc++/58729 - tr2::dynamic_bitset::resize fails

2013-10-17 Thread Ed Smith-Rowland
This patch bootstraps and tests clean on x86-64-linux. Truthfully, dynamic_bitset needs some more love wrt C++11 and a testsuite. It got put in before it was baked really. That will be later. 2013-10-16 Edward Smith-Rowland <3dw...@verizon.net> PR libstdc++/58729 * include/tr

PR C++/58708 - string literal operator templates broken

2013-10-17 Thread Ed Smith-Rowland
Here is a patch to correct the char type and the type, number of nontype parameter pack for user defined strng literal operator templates. Bootstrapped and tested on x86_64-linux. OK? gcc/cp: 2013-10-17 Edward Smith-Rowland <3dw...@verizon.net> PR c++/58708 * parser.c (mak

Re: User-define literals for std::complex.

2013-10-20 Thread Ed Smith-Rowland
On 09/27/2013 05:39 AM, Jonathan Wakely wrote: On 27 September 2013 05:17, Ed Smith-Rowland wrote: The complex user-defined literals finally passed (n3779) with the resolution to DR1473 allowing the suffix id to touch the quotes (Can't find it but I put it in not too long ago). I think

[PR libstdc++/58804][PR libstdc++/58729] tr2/dynamic_bitset issues.

2013-10-20 Thread Ed Smith-Rowland
Greetings. Here is a patch to correct tr2/dynamic_bitset to use __builtin_xxxll for long long instead of the long versions. Relevant bugs: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58804 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58729 Builds and *really* tests clean on x86_64-linux. OK?

[C++14] implement [[deprecated]].

2013-10-22 Thread Ed Smith-Rowland
I think this is pretty easy - gnu::deprecated has the same semantics. Bootstrapped and tested on x86_64-linux. OK? gcc/cp: 2013-10-22 Edward Smith-Rowland <3dw...@verizon.net> * parser.c (cp_parser_std_attribute): Interpret [[deprecated]] as [[gnu::deprecated]]. gcc/testsu

Re: [C++14] implement [[deprecated]].

2013-10-22 Thread Ed Smith-Rowland
On 10/22/2013 08:37 AM, Paolo Carlini wrote: On 10/22/2013 02:28 PM, Ed Smith-Rowland wrote: I think this is pretty easy - gnu::deprecated has the same semantics. Unfortunately however, gnu::deprecated has a number of long standing issues (just search Bugzilla), personally I'm not sure we

Re: [C++14] implement [[deprecated]].

2013-10-22 Thread Ed Smith-Rowland
On 10/22/2013 12:00 PM, Jason Merrill wrote: OK. Jason There is discussion about several bugs in gnu::deprecated upon which this is based over on the libstdc++ list. I could see where we are with those bugs in a week or two. Or just wait until they are fixed. OTOH, I don't think my patch wou

[c++-concepts] small tidbits to get it to build

2013-10-22 Thread Ed Smith-Rowland
I had to get past two small bugs to get c++-concepts to build. Take a good look because I'm not sure if they're right. The solutions should be harmless though. Ed 2013-10-23 Edward Smith-Rowland <3dw...@verizon.net> make concepts build. * constraint.cc (make_constraints):

Re: [c++-concepts] small tidbits to get it to build

2013-10-23 Thread Ed Smith-Rowland
ouple of others that we grabbed for some other concepts-related work, but which aren't included in Concepts Lite. I'll apply the typeck fix. Andrew Sutton On Tue, Oct 22, 2013 at 10:02 PM, Ed Smith-Rowland <3dw...@verizon.net> wrote: I had to get past two small bugs to get c++

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 06:08 AM, Paolo Carlini wrote: Hi, On 10/18/2013 04:42 AM, Ed Smith-Rowland wrote: --- testsuite/g++.dg/cpp1y/pr58708.C (revision 0) +++ testsuite/g++.dg/cpp1y/pr58708.C(working copy) @@ -0,0 +1,70 @@ +// { dg-options -std=c++1y } + +#include +#include +#include +#include

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front-end testcase doesn't, why not. Paolo. I think this patch should be sufficient - no conta

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 10:01 AM, Paolo Carlini wrote: On 10/25/2013 03:46 PM, Ed Smith-Rowland wrote: On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front

Re: PR C++/58708 - string literal operator templates broken

2013-10-25 Thread Ed Smith-Rowland
On 10/25/2013 10:01 AM, Paolo Carlini wrote: On 10/25/2013 03:46 PM, Ed Smith-Rowland wrote: On 10/25/2013 07:54 AM, Paolo Carlini wrote: On 10/25/2013 01:38 PM, Ed Smith-Rowland wrote: So, you also want a library testcase? Up to you: if you feel it would test something that the c++ front

C++14 digit separators..

2013-10-27 Thread Ed Smith-Rowland
Here is an implementation for C++14 digit separators (single quote). It's still testing on x86_64-linux but I wanted to give folks a chance to check it out. Ed libcpp: 2013-10-28 Edward Smith-Rowland <3dw...@verizon.net> implement C++14 digit separators. * include/cpplib.h

Re: C++14 digit separators..

2013-10-30 Thread Ed Smith-Rowland
On 10/28/2013 09:44 AM, Jason Merrill wrote: On 10/28/2013 09:10 AM, Joseph S. Myers wrote: On Sun, 27 Oct 2013, Ed Smith-Rowland wrote: Here is an implementation for C++14 digit separators (single quote). I tend to think that such features should come with a test that the feature is not

Re: PR C++/58708 - string literal operator templates broken

2013-10-31 Thread Ed Smith-Rowland
On 10/25/2013 10:40 AM, Jakub Jelinek wrote: On Fri, Oct 25, 2013 at 10:29:41AM -0400, Ed Smith-Rowland wrote: 2013-10-25 Edward Smith-Rowland <3dw...@verizon.net> PR c++/58708 * parser.c (make_string_pack): Discover non-const type and size of character and

TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-01-20 Thread Ed Smith-Rowland
Now that libstdc++ installs a proper math.h we can piggyback on that to put in the last bit of TR29124. This patch adds the math special functions to c_compatibility/math.h in the global namespace. I remove the XFAILs from the compile_2.cc tests. This converts 21 XFAILs into 21 PASSes. Teste

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-01-21 Thread Ed Smith-Rowland
On 01/21/2016 07:29 AM, Jonathan Wakely wrote: On 20/01/16 20:30 -0500, Ed Smith-Rowland wrote: Now that libstdc++ installs a proper math.h we can piggyback on that to put in the last bit of TR29124. This patch adds the math special functions to c_compatibility/math.h in the global namespace

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-01-22 Thread Ed Smith-Rowland
On 01/22/2016 05:39 AM, Jonathan Wakely wrote: On 21/01/16 19:07 -0500, Ed Smith-Rowland wrote: On 01/21/2016 07:29 AM, Jonathan Wakely wrote: On 20/01/16 20:30 -0500, Ed Smith-Rowland wrote: Now that libstdc++ installs a proper math.h we can piggyback on that to put in the last bit of

Re: [patch] Remove empty directories

2013-11-29 Thread Ed Smith-Rowland
On 11/29/2013 08:38 AM, Matthias Klose wrote: trunk has some empty directories. ok to remove? gcc/testsuite/go.test/test/fixedbugs/bug478.dir libstdc++-v3/testsuite/experimental/string_view/requirements/exception libstdc++-v3/testsuite/experimental/string_view/capacity/wchar_t libstdc++-v3/tests

[C++11] DR1479 - Literal operators and default arguments

2013-12-05 Thread Ed Smith-Rowland
This patch rejects literal operators with defaulted arguments with an extra note to that effect. Not a big deal but it responds to a "malformed program" statement in the draft. Builds and tests clean on x86_64-linux. OK? Ed CL_udlit_nodefault Description: Binary data patch_udlit_nodefa

Re: TR1 Special Math

2015-10-25 Thread Ed Smith-Rowland
On 10/24/2015 11:38 PM, Jonathan Wakely wrote: On 8 May 2015 at 15:05, Ed Smith-Rowland <3dw...@verizon.net> wrote: On 05/07/2015 12:06 PM, Jonathan Wakely wrote: Hi Ed, The C++ committee is considering the http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4437.pdf proposal to

Re: TR1 Special Math

2015-11-13 Thread Ed Smith-Rowland
On 11/13/2015 10:32 AM, Jonathan Wakely wrote: On 25 October 2015 at 20:48, Jonathan Wakely wrote: On 25 October 2015 at 17:46, Ed Smith-Rowland <3dw...@verizon.net> wrote: On 10/24/2015 11:38 PM, Jonathan Wakely wrote: On 8 May 2015 at 15:05, Ed Smith-Rowland <3dw...@verizon.net>

Re: Aw: Re: TR1 Special Math

2015-11-16 Thread Ed Smith-Rowland
On 11/16/2015 07:28 PM, Florian Goth wrote: Hi all, just a quick note that I'm still around... Any particular pointers how I can help in improving the implementation? Cheers, Florian. Gesendet: Samstag, 14. November 2015 um 21:40 Uhr Von: "Ed Smith-Rowland" <3dw...@verizon.

[PATCH libquadmath, pr68686] tgammaq(x) is always negative for noninteger x < 0

2017-11-13 Thread Ed Smith-Rowland
Here is a patch for tammaq for negative argument pr68686. I know about depending on ports from upstream but this was done recently and this (tgammaq) was left out. This patch is basically a one-liner. I have test cases but libquadmath doesn't have a testsuite. One test just shows alternating

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-18 Thread Ed Smith-Rowland
On 11/17/2017 03:54 PM, Jonathan Wakely wrote: Hmm, you're probably right. I'd be tempted to though. I had an idea.  What about a macro _GLIBCXX_ELLINT_3_POS_NU or something that: 1. would allow users to detect which convention is on by default. 2. They could set or unset to get the other c

Re: [libstdc++] Expose Airy functions.

2017-11-18 Thread Ed Smith-Rowland
Here is the final patch fir libstdc++ Airy functions... 2017-11-18 Edward Smith-Rowland <3dw...@verizon.net> * include/bits/specfun.h: Expose airy_ai and airy_bi. * include/tr1/modified_bessel_func.tcc: Treat NaN and inf arg, return. * testsuite/ext/special_functions/ai

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-01-01 Thread Ed Smith-Rowland
On 12/31/2017 09:38 PM, Michele Pezzutti wrote: Hi. This patch intends to fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders. Seehttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=83566 forissue description.     * libstdc++-v3/include/tr1/bessel_function.tcc   Series

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-01-01 Thread Ed Smith-Rowland
On 12/31/2017 09:38 PM, Michele Pezzutti wrote: Hi. This patch intends to fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders. Seehttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=83566 forissue description.     * libstdc++-v3/include/tr1/bessel_function.tcc   Series

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-01-02 Thread Ed Smith-Rowland
On 12/31/2017 09:38 PM, Michele Pezzutti wrote: Hi. This patch intends to fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders. Seehttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=83566 forissue description.     * libstdc++-v3/include/tr1/bessel_function.tcc   Series

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-01-02 Thread Ed Smith-Rowland
On 01/02/2018 04:41 PM, Michele Pezzutti wrote: On 01/02/2018 05:59 PM, Ed Smith-Rowland wrote: OK, on *third* look summing up to k = nu/2 at minimum will a achieve the result of not blowing up the asymptotic series: nu^2 - (2k-1)^2.  And it will do that without a check. This stopping

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-01-04 Thread Ed Smith-Rowland
On 01/03/2018 02:49 PM, Michele Pezzutti wrote: Hi. On 01/02/2018 05:43 PM, Michele Pezzutti wrote: On 01/02/2018 02:28 AM, Ed Smith-Rowland wrote: I like the patch. I have a similar one in the tr29124 branch. Anyway, I got held up and I think it's good to have new folks looking

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-01-05 Thread Ed Smith-Rowland
On 01/04/2018 03:54 PM, Michele Pezzutti wrote: On 01/04/2018 06:16 PM, Ed Smith-Rowland wrote: On 01/03/2018 02:49 PM, Michele Pezzutti wrote: Hi. On 01/02/2018 05:43 PM, Michele Pezzutti wrote: On 01/02/2018 02:28 AM, Ed Smith-Rowland wrote: I like the patch. I have a similar one in

Re: RFC: What should go in our header?

2018-06-17 Thread Ed Smith-Rowland
On 06/15/2018 11:52 AM, Jonathan Wakely wrote: C++20 adds a header, which should define all the library feature test macros, as well as implementation-specific macros like _GLIBCXX_RELEASE and __GLIBCXX__. We should decide whether to implement by simply including and then adding the feature t

[libstdc++; pr66689; pr68397] Backport special function fixes to 7.

2018-04-26 Thread Ed Smith-Rowland
I'm thinking of going back on my choice not to fix special function bugs on 7. These build and test clean on gcc-7. OK? 2018-04-30 Edward Smith-Rowland <3dw...@verizon.net> PR libstdc++/pr66689 - comp_ellint_3 and ellint_3 return garbage values * include/tr1/ell_integral.tc

Re: [PATCH] PR libstdc++/80506 fix constant used in condition

2018-05-05 Thread Ed Smith-Rowland
On 04/26/2017 05:16 AM, Jonathan Wakely wrote: On 26/04/17 11:14 +0200, Paolo Carlini wrote: .. or maybe using the wrong constant only impacts the performance?!? Yes, I think so. I did some very simple sanity tests and the numbers were identical before and after. I was backporting this and

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-05-05 Thread Ed Smith-Rowland
On 01/08/2018 02:08 PM, Michele Pezzutti wrote: Formatting fixed. diff --git a/libstdc++-v3/include/tr1/bessel_function.tcc b/libstdc++-v3/include/tr1/bessel_function.tcc index 7ac733d..5f8fc9f 100644 --- a/libstdc++-v3/include/tr1/bessel_function.tcc +++ b/libstdc++-v3/include/tr1/bessel_func

Re: Fix Bug 83566 - cyl_bessel_j returns wrong result for x>1000 for high orders

2018-05-06 Thread Ed Smith-Rowland
Michele, So I think the patch you had plus tests testsuite/tr1/5_numerical_facilities/special_functions/09_cyl_bessel_j/check_value.cc testsuite/tr1/5_numerical_facilities/special_functions/11_cyl_neumann/check_value.cc plus I'd like the new tests also in   testsuite/special_functions/08_cyl_bess

[libstdc++, PATCH] PR libstdc++/83140 - assoc_legendre returns negated value when m is odd.

2018-05-07 Thread Ed Smith-Rowland
All, We were using a different convention for P_l^m assoc_legendre(int l, int m, FloatTp x)  - the so-called Condon-Shortley convention which includes (-1)^m.  This unfortunately is common. This factor is taken out to match the standard.  The underlying __detail code has an arg that allows

Re: [libstdc++, PATCH] PR libstdc++/83140 - assoc_legendre returns negated value when m is odd.

2018-05-10 Thread Ed Smith-Rowland
On 05/09/2018 05:30 AM, Jonathan Wakely wrote: On 07/05/18 12:39 -0400, Ed Smith-Rowland wrote: All, We were using a different convention for P_l^m assoc_legendre(int l, int m, FloatTp x)  - the so-called Condon-Shortley convention which includes (-1)^m.  This unfortunately is common

Quo Vadis tr1? Was: [libstdc++, PATCH] PR libstdc++/83140 - assoc_legendre returns negated value when m is odd.

2018-05-10 Thread Ed Smith-Rowland
All, We could consider dropping the TR1 support, and just provide these functions for ISO/IEC 29124:2010 in C++11 (or later) and for C++17. But that decision should be taken separately, and should only happen on trunk anyway so we need to use _Tp(+1) here. I am in favour of splitting new versi

Re: [libstdc++, PATCH] PR libstdc++/83140 - assoc_legendre returns negated value when m is odd.

2018-05-10 Thread Ed Smith-Rowland
On 05/10/2018 01:44 PM, Rainer Orth wrote: Hi Ed, 2018-05-07  Edward Smith-Rowland  <3dw...@verizon.net> PR libstdc++/83140 - assoc_legendre returns negated value when m is odd * include/tr1/legendre_function.tcc (__assoc_legendre_p): Add __phase argument defaulted to +1.  Doxy

Re: [libstdc++, PATCH] PR libstdc++/83140 - assoc_legendre returns negated value when m is odd.

2018-05-11 Thread Ed Smith-Rowland
which always causes a failure: +FAIL: tr1/5_numerical_facilities/special_functions/02_assoc_legendre/check_value.cc (test for excess errors) Excess errors: Undefined first referenced symbol in file main/usr/l

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-08-09 Thread Ed Smith-Rowland
On 08/09/2014 11:33 AM, Marc Glisse wrote: On Sat, 9 Aug 2014, Ulrich Drepper wrote: If you are going to specialize for dim 2, I imagine you won't be computing normal distributions, you will only generate a point uniformy in a square and reject it if it is not in the ball? (interestingly enoug

Re: [c++-concepts] explicit instantiation and specialization

2014-08-13 Thread Ed Smith-Rowland
I get build fail: ../../gcc_concepts/gcc/cp/call.c:8793:8: error: unused variable ‘m1’ [-Werror=unused-variable] tree m1 = get_temploid (cand1); ^ ../../gcc_concepts/gcc/cp/call.c:8794:8: error: unused variable ‘m2’ [-Werror=unused-variable] tree m2 = get_temploid (cand2);

Re: [PATCH, C++, CPP] Add C++1z to the preprocessor. Rename C++1y to C++14.

2014-08-23 Thread Ed Smith-Rowland
On 08/22/2014 04:36 PM, Jason Merrill wrote: OK, thanks. Jason Committed 214400. Attached patch is the one committed. Thanks. libcpp/ 2014-08-23 Edward Smith-Rowland <3dw...@verizon.net> * include/cpplib.h (enum c_lang): Add CLK_GNUCXX1Z, CLK_CXX1Z; Rename CLK_GNUCXX1Y,

[PATCH. libstdc++] Use the correct C++14 __cplusplus value (201402L). Added C++1z to the preprocessor.

2014-08-23 Thread Ed Smith-Rowland
#if __cplusplus > 201402L ... #endif Built and tested clean on x86_64-linux. OK? 2014-08-23 Ed Smith-Rowland <3dw...@verizon.net> * libsupc++/new: Use the C++14 value of __cplusplus as appropriate. * include/bits/parse_numbers.h: Ditto. * include/bits/stl_fun

Re: [PATCH. libstdc++] Use the correct C++14 __cplusplus value (201402L). Added C++1z to the preprocessor.

2014-08-26 Thread Ed Smith-Rowland
On 08/26/2014 04:59 AM, Paolo Carlini wrote: Hi, On 08/26/2014 10:56 AM, Rainer Orth wrote: bits/c++config... Which won't help users seeing them in the headers. Maybe the issue could be avoided by chosing names that make it clear that they are g++/libstdc++ specific, not generic? Sure, whatev

[PATCH, CPP/23827] standard C++ should not have hex float preprocessing tokens

2014-08-27 Thread Ed Smith-Rowland
This old one says the C++98 ANSI doesn't have hex float literals and should error gracefully. Fixed by changing a language feature flag as suggested by the audit trail and by adding an error message. Built and tested on x86_64-linux. OK? libcpp/ 2014-08-27 Edward Smith-Rowland <3dw...@ver

Re: [PATCH, CPP/23827] standard C++ should not have hex float preprocessing tokens

2014-08-28 Thread Ed Smith-Rowland
On 08/27/2014 03:40 PM, Jason Merrill wrote: OK. Jason Is this OK for 4.9 also? It builds and tests clean on x86_64-linux. Attached slightly modified patch. Ed libcpp/ 2014-08-28 Edward Smith-Rowland <3dw...@verizon.net> PR cpp/23827 - standard C++ should not have hex float pre

Re: [PATCH, CPP/23827] standard C++ should not have hex float preprocessing tokens

2014-08-28 Thread Ed Smith-Rowland
On 08/28/2014 09:47 AM, Jason Merrill wrote: On 08/28/2014 09:41 AM, Marc Glisse wrote: In my opinion it is not appropriate for a backport, no. If someone was using hex floats with -std=c++98 with 4.9.1, it should still work with 4.9.2, I only expect to have to fix such things when moving to 5.0

[PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-01 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This first part adds a __has_include__ built-in that will return true if a header exists. I also added __has_include_next__ as an extension. Clang has this extension. Both these built-ins will be wrapped in function type

[PATCH C++] - SD-6 Implementation Part 2 - __has_include macro and C++ language feature macros.

2014-09-01 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This second part adds a __has_include function-like macro that will return true if a header exists. I also added a __has_include_next function-like macro as an extension. Clang has this extension. These macros just wrap t

[PATCH C++] - SD-6 Implementation Part 3 - .

2014-09-01 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This adds feature macros to various libstdc++ components. The new version of SD-6 cleans up the shared_mutex noise. Some libraries that were moved to different tSen are still given macros as they are in the SD-6 draft. Bo

[PATCH C++] - SD-6 Implementation

2014-09-01 Thread Ed Smith-Rowland
The Fourth installment, testing and other oddments will be sent tomorrow. The implementation of __has_cpp_attribute is underway and will come in a few days as a Fifth installment (modulo bugs this should be all). I have it working in C++. I feel though that it would be welcome as it is in clang

[PATCH C++] - SD-6 Implementation Part 4 - Test suite.

2014-09-06 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This adds front end and preprocessor tests for the language feature tests and __has_include. I am still working on the fifth and last in this series to add __had_cpp_attribute but these first four patches add a very usefu

Re: [C++14] implement [[deprecated]].

2013-11-09 Thread Ed Smith-Rowland
On 10/27/2013 05:17 AM, Paolo Carlini wrote: On 10/22/2013 02:28 PM, Ed Smith-Rowland wrote: I think this is pretty easy - gnu::deprecated has the same semantics. Since we decided to have this now, we should also update the docs, thus htdocs/projects/cxx1y.html (which normally would link

[wwwdocs] [C++14] Library and front-end additions

2013-11-09 Thread Ed Smith-Rowland
On 10/27/2013 05:17 AM, Paolo Carlini wrote: On 10/22/2013 02:28 PM, Ed Smith-Rowland wrote: I think this is pretty easy - gnu::deprecated has the same semantics. Since we decided to have this now, we should also update the docs, thus htdocs/projects/cxx1y.html (which normally would link

Re: [wwwdocs] [C++14] Library and front-end additions

2013-11-10 Thread Ed Smith-Rowland
On 11/10/2013 11:54 AM, Jonathan Wakely wrote: On 10 November 2013 16:52, Jonathan Wakely wrote: I thought I'd already made similar changes to gcc-4.9/changes.html for the C++14 changes but I never committed it. The only comment I have is that "chrono" isn't a type, but the change is fine as f

Re: [wwwdocs] [C++14] Library and front-end additions

2013-11-10 Thread Ed Smith-Rowland
On 11/10/2013 03:59 PM, Jonathan Wakely wrote: On 10 November 2013 20:28, Ed Smith-Rowland wrote: OK, I folded our versions together. Thank you. I also fixed up my code examples. OK? That looks good, thanks very much for updating it. OK, I got gcc-4.9/changes.html checked in (after some

Allow [[deprecated]] even for C++11 (with pedwarn)

2014-10-05 Thread Ed Smith-Rowland
Greetings, There was some feeling that not allowing [[deprecated]] for C++ was a little extreme. This patch builds and tests clean on x86_64-linux. OK? Ed gcc/c-family: 2014-10-06 Edward Smith-Rowland <3dw...@verizon.net> * c-family/c-cppbuiltin.c: Move __cpp_attribute_deprecat

Re: [wwwdocs] Add feature-testing macros and std::is_final to gcc-5/changes.html

2014-10-07 Thread Ed Smith-Rowland
On 10/02/2014 10:24 AM, Jonathan Wakely wrote: On 02/10/14 10:09 -0400, Ed Smith-Rowland wrote: On 10/02/2014 06:14 AM, Jonathan Wakely wrote: On 02/10/14 11:12 +0100, Jonathan Wakely wrote: Note Ed's recent changes. Committed to CVS. And fix a markup error that I expected xmllint to

Re: [4.9 PATCH, testsuite]: Fix g++.dg/cpp1y/feat-cxx14.C testsuite errors

2014-10-09 Thread Ed Smith-Rowland
On 10/09/2014 05:54 PM, Mike Stump wrote: On Oct 9, 2014, at 11:56 AM, Uros Bizjak wrote: 2014-10-09 Uros Bizjak * g++.dg/cpp1y/feat-cxx14.C: Variable templates not in yet. (dg-do): Use c++1y target. Tested on x86_64. OK for branch? So, I need Ed or Jason to review it… Yes, plea

Re: [C++11, C++14 PATCH 2/3] Support for SD-6: SG10 Feature Test Recommendations - c-family and testsuite

2014-06-02 Thread Ed Smith-Rowland
On 06/02/2014 10:31 AM, Jason Merrill wrote: On 05/31/2014 02:30 AM, Marc Glisse wrote: Also, I am pretty sure that gcc doesn't support the latest constexpr, we shouldn't define those macros lightly. That's correct. We should leave __cpp_constexpr at 200704 for now. Right... That was a testi

Re: [PATCH, PR C++/61038] - g++ -E is unusable with UDL strings

2014-06-05 Thread Ed Smith-Rowland
On 05/20/2014 04:44 PM, Jason Merrill wrote: On 05/13/2014 08:59 PM, Ed Smith-Rowland wrote: + escape_it = escape_it || cpp_userdef_string_p (token->type) +|| cpp_userdef_char_p (token->type); Let's add the new cases to the previous statement instead of a ne

Re: std::quoted doesn't respect padding

2014-06-05 Thread Ed Smith-Rowland
On 04/01/2014 07:33 AM, Jonathan Wakely wrote: [CCing gcc-patches] On 11/03/14 11:18 -0400, Ed Smith-Rowland wrote: On 02/14/2014 07:56 PM, Jonathan Wakely wrote: We need to implement this fix (probably after 4.9 is released though) http://cplusplus.github.io/LWG/lwg-active.html#2344 Here

Re: std::quoted doesn't respect padding

2014-06-06 Thread Ed Smith-Rowland
On 06/05/2014 11:48 AM, Jonathan Wakely wrote: On 05/06/14 11:43 -0400, Ed Smith-Rowland wrote: On 04/01/2014 07:33 AM, Jonathan Wakely wrote: [CCing gcc-patches] On 11/03/14 11:18 -0400, Ed Smith-Rowland wrote: On 02/14/2014 07:56 PM, Jonathan Wakely wrote: We need to implement this fix

Re: std::quoted doesn't respect padding

2014-06-06 Thread Ed Smith-Rowland
On 06/06/2014 10:27 AM, Jonathan Wakely wrote: On 06/06/14 10:08 -0400, Ed Smith-Rowland wrote: I'll look at rdbuf. Error in rdbuf? Do I need to do something? No, just me being dumb. The ostream::operator<<(streambuf*) overload behaves as an unformatted output function, so won

[4.9] Re: std::quoted doesn't respect padding - backport from trunk.

2014-06-07 Thread Ed Smith-Rowland
On 06/06/2014 11:41 PM, Ed Smith-Rowland wrote: On 06/06/2014 10:27 AM, Jonathan Wakely wrote: On 06/06/14 10:08 -0400, Ed Smith-Rowland wrote: I'll look at rdbuf. Error in rdbuf? Do I need to do something? No, just me being dumb. The ostream::operator<<(streambuf*) overload be

[C++11, C++14 PATCH 1/4] Support for SD-6: SG10 Feature Test Recommendations: libcpp

2014-06-09 Thread Ed Smith-Rowland
This is the second round of the SD-6 support series. I believe I have answered everyones concerns. Built and tested on x86_64-linux. OK? 2014-06-09 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * directives.c: Support __has_inc

[C++11, C++14 PATCH 2/4] Support for SD-6: SG10 Feature Test Recommendations: gcc/c-family

2014-06-09 Thread Ed Smith-Rowland
This is the second round of the SD-6 support series. I believe I have answered everyones concerns. Built and tested on x86_64-linux. OK? 2014-06-09 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * c-cppbuiltin.c (c_cpp_bu

[C++11, C++14 PATCH 3/4] Support for SD-6: SG10 Feature Test Recommendations: libstdc++-v3

2014-06-09 Thread Ed Smith-Rowland
This is the second round of the SD-6 support series. I believe I have answered everyones concerns. Several test suite adjustments were added. Built and tested on x86_64-linux. OK? 2014-06-09 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommend

[C++11, C++14 PATCH 4/4] Support for SD-6: SG10 Feature Test Recommendations: gcc/testsuite

2014-06-09 Thread Ed Smith-Rowland
This is the second round of the SD-6 support series. I believe I have answered everyones concerns. Built and tested on x86_64-linux. OK? libstdc++: 2014-06-09 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * g++.dg/cpp1y/feat

Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-24 Thread Ed Smith-Rowland
I saw this during bootstrap. I've verified that the patch works (I was working on similar). Ed

Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-24 Thread Ed Smith-Rowland
I am still having problems doing a full build. I get stuck on something that I think can't be a concepts problem in gcc/config/i386/i386.c: make[3]: Entering directory `/home/ed/obj_concepts/gcc' /home/ed/obj_concepts/./prev-gcc/xg++ -B/home/ed/obj_concepts/./prev-gcc/ -B/home/ed/bin_concept

Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-24 Thread Ed Smith-Rowland
I'm not sure the warning is correct in any case... In i386.h struct stringop_algs { const enum stringop_alg unknown_size; const struct stringop_strategy { const int max; const enum stringop_alg alg; int noalign; } size [MAX_STRINGOP_ALGS]; }; in i386.c ---

Re: Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-24 Thread Ed Smith-Rowland
On 06/24/14, Andrew Sutton wrote: Weird. Any chance you're doing a bootstrap build? There was an earlier bootstrapping issue with this branch. We had turned on -std=c++1y by default, and it was causing some conversion errors with lvalue references to bitfields in libasan. This doesn't *look

Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-26 Thread Ed Smith-Rowland
On 06/25/2014 10:03 AM, Andrew Sutton wrote: I did a full 3-stage bootstrap which is the default these days. I'll try --disable-bootstrap and see what happens. I just did a full bootstrap build and got the same errors. The errors are correct for C++11, which was enabled by default in this branch

Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-26 Thread Ed Smith-Rowland
So is C++14 a done deal with a __cplusplus date and all? I've been waiting for some news or a trip report from Rapperswil and have seen nothing on isocpp. I've been thinking of adding a thing or two to C++1z like clang has - The Disabling trigraph expansion by default looks easy. Ed

Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-27 Thread Ed Smith-Rowland
On 06/26/2014 11:28 PM, Jason Merrill wrote: On 06/26/2014 09:38 PM, Ed Smith-Rowland wrote: So is C++14 a done deal with a __cplusplus date and all? The C++14 draft was finalized at the February meeting in Issaquah; the ratification process isn't quite done, but I haven't heard

Re: [Bug c++/60249] [c++11] Compiler goes into semi-infinite loop with wrong usage of user defined string literals

2014-06-28 Thread Ed Smith-Rowland
On 06/27/2014 05:39 PM, paolo.carlini at oracle dot com wrote: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60249 --- Comment #5 from Paolo Carlini --- Patch looks *great*. If it works, please send it to mailing list ASAP. I think I finally got these weird user-defined string literal bugs. "D

[PATCH PR C++/58781, 59867, 60249 ] Various user-defined string literal issues involving character encodings, dropped bytes, semi-infinite loops

2014-06-28 Thread Ed Smith-Rowland
ates (not available in C++11). Built and tested clean on x86_64-linux. OK? I would also like to apply this to 4.9. Ed Smith-Rowland cp/ 2014-06-28 Edward Smith-Rowland <3dw...@verizon.net> PR c++/58781 PR c++/60249 PR c++/59867 * parser.c (cp_parser

PR C++/60209 - Declaration of user-defined literal operator cause error

2014-07-03 Thread Ed Smith-Rowland
Support operator"" ""(...) per CWG 1473. I'll be AFK over the holiday. Bootstrapped and tested on x86_64-linux. OK? I'm less sure if this is appropriate for 4.9. Index: cp/parser.c === --- cp/parser.c (revision 212248) +++ cp/par

[C++ Patch] PR 58155 - -Wliteral-suffix warns about tokens which are skipped

2014-07-07 Thread Ed Smith-Rowland
This patch addresses an old issue of warning about macro touching string literal even if the code is skipped: #define BAZ "baz" #if 0 "bar"BAZ #endif Just skip the warning Wliteral-suffix if the preprocessor is skipping. Built and tested on x86_64-linux. OK? And for 4.9

[PING] [C++17] Implement N3928 - Extending static_assert

2015-05-19 Thread Ed Smith-Rowland
On 05/02/2015 04:16 PM, Ed Smith-Rowland wrote: This extends' static assert to not require a message string. I elected to make this work also for C++11 and C++14 and warn only with -pedantic. I think many people just write static_assert(thing, ""); . I took the path of bu

Re: C/C++ PATCH to allow deprecating enum values (PR c/47043)

2015-05-23 Thread Ed Smith-Rowland
On 05/22/2015 06:19 PM, Mikhail Maltsev wrote: On 22.05.2015 12:10, Marek Polacek wrote: Thanks, applied. Here's the final version. By the way, we have a feature test macro, __cpp_attributes=200809 which can be used to determine, whether C++11 attribute syntax is supported by the compiler. I

[wwwdocs] Remove extra SD-6 column in C++14 language stats.

2015-04-19 Thread Ed Smith-Rowland
I accidentally added an extra column to the C++14 language stats by duplicating a column for the SD-6 feature test macros. This one-liner fixes it. I'll need someone to apply this... Sorry. Ed ? class_key.txt ? help ? patch ? patch_cxx14 ? patch_cxx14_2 ? patch_cxx14_3 ? patch_cxx1y ? patch_

[PATCH] [libstdc++] Add uniform container erasure.

2015-04-30 Thread Ed Smith-Rowland
This has been in me tree for a good while. It is fairly simple and adds C++ experimental container erasure. Builds and tests cleanly on x86_64-linux. OK? Index: include/Makefile.am === --- include/Makefile.am (revision 222573) +++

Re: [PATCH] [libstdc++] Add uniform container erasure.

2015-04-30 Thread Ed Smith-Rowland
And make_array, which isn't in the working paper yet, so I'd prefer to leave that part out for now. D'oh! Sorry about that.. Removed. The Doxygen @headername command tells users which header they are supposed to include, rather than this one. Since there is no header that's wrong. I'd just

Re: [PATCH] [libstdc++] Add uniform container erasure.

2015-05-01 Thread Ed Smith-Rowland
On 04/30/2015 02:01 PM, Daniel Krügler wrote: Shouldn't the "one-liner" forwarding function templates be declared as inline? - Daniel You are right. This builds and tests clean on x86_64-linux. OK? 2015-05-01 Edward Smith-Rowland <3dw...@verizon.net> Inline one-line erasure dispat

Re: [libstdc++ PATCH] Implement observer_ptr

2015-05-01 Thread Ed Smith-Rowland
On 05/01/2015 05:01 PM, Jonathan Wakely wrote: On 01/05/15 16:37 +0300, Ville Voutilainen wrote: Tested on Linux-x64. Implement observer_ptr. Thanks! Committed with some minor formatting changes. I've also committed this to add feature-test macros and update the docs. Tested powerpc64le-l

Re: [libstdc++ PATCH] Implement observer_ptr

2015-05-02 Thread Ed Smith-Rowland
On 05/02/2015 05:42 AM, Jonathan Wakely wrote: On 02/05/15 10:40 +0100, Jonathan Wakely wrote: On 01/05/15 22:02 -0400, Ed Smith-Rowland wrote: On 05/01/2015 05:01 PM, Jonathan Wakely wrote: On 01/05/15 16:37 +0300, Ville Voutilainen wrote: Tested on Linux-x64. Implement observer_ptr

[C++17] Implement N3928 - Extending static_assert

2015-05-02 Thread Ed Smith-Rowland
This extends' static assert to not require a message string. I elected to make this work also for C++11 and C++14 and warn only with -pedantic. I think many people just write static_assert(thing, ""); . I took the path of building an empty string in the parser in this case. I wasn't sure if s

  1   2   3   4   >