Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-23 Thread Martin Liška
from a good location. I'm going to improve it. Cheers, Martin Thanks for your help, Andre On Sat, 22 May 2021 19:58:57 +0200 Martin Liška wrote: On 5/22/21 1:39 PM, Andre Vehreschild via Gcc-patches wrote: Hi Steve and Jerry, thanks for the ok'ing.

Re: [PATCH] Optimize x < 0 ? ~y : y to (x >> 31) ^ y in match.pd

2021-05-23 Thread Martin Liška
Hello. Similarly to: https://gcc.gnu.org/pipermail/gcc-patches/2021-May/571039.html I've just reverted the ChangeLog commit change. I'm planning update of the documentation. Cheers, Martin

Re: [wwwdocs, patch] htdocs/gitwrite.html: Clarify ChangeLog generation

2021-05-24 Thread Martin Liška
On 5/23/21 2:37 PM, Tobias Burnus wrote: As there was some confusion regarding when the ChangeLog is generated, I propose the attached wwwdocs patch. Comments? I support the change. Moreover, I'm going to install the following patch that adds a note about ChangeLog entries. Martin (Side rem

Re: [PATCH] Add no_sanitize_coverage attribute.

2021-05-24 Thread Martin Liška
On 5/21/21 2:39 PM, Marco Elver wrote: On Fri, May 21, 2021 at 10:50AM +0200, Martin Liška wrote: On 5/20/21 12:55 PM, Marco Elver wrote: I think this came up with other no_sanitize [1] based on what I had written to you last year [2]. [1]https://gcc.gnu.org/pipermail/gcc-patches/2020-June

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-24 Thread Martin Liška
On 5/21/21 2:35 PM, David Edelsohn wrote: Please remember that not all targets support LTO so a fallback to a non-partial-LTO build needs to be provided and automatically invoked for those targets. Sure, for now it's definitely going to be a opt-in, enabled by something like: make PARTIAL_LTO=1

Re: [PATCH] lto-dump : Fix an ICE when lto-dump try to call 'get_size()' on thunk symbols.

2021-05-24 Thread Martin Liška
On 5/21/21 12:25 PM, 王留帅 via Gcc-patches wrote: |Hi, ​ We, ByteDance, have seen an ICE on trunk which can be reproduced with the following symbol testcase. The problem is caused by referencing a null pointer when applying 'n_basic_blocks_for_fn' on a thunk symbol. For the thunk symbol, 'DECL_S

Re: RFA: save/restore target options in handle_optimize_attribute

2021-05-24 Thread Martin Liška
On 5/20/21 9:55 AM, Richard Biener wrote: On Thu, May 20, 2021 at 12:29 AM Joern Wolfgang Rennecke wrote: We set default for some target options in TARGET_OPTION_OPTIMIZATION_TABLE, but these can be overridden by specifying the corresponding explicit -mXXX / -mno-XXX options. When a function b

Re: [PATCH] avoid -Wnonnull with lambda (PR 100684)

2021-05-24 Thread Martin Liška
On 5/20/21 10:03 AM, Richard Biener wrote: Martin - was this intended? Can you fix it up please? (g:cb50701ec2c7) It was not intentional. Fixed in the attached patch (where I did a refactoring as well). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be insta

[PATCH] DOC: update documentation of __gcov_{dump,reset}

2021-05-25 Thread Martin Liška
Hi. Based on the PR, I suggest improvement of the documentation for GCOV-related functions. I'll install the patch if there are no objections. Martin gcc/ChangeLog: PR gcov-profile/100751 * doc/gcov.texi: Document that __gcov_dump can be called just once and that __gco

Re: [PATCH][DOCS] Remove install-old.texi

2021-05-25 Thread Martin Liška
On 5/24/21 10:09 PM, Joseph Myers wrote: On Fri, 21 May 2021, Martin Liška wrote: CPUs: aarch64, alpha, alpha64, amdgcn, arc, arceb, arm, avr, bfin, bpf, cr16, cris, csky, epiphany, fido, fr30, frv, ft32, h8300, hppa, hppa2.0, hppa64, i486, i686, ia64, iq2000, lm32, m32c, m32r, m32rle, m68k

[PATCH] Fix sphinx-build warning.

2021-05-25 Thread Martin Liška
RemovedInSphinx40Warning: app.add_lexer() API changed; Please give lexer class instead of instance Ready for master? Thanks, Martin gcc/ada/ChangeLog: * doc/share/conf.py: Fix Sphinx 4.0.x error. --- gcc/ada/doc/share/conf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: RFA: save/restore target options in handle_optimize_attribute

2021-05-27 Thread Martin Liška
On 5/26/21 10:51 PM, Joseph Myers wrote: This commit breaks the build of glibc for powerpc64le-linux-gnu. Compile the following code with -O2 -mlong-double-128 -mabi=ibmlongdouble and I get the error opts-bug.c:8:1: error: '-mabi=ibmlongdouble' requires '-mlong-double-128' 8 | { | ^

Fallout: save/restore target options in handle_optimize_attribute

2021-05-28 Thread Martin Liška
Hi. There's a fallout after my revision ebd5e86c0f41dc1d692f9b2b68a510b1f6835a3e. I would like to analyze all case and discuss possible solution. To be honest it's a can of worms and reverting the commit is an option on the table. So the cases: 1) PR100759 - ppc64le $ cat pr.C #pragma GCC op

Re: [PATCH] Simplify option handling for -fsanitize-coverage

2021-05-31 Thread Martin Liška
PING^1 On 5/20/21 12:43 PM, Martin Liška wrote: The simplification patch improves option completion and handling of the option. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * common.opt: Use proper Enum

GCC documentation: porting to Sphinx

2021-05-31 Thread Martin Liška
Hello. I've made quite some progress with the porting of the documentation and I would like to present it to the community now: https://splichal.eu/scripts/sphinx/ Note the documentation is automatically ([1]) generated from texinfo with a GitHub workflow ([2]). It's built on the devel/sphinx G

Re: GCC documentation: porting to Sphinx

2021-06-01 Thread Martin Liška
On 5/31/21 5:49 PM, Michael Matz wrote: Hello Martin, On Mon, 31 May 2021, Martin Liška wrote: I've made quite some progress with the porting of the documentation and I would like to present it to the community now: https://splichal.eu/scripts/sphinx/ Note the documentati

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-06-01 Thread Martin Liška
PING^1 On 5/21/21 10:29 AM, Martin Liška wrote: On 5/20/21 5:55 PM, Jan Hubicka wrote: Quick solution is to also modify partitioner to use the local symbol names when doing incremental linking (those mixing in source code and random seeds) to avoid clashes. Good hint. I added hash based on

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-06-01 Thread Martin Liška
@Richi: Can you please reply to this email? On 5/21/21 10:43 AM, Martin Liška wrote: On 5/20/21 2:54 PM, Richard Biener wrote: On Thu, May 20, 2021 at 2:34 PM Martin Liška wrote: Hello. I've got a patch candidate that leverages partial linking for a couple of selected object files.

Re: Fallout: save/restore target options in handle_optimize_attribute

2021-06-01 Thread Martin Liška
On 5/28/21 2:46 PM, Richard Biener wrote: On Fri, May 28, 2021 at 11:48 AM Martin Liška wrote: Hi. There's a fallout after my revision ebd5e86c0f41dc1d692f9b2b68a510b1f6835a3e. I would like to analyze all case and discuss possible solution. To be honest it's a can of worms and

[PATCH][OBVIOUS] docs: Mention that -fgcse-after-reload is enabled with -O3.

2021-06-01 Thread Martin Liška
Pushed as obvious where I verified that it's really enabled with -O3. Martin gcc/ChangeLog: PR other/100826 * doc/invoke.texi: Mention that -fgcse-after-reload is enabled with -O3. --- gcc/doc/invoke.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-06-01 Thread Martin Liška
On 6/1/21 9:42 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:33 AM Martin Liška wrote: @Richi: Can you please reply to this email? Not sure what I should add here? Honza suggested to mangle the promoted symbol names. Sure and I sent a patch for that. I don't really like the

Re: Fallout: save/restore target options in handle_optimize_attribute

2021-06-01 Thread Martin Liška
On 6/1/21 3:11 PM, Richard Biener wrote: On Tue, Jun 1, 2021 at 1:17 PM Martin Liška wrote: On 5/28/21 2:46 PM, Richard Biener wrote: On Fri, May 28, 2021 at 11:48 AM Martin Liška wrote: Hi. There's a fallout after my revision ebd5e86c0f41dc1d692f9b2b68a510b1f6835a3e. I would li

Re: RFA: save/restore target options in handle_optimize_attribute

2021-06-01 Thread Martin Liška
On 5/19/21 11:48 PM, Joern Wolfgang Rennecke wrote: We set default for some target options in TARGET_OPTION_OPTIMIZATION_TABLE, but these can be overridden by specifying the corresponding explicit -mXXX / -mno-XXX options. When a function bears the attribue __attribute__ ((optimize("02"))) the ta

[PATCH] ARM: reset arm_fp16_format

2021-06-01 Thread Martin Liška
Hello. The patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98636#c20 where target option restore can be called and arm_fp16_format should be reset to ARM_FP16_FORMAT_NONE. It fixes the ICE in the PR. Can please ARM folks test me the patch on a Arm machine? Thanks, Martin gcc/ChangeLog

[PATCH] Introduce -Wcoverage-invalid-line-number

2021-06-01 Thread Martin Liška
Hello. As seen in the PR, one can easily corrupt line number information and we can end up with a function that ends before it starts ;) I'm adding a new warning for that instead of the ICE. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Ma

[PATCH] icf: Fix memory leak of a vector.

2021-06-01 Thread Martin Liška
Simple leak fix. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * ipa-icf.h: Use auto_vec for memory_access_types. --- gcc/ipa-icf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ipa

Re: GCC documentation: porting to Sphinx

2021-06-02 Thread Martin Liška
On 6/1/21 3:31 PM, Michael Matz wrote: Hello, On Tue, 1 Jun 2021, Martin Liška wrote: On 5/31/21 5:49 PM, Michael Matz wrote: Hello Martin, On Mon, 31 May 2021, Martin Liška wrote: I've made quite some progress with the porting of the documentation and I would like to present it t

Re: GCC documentation: porting to Sphinx

2021-06-03 Thread Martin Liška
On 6/2/21 10:41 PM, Martin Sebor wrote: On 5/31/21 7:25 AM, Martin Liška wrote: Hello. I've made quite some progress with the porting of the documentation and I would like to present it to the community now: https://splichal.eu/scripts/sphinx/ Hello. Thank you for the review. Just

Re: GCC documentation: porting to Sphinx

2021-06-03 Thread Martin Liška
On 6/2/21 6:44 PM, Joseph Myers wrote: On Wed, 2 Jun 2021, Joel Sherrill wrote: For RTEMS, we switched from texinfo to Sphinx and the dependency on Python3 for Sphinx has caused a bit of hassle. Is this going to be an issue for GCC? What Sphinx (and, thus, Python) versions does the GCC manual

Re: GCC documentation: porting to Sphinx

2021-06-04 Thread Martin Liška
On 6/3/21 7:16 PM, Joseph Myers wrote: On Thu, 3 Jun 2021, Martin Liška wrote: On 6/2/21 6:44 PM, Joseph Myers wrote: On Wed, 2 Jun 2021, Joel Sherrill wrote: For RTEMS, we switched from texinfo to Sphinx and the dependency on Python3 for Sphinx has caused a bit of hassle. Is this going to

[PATCH][OBVIOUS] docs: Add missing @headitem for tables.

2021-06-06 Thread Martin Liška
Quite some TEXI tables do miss table header. The patch adds that. Pushed to master as obvious. Martin gcc/ChangeLog: * doc/extend.texi: Add missing @headitem. * doc/invoke.texi: Likewise. * doc/objc.texi: Likewise. --- gcc/doc/extend.texi | 12 ++-- gcc/doc/inv

[PATCH][pushed] docs: remove extra character.

2021-06-06 Thread Martin Liška
Fix of a typo. Martin gcc/ChangeLog: * doc/invoke.texi: Remove extra character. --- gcc/doc/invoke.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index eb8142f596d..7102999cf31 100644 --- a/gcc/doc/invoke.texi +++ b/gc

[PATCH][pushed] genhooks: remove dead code

2021-06-06 Thread Martin Liška
Hello. We not longer use @Fcode in .def target hooks and I'm going to remove a dead code. Pushed to master. Martin gcc/ChangeLog: * genhooks.c (emit_findices): Remove unused function. (emit_documentation): Do not call emit_findices and do not search for @Fcode directive

[PATCH] Reformat target.def for better parsing.

2021-06-06 Thread Martin Liška
Hello. I'll need to parse output of tm.texi when converted to Sphinx for the future conversion. So that I split DEFHOOK documentation entries with newlines. I'll install the patch if there are no comments? Thanks, Martin gcc/c-family/ChangeLog: * c-target.def: Split long lines and repl

Re: [PATCH] Reformat target.def for better parsing.

2021-06-07 Thread Martin Liška
On 6/7/21 8:14 AM, Richard Biener wrote: Hmm, what's the problem with parsing the strings? The newlines are only because of our line length limits and hard-coding them looks both error-prone and ugly. For the future Sphinx conversion, I need to replace content of the hook definitions in .def

Re: RFC: Sphinx for GCC documentation

2021-06-07 Thread Martin Liška
On 6/4/21 9:55 AM, Tobias Burnus wrote: Hello, On 13.05.21 13:45, Martin Liška wrote: On 4/1/21 3:30 PM, Martin Liška wrote: That said, I'm asking the GCC community for a green light before I invest more time on it? So far, I've received just a small feedback about the transitio

Re: RFC: Sphinx for GCC documentation

2021-06-07 Thread Martin Liška
On 6/4/21 4:24 PM, Koning, Paul wrote: On Jun 4, 2021, at 3:55 AM, Tobias Burnus wrote: Hello, On 13.05.21 13:45, Martin Liška wrote: On 4/1/21 3:30 PM, Martin Liška wrote: That said, I'm asking the GCC community for a green light before I invest more time on it? So far, I'v

[PATCH][pushed] Fix "tailing" typo.

2021-06-08 Thread Martin Liška
Pushed as obvious typo fix. Martin gcc/fortran/ChangeLog: * intrinsic.texi: Fix typo. * trans-expr.c (gfc_trans_pointer_assignment): Likewise. gcc/ChangeLog: * genautomata.c (create_automata): Fix typo. libgfortran/ChangeLog: * intrinsics/chmod.c (chmod_inter

Re: RFC: Sphinx for GCC documentation

2021-06-08 Thread Martin Liška
On 6/7/21 11:26 PM, Bernhard Reutner-Fischer wrote: On Mon, 7 Jun 2021 15:30:22 +0200 Martin Liška wrote: Anyway, this is resolved as I use more appropriate directive: https://splichal.eu/scripts/sphinx/gfortran/_build/html/intrinsic-procedures/access-checks-file-access-modes.html ISTM

[PATCH] docs: document evrp-sparse-threshold param

2021-06-08 Thread Martin Liška
Pushed as obvious. Martin gcc/ChangeLog: * doc/invoke.texi: Document new param evrp-sparse-threshold. --- gcc/doc/invoke.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 04048cd8332..6063e466c13 100644 --- a/gcc/doc/invoke.texi

[PATCH][DOCS][pushed] Improve JSON examples.

2021-06-08 Thread Martin Liška
The patch improves JSON examples so that they are a valid JSON. That will help us with syntax highlighting in Sphinx-generated documentation. Pushed to master. Martin gcc/ChangeLog: * doc/gcov.texi: Create a proper JSON files. * doc/invoke.texi: Remove dots in order to make it a

[PATCH][pushed] docs: add missing @headitem in Intrinsic Procedures

2021-06-09 Thread Martin Liška
Pushed as obvious. Martin gcc/fortran/ChangeLog: * intrinsic.texi: Add missing @headitem to tables with a header. --- gcc/fortran/intrinsic.texi | 144 ++--- 1 file changed, 72 insertions(+), 72 deletions(-) diff --git a/gcc/fortran/intrinsic.texi b/gcc

Re: GCC documentation: porting to Sphinx

2021-06-10 Thread Martin Liška
On 6/4/21 5:10 PM, Martin Sebor wrote: On 6/3/21 4:56 AM, Martin Liška wrote: On 6/2/21 10:41 PM, Martin Sebor wrote: On 5/31/21 7:25 AM, Martin Liška wrote: Hello. I've made quite some progress with the porting of the documentation and I would like to present it to the community now:

Re: RFC: Sphinx for GCC documentation

2021-06-10 Thread Martin Liška
On 6/7/21 4:19 PM, Tobias Burnus wrote: On 07.06.21 15:28, Martin Liška wrote: * I note that we write before the argument index, that those are without -/-- prefix    but that's not true. Something to fix after the conversation. Can you please show me a few examples of it? *

Re: GCC documentation: porting to Sphinx

2021-06-10 Thread Martin Liška
On 6/10/21 11:07 AM, Martin Liška wrote: Doing that, one has 2 unique links, that would be needed for get_option_url  function. Plus, both :option:`-Wfoo` and :option:`-Wno-foo` references are going to work. And I've actually did the transformation and one can see it e.g. here:

Re: GCC documentation: porting to Sphinx

2021-06-10 Thread Martin Liška
On 6/2/21 7:27 PM, Joseph Myers wrote: On Mon, 31 May 2021, Martin Liška wrote: https://splichal.eu/scripts/sphinx/ Looking at some examples there: https://splichal.eu/scripts/sphinx/gcc/_build/html/c-implementation-defined-behavior/preprocessing-directives.html has some conversion problems

Re: [Patch] contrib/gcc-changelog: Check that PR in subject in in changelog

2021-06-10 Thread Martin Liška
On 6/10/21 4:07 PM, Tobias Burnus wrote: (Moved to gcc-patches, missed this when I replied to the initial email) Regarding patch at: https://gcc.gnu.org/pipermail/gcc/2021-June/236357.html On 10.06.21 14:45, Jonathan Wakely wrote: As well as the "contrig" typo that Florian noticed, the subjec

Re: [Patch] contrib/gcc-changelog: Check that PR in subject in in changelog

2021-06-10 Thread Martin Liška
On 6/10/21 4:42 PM, Tobias Burnus wrote: On 10.06.21 16:24, Martin Liška wrote: I'm sending a small update that handles some flake8 issues and as defined in setup.cfg, line limit for the file is 120 characters. Aha, the known issue that Ubuntu 20.04 has a too old flake8 such that I only

Re: [Patch] contrib/gcc-changelog: Check that PR in subject in in changelog

2021-06-11 Thread Martin Liška
On 6/10/21 5:32 PM, Tobias Burnus wrote: On 10.06.21 16:46, Martin Liška wrote: Note that flake8 has "plugins". At openSUSE, I install: ... None of those are available on Ubuntu – I probably should nag doko or start using my private computer for the tests ... I support the pat

Re: GCC documentation: porting to Sphinx

2021-06-11 Thread Martin Liška
On 6/10/21 6:49 PM, Joseph Myers wrote: On Thu, 10 Jun 2021, Martin Liška wrote: 1) Can we organize the new documentation in $gccroot/doc folder similarly to what I have in texi2rst-generated repo? Would be beneficial as we can have a single Makefile and shared content will be in a same depth

Re: GCC documentation: porting to Sphinx

2021-06-11 Thread Martin Liška
On 6/11/21 1:48 AM, Martin Sebor wrote: On 6/10/21 7:18 AM, Martin Liška wrote: On 6/10/21 11:07 AM, Martin Liška wrote: Doing that, one has 2 unique links, that would be needed for get_option_url  function. Plus, both :option:`-Wfoo` and :option:`-Wno-foo` references are going to work. And

[PATCH] gcov: make profile merging smarter

2021-10-01 Thread Martin Liška
Support merging of profiles that are built from a different .o files but belong to the same source file. Moreover, a checksum is verified during profile merging and so we can safely combine such profile. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I'm going to install t

Re: [PATCH] gcov: make profile merging smarter

2021-10-01 Thread Martin Liška
On 10/1/21 12:17, Richard Biener wrote: On Fri, Oct 1, 2021 at 11:55 AM Martin Liška wrote: Support merging of profiles that are built from a different .o files but belong to the same source file. Moreover, a checksum is verified during profile merging and so we can safely combine such

[PATCH][pushed] options: fix concat of options.

2021-10-01 Thread Martin Liška
It's quite an obvious error I made during concat of merged_decoded_options. make check -k RUNTESTFLAGS="i386.exp" works fine now. Martin PR target/102552 gcc/c-family/ChangeLog: * c-common.c (parse_optimize_options): decoded_options[0] is used for program name, so m

[PATCH][PUSHED] options: fix ASAN issue during saving of opt. options

2021-10-02 Thread Martin Liška
Fix an obvious issue when processing save_decoded_options. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Thanks, Martin gcc/ChangeLog: * toplev.c (toplev::main): save_decoded_options[0] is program name and so it should be skipped. --- gcc/toplev.c | 2

[PATCH][OBVIOUS] options: check for CL_OPTIMIZATION only for cl_options.

2021-10-03 Thread Martin Liška
One more obvious fix that unblocks ASAN bootstrap. Martin gcc/ChangeLog: * toplev.c (toplev::main): Check opt_index if it is a part of cl_options. --- gcc/toplev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/toplev.c b/gcc/toplev.c index d952319ad9

[PATCH] debug: Handle x_flag_var_tracking_* in finish_options [PR102585]

2021-10-04 Thread Martin Liška
Hello. The patch sets -1 for x_flag_var_tracking and x_flag_var_tracking_assignments similarly to toplev.c. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR debug/102585 gcc/ChangeLog: * opts.c (finish_options):

Re: [PATCH 3/N] Come up with casm global state.

2021-10-04 Thread Martin Liška
On 9/22/21 11:59, Richard Biener wrote: On Thu, Sep 16, 2021 at 3:12 PM Martin Liška wrote: This patch comes up with asm_out_state and a new global variable casm. Tested on all cross compilers. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed

Re: [PATCH 3/N] Come up with casm global state.

2021-10-04 Thread Martin Liška
On 9/16/21 15:12, Martin Liška wrote: This patch comes up with asm_out_state and a new global variable casm. Tested on all cross compilers. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin As explained in the '3/N' par

Re: [PATCH] gcov: make profile merging smarter

2021-10-04 Thread Martin Liška
On 10/4/21 13:16, Richard Biener wrote: I meant in merge_one_data do not check ->stamp or ->checksum but instead rely on the counter merging code to detect mismatches (there's read_mismatch and read_error). There's multiple things we can do when we run into those: - when we did not actually m

Re: [PATCH] debug: Handle x_flag_var_tracking_* in finish_options [PR102585]

2021-10-04 Thread Martin Liška
On 10/4/21 13:45, Jakub Jelinek wrote: On Mon, Oct 04, 2021 at 01:41:36PM +0200, Richard Biener via Gcc-patches wrote: The patch sets -1 for x_flag_var_tracking and x_flag_var_tracking_assignments similarly to toplev.c. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. S

[PATCH][i386] target: support spaces in target attribute.

2021-10-04 Thread Martin Liška
Hello. The patch is about supporting target attribute values like "no-avx, sse2 ". I'm planning doing the same change for aarch64 and other archs as well once this one is accepted. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-07 Thread Martin Liška
On 10/5/21 20:44, Jason Merrill wrote: That is the usual approach, yes.  I was giving up on that, but perhaps it's better to stick with it.  Martin, want to make that fix for save_opt_decoded_options? Yes, I'm going to install the following patch once it survives regression tests and bootstra

Re: [PATCH] Enable auto-vectorization at O2 with very-cheap cost model.

2021-10-07 Thread Martin Liška
Hello. The patch is approved, are you planning committing the changes? Thanks, Martin

[PATCH] options: use cl_optimization_hash.

2021-10-08 Thread Martin Liška
Hello. Right now, we use legacy hashing function in cl_option_hasher and I also need the change for the future fix of PR102585. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * tree.c (cl_option_hasher::hash)

[PATCH] contrib: git gcc-descr defaulting to print hash

2021-10-08 Thread Martin Liška
Hello. I'm sending a patch originally written by Martin Jambor. The patch changes the behavior in the following way: $ git gcc-descr HEAD~ r12-4245-gdb3d7270b42fe2 $ git gcc-descr --short HEAD~ r12-4245 $ git gcc-undescr r12-4245-gdb3d7270b42fe2 db3d7270b42fe27fb05664c4fdf524ab7ad13a75 whi

[PATCH] Come up with OPTION_SET_P macro.

2021-10-08 Thread Martin Liška
Hello. It's a refactoring patch introducing a new macro. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I verified all cross compilers do build. Ready to be installed? Thanks, Martin gcc/ada/ChangeLog: * gcc-interface/misc.c (gnat_post_options): Use new macro

[PATCH][pushed] opts: include missing header files.

2021-10-08 Thread Martin Liška
gcc/objc/ChangeLog: * objc-next-runtime-abi-01.c: Add missing include. * objc-next-runtime-abi-02.c: Likewise. --- gcc/objc/objc-next-runtime-abi-01.c | 1 + gcc/objc/objc-next-runtime-abi-02.c | 1 + 2 files changed, 2 insertions(+) diff --git a/gcc/objc/objc-next-runtime-abi-0

Re: [PATCH] options: use cl_optimization_hash.

2021-10-11 Thread Martin Liška
On 10/8/21 12:23, Martin Liška wrote: Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I've spoken to Honza and he approves the patch. I'm going to install it. Martin

[PATCH] opts: Remove AUTODETECT_VALUE usage.

2021-10-11 Thread Martin Liška
The patch is about using OPTION_SET_P instead of a default option value set in common.opt. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * common.opt: Remove Init(2) for some options. * toplev.c (proc

[PATCH] Remove usage of IRA_REGION_AUTODETECT

2021-10-11 Thread Martin Liška
Similar patch, let's rely on OPTION_SET_P and not a default options value. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * common.opt: Remove usage of IRA_REGION_AUTODETECT. * flag-types.h (enum ira_r

[PATCH] options: Fix variable tracking option processing.

2021-10-11 Thread Martin Liška
After the recent change in Optimize attribute handling, we need finish_option function properly auto-detecting variable tracking options. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR debug/102585 gcc/ChangeLog:

Re: [PATCH][i386] target: support spaces in target attribute.

2021-10-11 Thread Martin Liška
On 10/4/21 23:02, Andrew Pinski wrote: It might be useful to skip tabs for the same reason as spaces really. Sure, be my guest. MartinFrom b66d7be2c1b3ac286257e3df4d9796e391751bef Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 4 Oct 2021 14:06:14 +0200 Subject: [PATCH] target: support

[RFC] Port git gcc-descr to Python

2021-10-11 Thread Martin Liška
On 10/8/21 13:12, Jakub Jelinek wrote: I think changing the default is ok, but dropping --full is not, it should stay and behave the way it did before (i.e. print r12-4245-gdb3d7270b42fe27fb05664c4fdf524ab7ad13a75 same thing as the new default except for full hash instead of first 14 chars from i

Re: [PATCH] options: Fix variable tracking option processing.

2021-10-11 Thread Martin Liška
On 10/11/21 15:05, Richard Biener wrote: + if (!opts_set->x_flag_var_tracking) +opts->x_flag_var_tracking = optimize >= 1; That's still not equivalent to the old code for -fvar-tracking-uninit which sets opts->x_flag_var_tracking to 1 and the old code checked that for AUTOINIT_VALUE but you

Re: [PATCH] gcov: make profile merging smarter

2021-10-11 Thread Martin Liška
On 10/5/21 12:04, Richard Biener wrote: On Mon, Oct 4, 2021 at 1:32 PM Martin Liška wrote: On 10/4/21 13:16, Richard Biener wrote: I meant in merge_one_data do not check ->stamp or ->checksum but instead rely on the counter merging code to detect mismatches (there's read_m

Re: [PATCH] gcov: make profile merging smarter

2021-10-11 Thread Martin Liška
On 10/11/21 15:49, Martin Liška wrote: Let me update the documentation bits. There's the updated patch. May I install the patch now? Thanks, MartinFrom fdeb81a960faa19f75316e279a79c231da212f99 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 9 Sep 2021 13:02:24 +0200 Subject: [

Re: [RFC] Port git gcc-descr to Python

2021-10-12 Thread Martin Liška
Hello. There's a complete patch that implements both git gcc-descr and gcc-undesrc and sets corresponding git aliases to use them. Ready to be installed? Thanks, MartinFrom bf46024d03d00edf09d804449acbc5ff17690127 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 11 Oct 2021 14:36:19 +0200

[PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Martin Liška
Hello. The option is disabled in rs6000 target with: { OPT_LEVELS_ALL, OPT_frename_registers, NULL, 0 }, Thus, we have to do an auto-detection only if it's really unset and also equal to the Init value. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. And the problema

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Martin Liška
On 10/12/21 15:37, Richard Biener wrote: On Tue, Oct 12, 2021 at 2:18 PM Martin Liška wrote: Hello. The option is disabled in rs6000 target with: { OPT_LEVELS_ALL, OPT_frename_registers, NULL, 0 }, Thus, we have to do an auto-detection only if it's really unset and also equal t

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Martin Liška
On 10/12/21 15:37, Richard Biener wrote: by adding EnabledBy(funroll-loops) to the respective options instead (and funroll-loops EnabledBy(funroll-all-loops)) All right, so the suggested approach works correctly. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to

Re: [PATCH] options: Fix variable tracking option processing.

2021-10-12 Thread Martin Liška
On 10/11/21 15:45, Richard Biener wrote: Btw, I'd be more comfortable when the move of the code would be independent of the adjustment to not rely on AUTODETECT_VALUE. Can we do the latter change first (IIRC the former one failed already)? All right, so I'm doing the first step by eliminating A

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-13 Thread Martin Liška
On 10/13/21 10:39, Richard Biener wrote: On Tue, Oct 12, 2021 at 5:11 PM Martin Liška wrote: On 10/12/21 15:37, Richard Biener wrote: by adding EnabledBy(funroll-loops) to the respective options instead (and funroll-loops EnabledBy(funroll-all-loops)) All right, so the suggested approach

Re: [PATCH] options: Fix variable tracking option processing.

2021-10-13 Thread Martin Liška
On 10/13/21 10:47, Richard Biener wrote: Let's split this;) The debug_inline_points part is OK. Fine. How can debug_variable_location_views be ever -1? But the debug_variable_location_views part looks OK as well. It comes from here: gvariable-location-views=incompat5 Common Driver Rejec

Re: [PATCH] options: Fix variable tracking option processing.

2021-10-13 Thread Martin Liška
On 10/13/21 14:50, Richard Biener wrote: It does, yes. But that's a ^ with flag_var_tracking_assignments_toggle;) It's also one of the more weird flags, so it could be applied after the otherwise single set of flag_var_tracking_assignments ... Well, it's far from being simple. Can we please m

Re: [PATCH] gcov: make profile merging smarter

2021-10-13 Thread Martin Liška
On 10/11/21 16:05, Martin Liška wrote: May I install the patch now? Pushed to master, I guess we can tweak documentation in the future if needed. Martin

[PATCH] rs6000: Remove unnecessary option manipulation.

2021-10-14 Thread Martin Liška
Hello. There's follow up flag handling simplification based on 4ab51fa0e1705201420d87b601bd92bc643b3d52. Patch can bootstrap on ppc64le-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/rs6000/rs6000.c (rs6000_override_options_after

Re: [PATCH] options: Fix variable tracking option processing.

2021-10-14 Thread Martin Liška
On 10/13/21 15:29, Richard Biener wrote: On Wed, Oct 13, 2021 at 3:12 PM Martin Liška wrote: On 10/13/21 14:50, Richard Biener wrote: It does, yes. But that's a ^ with flag_var_tracking_assignments_toggle;) It's also one of the more weird flags, so it could be applied after the

Re: [PATCH] Add forgotten documentation of param ipa-cp-recursive-freq-factor

2021-10-14 Thread Martin Liška
On 10/14/21 15:03, Martin Jambor wrote: |OK for trunk?| Please push it as obvious. Martin

Re: [r12-4397 Regression] FAIL: gcc.dg/guality/pr54200.c -Og -DPREVENT_OPTIMIZATION line 20 z == 3 on Linux/x86_64

2021-10-15 Thread Martin Liška
On 10/14/21 21:16, sunil.k.pandey wrote: FAIL: gcc.dg/guality/pr54200.c -Og -DPREVENT_OPTIMIZATION line 20 z == 3 Hello. I've just verified the assembly is identical before and after the revision. So it must be a false positive. Cheers, Martin

Re: [PATCH] options: Fix variable tracking option processing.

2021-10-15 Thread Martin Liška
All right, and there's second part that moves the code from toplev.c to opts.c (finish_options) as I've done in the original version. The patch also handles PR102766 where nvptx.c target sets: debug_nonbind_markers_p = 0; So the easiest approach is marking the flag as set in global_options_set,

Re: [PATCH] rs6000: Remove unnecessary option manipulation.

2021-10-15 Thread Martin Liška
On 10/14/21 17:10, Bill Schmidt via Gcc-patches wrote: Looks like you got your parentheses wrong here. Whoops, thanks for the heads up. I'm testing this fixed version. P.S. Next time, please CC me. Thanks, MartinFrom cd9891ec3eed3a5b289b7c556598606d21e48206 Mon Sep 17 00:00:00 2001 From: Mar

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-15 Thread Martin Liška
On 10/14/21 16:27, Jeff Law wrote: So what's the preferred way to handle this?  We're in the process of evaluating -frename-registers on our target right now and subject to verification of a couple issues, our inclination is to turn it on for our target at -O2. Jeff I think the best approach

[PATCH][PUSHED] Remove unused but set variables.

2021-10-18 Thread Martin Liška
Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Pushed to master as obvious. Reported by clang13 -Wunused-but-set-variable: gcc/ChangeLog: * dbgcnt.c (dbg_cnt_process_opt): Remove unused but set variable. * gcov.c (get_cycles_count): Likewise. * l

[PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS.

2021-10-18 Thread Martin Liška
The macros correspond 1:1 to an option flags and make it harder to find all usages of the flags. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/c-family/ChangeLog: * c-gimplify.c (genericize_c_loop): Use option directly.

Re: [RFC] Port git gcc-descr to Python

2021-10-18 Thread Martin Liška
On 10/12/21 10:59, Martin Liška wrote: Hello. There's a complete patch that implements both git gcc-descr and gcc-undesrc and sets corresponding git aliases to use them. Ready to be installed? Thanks, Martin All right, so Jakub told me at IRC that we doesn't support porting

[PATCH][PUSHED] gcc-changelog: update error message location

2021-10-18 Thread Martin Liška
Hello. The patch improves location information for 'bad parentheses wrapping'. Pushed to master. Martin contrib/ChangeLog: * gcc-changelog/git_commit.py: Update location of 'bad parentheses wrapping'. * gcc-changelog/test_email.py: Test it. --- contrib/gcc-changelog/gi

[PATCH] gcov: return proper exit code when error happens

2021-10-18 Thread Martin Liška
Hello. The patch records error codes when something serious happens during emission of GCOV reports. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I'm going to push the change. Thanks, Martin PR gcov-profile/102746 PR gcov-profile/102747 gcc/ChangeLog

Re: [PATCH][i386] target: support spaces in target attribute.

2021-10-18 Thread Martin Liška
On 10/11/21 13:17, Martin Liška wrote: On 10/4/21 23:02, Andrew Pinski wrote: It might be useful to skip tabs for the same reason as spaces really. Sure, be my guest. Martin May I please ping this i386-specific patch? Thanks, Martin

Re: [PATCH][i386] target: support spaces in target attribute.

2021-10-18 Thread Martin Liška
On 10/18/21 17:12, Uros Bizjak wrote: On Mon, Oct 18, 2021 at 1:23 PM Martin Liška wrote: On 10/11/21 13:17, Martin Liška wrote: On 10/4/21 23:02, Andrew Pinski wrote: It might be useful to skip tabs for the same reason as spaces really. Sure, be my guest. Martin May I please ping this

<    7   8   9   10   11   12   13   14   15   16   >