latov
wrote:
> Hello
>
> This change allows to complete profiledbootstrap on the google gcc-4.8
> branch, tested with make bootstrap with no new regressions. OK for
> google 4.8?
> thanks, Dinar.
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
).
Ok for trunk?
(I also included the patch as an attachment since my mailer invariably
messes up the formatting in the pasted version.)
Thanks,
Teresa
2013-08-01 Teresa Johnson
Steven Bosscher
* cfgrtl.c (fixup_bb_partition): New routine
On Fri, Aug 2, 2013 at 4:22 AM, Bernhard Reutner-Fischer
wrote:
> On 1 August 2013 18:32, Teresa Johnson wrote:
>> Patch 3 of 3 split out from the patch I sent in May that fixes problems with
>> -freorder-blocks-and-partition, with changes/fixes discussed in that thread.
On Fri, Aug 2, 2013 at 8:05 AM, Jan Hubicka wrote:
>>
>> 2013-08-01 Teresa Johnson
>> Steven Bosscher
>>
>> * cfgrtl.c (fixup_bb_partition): New routine.
>> (commit_edge_insertions): Invoke fixup_partitions.
>>
he
> hottest path from the entry block to a hot basic block is always part
> of the hot partition.
Well, at least with this patch that will be true. The trunk version
just partitions based on the bb's count without regard to paths.
Thanks,
Teresa
>
>
>> I also wonder, if we
On Fri, Aug 2, 2013 at 9:48 PM, Teresa Johnson wrote:
> On Fri, Aug 2, 2013 at 8:05 AM, Jan Hubicka wrote:
>>>
>>> 2013-08-01 Teresa Johnson
>>> Steven Bosscher
>>>
>>> * cfgrtl.c (fixup_bb_partition): New routi
an be dealt with incrementally.
I am going to fix this and will resend the patch. Rather than look at
the immediate dominator of each hot block, we need to ensure that at
least one pred bb is hot. In your example, if that was a 50-50 branch,
then IMO both preds should be marked hot.
Thanks,
Teresa
>
> Honza
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
On Mon, Aug 5, 2013 at 7:57 AM, Teresa Johnson wrote:
> On Mon, Aug 5, 2013 at 7:11 AM, Jan Hubicka wrote:
>> The patch looks OK to me in general (I can not approve it).
>> Still have one question...
>>> +
>>> +/* Ensure that no cold bbs dominate hot bbs al
This doesn't mean that the list of
optgroups shouldn't be expanded, but rather adds a catch-all for
passes that don't currently have or need to be emitted on their own
as part of a new optgroup.
Bootstrapped and tested on x86-64-unknown-linux-gnu.
Ok for trunk?
Thanks,
Teresa
2
On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote:
> Hi,
>
> On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote:
>> This patch ports messages to the new dump framework,
>
> It would be great this new framework was documented somewhere. I lost
> track of wha
On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote:
> Hi,
>
> On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote:
>> On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote:
>> > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote:
>> >>
On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote:
> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote:
>> Hi,
>>
>> On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote:
>>> On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote:
>>> >
and marked hot, and the current patch forces the most
frequent paths to all hot blocks to be hot.
Thanks,
Teresa
> I think we are really looking primarily for dead parts of the functions
> (sanity checks/error handling)
> that should not be visited by train run. We can then see how to make the
> heuristic more aggressive?
>
> Honza
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
or this to tell me which split cold bbs are being executed I
need to use a patch that Sri sent for review several months back that
gives the split cold section its own name:
http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01571.html
Steven had some follow up comments that Sri hasn't had a
c.gnu.org/ml/gcc-patches/2013-04/msg01571.html
>>> Steven had some follow up comments that Sri hasn't had a chance to address
>>> yet:
>>> http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00798.html
>>> (cc'ing Sri as we should probably revive this patch
't had a chance to address
>> yet:
>> http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00798.html
>> (cc'ing Sri as we should probably revive this patch soon to address
>> gdb and other issues with detecting split functions properly)
>
> Intrestin
l/gcc-patches/2013-05/msg00798.html
>> >> (cc'ing Sri as we should probably revive this patch soon to address
>> >> gdb and other issues with detecting split functions properly)
>> >
>> > Intresting, I used linker script for this purposes, but that his GNU ld
>
. With this patch,
a profilebootstrap with -freorder-blocks-and-partition force-enabled
also passes. Ok for trunk?
Thanks,
Teresa
2013-08-11 Teresa Johnson
PR rtl-optimizations/57451
* final.c (reemit_insn_block_notes): Prevent lexical blocks
from crossing split section
On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson wrote:
> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote:
>> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote:
>>> Hi,
>>>
>>> On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote:
>>
On Fri, Aug 9, 2013 at 2:02 PM, Teresa Johnson wrote:
> On Fri, Aug 9, 2013 at 8:28 AM, Jan Hubicka wrote:
>>> > Do we sanity check that the cold partition does not contain any blocks of
>>> > count 0? It may be that the profile is broken enough to make partitioning
other bigger app, like GCC itself. With profiledbootstrap
> and linker script to lock unlikely section you should get ICEs where
> we jump into cold secton and should not.
Ok, please point me to the linker script and I will try gcc
profiledbootstrap as well. I wanted to try gimp if possible as I
ha
On Sat, Aug 17, 2013 at 1:44 PM, Jan Hubicka wrote:
>>
>> patch for updating counts based on estimated frequencies to address
>> inlined comdats with 0 profile counts:
>>
>> 013-08-16 Teresa Johnson
>>
>> * tree-inline.c (
layout issues
Ok. I am using linux perf to collect this info (fed through some
scripts that munge and plot the data).
>
> It may be interesting to get similar script taking traces from valgrind
> and ploting the most frequent calls in the final layout ;)
I think linux perf -g to
Ping.
Thanks,
Teresa
On Mon, Aug 12, 2013 at 6:54 AM, Teresa Johnson wrote:
> On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson wrote:
>> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote:
>>> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote:
>>>> Hi,
>&g
Ping.
Thanks,
Teresa
On Sun, Aug 11, 2013 at 9:35 PM, Teresa Johnson wrote:
> This patch fixes PR rtl-optimizations/57451 by preventing scopes and
> therefore lexical blocks from crossing split section boundaries.
> This will prevent debug info generation from using DW_AT_low_pc/high_p
On Mon, Aug 19, 2013 at 11:44 AM, Jeff Law wrote:
> On 08/19/2013 12:34 PM, Teresa Johnson wrote:
>>
>> Ping.
>> Thanks,
>> Teresa
>>
>> On Sun, Aug 11, 2013 at 9:35 PM, Teresa Johnson
>> wrote:
>>>
>>> This patch fixes PR rtl-opt
tests and internal test. Ok for google branches?
2013-02-27 Teresa Johnson
* libgcc/libgcov.c (gcov_dump_module_info): Seek to zero
word using new end of file relative seek.
(gcov_merge_gcda_file): Make eof_pos local.
(gcov_write_gcda_file): Pass new argument to
Patch updated based on comments. Added new gcov_seek_from_end method.
Passes regression tests and internal benchmark test.
Ok for google branches?
Thanks,
Teresa
2013-02-27 Teresa Johnson
* gcc/coverage.c (build_info_type): Remove eof_pos from gcov_info.
(build_info): Ditto
and tested on x86-64-unknown-linux-gnu. Ok for trunk?
2013-03-27 Teresa Johnson
* ipa-cp.c (update_profiling_info): Perform rounding integer
division when updating weights instead of truncating.
(update_specialized_profile): Ditto.
Index: ipa-cp.c
Ping. Thanks, Teresa
On Fri, Dec 14, 2012 at 6:11 PM, Teresa Johnson wrote:
> This patch enables the gcov-dump tool to optionally compute and dump
> the working set information from the counter histogram, via a new -w option.
> This is useful to help understand and tune how the compiler
gt;},
> ! NULL,/* generate_summary */
> ! NULL,/* write_summary */
> ! NULL, /* read_summary */
>NULL,/* write_optimization_summary
> */
>NULL,/* read_optimization_summary
> */
>NULL,/* stmt_fixup */
> --- 1382,1390
> 0, /* todo_flags_start */
> 0 /* todo_flags_finish */
>},
> ! ipa_profile_generate_summary,/* generate_summary */
> ! ipa_profile_write_summary, /* write_summary */
> ! ipa_profile_read_summary,/* read_summary */
>NULL,/* write_optimization_summary
> */
>NULL,/* read_optimization_summary
> */
>NULL,/* stmt_fixup */
> Index: Makefile.in
> ===
> *** Makefile.in (revision 197205)
> --- Makefile.in (working copy)
> *** varpool.o : varpool.c $(CONFIG_H) $(SYST
> *** 2893,2899
> $(TREE_FLOW_H)
> ipa.o : ipa.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(CGRAPH_H) \
> $(TREE_PASS_H) $(GIMPLE_H) $(TARGET_H) $(GGC_H) pointer-set.h \
> !$(IPA_UTILS_H)
> ipa-prop.o : ipa-prop.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \
> langhooks.h $(GGC_H) $(TARGET_H) $(CGRAPH_H) $(IPA_PROP_H)
> $(DIAGNOSTIC_H) \
> $(TREE_FLOW_H) $(TM_H) $(TREE_PASS_H) $(FLAGS_H) $(TREE_H) \
> --- 2893,2900
> $(TREE_FLOW_H)
> ipa.o : ipa.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(CGRAPH_H) \
> $(TREE_PASS_H) $(GIMPLE_H) $(TARGET_H) $(GGC_H) pointer-set.h \
> !$(IPA_UTILS_H) tree-inline.h $(HASH_TABLE_H) profile.h $(PARAMS_H) \
> !$(LTO_STREAMER_H) $(DATA_STREAMER_H)
> ipa-prop.o : ipa-prop.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \
> langhooks.h $(GGC_H) $(TARGET_H) $(CGRAPH_H) $(IPA_PROP_H)
> $(DIAGNOSTIC_H) \
> $(TREE_FLOW_H) $(TM_H) $(TREE_PASS_H) $(FLAGS_H) $(TREE_H) \
> Index: lto-streamer.h
> ===
> *** lto-streamer.h (revision 197203)
> --- lto-streamer.h (working copy)
> *** enum lto_section_type
> *** 243,248
> --- 243,249
> LTO_section_jump_functions,
> LTO_section_ipa_pure_const,
> LTO_section_ipa_reference,
> + LTO_section_ipa_profile,
> LTO_section_symtab_nodes,
> LTO_section_opts,
> LTO_section_cgraph_opt_sum,
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
?
2013-03-30 Teresa Johnson
* tree-profile.c (tree_profiling): Optionally call
new function emit_function_name.
* common.opt (flag_emit_function_names): New flag.
* coverage.c (emit_function_name): New function.
* coverage.h: Ditto.
Index: tree-profile.c
on C++ member variables.
Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
2013-03-30 Teresa Johnson
* c-family/c-common.c (handle_unused_attribute): Handle
FIELD_DECL for C++ class members.
Index: c-family/c-com
On Sun, Mar 31, 2013 at 1:36 AM, Andrew Pinski wrote:
> On Sun, Mar 31, 2013 at 12:10 AM, Teresa Johnson wrote:
>> This patch allows the unused attribute to be used without warning
>> on C++ class members, which are of type FIELD_DECL. This is for
>> compatibility with cl
On Wed, Apr 3, 2013 at 10:52 AM, Jan Hubicka wrote:
>> >
>> > 2012-12-14 Teresa Johnson
>> >
>> > * lto-cgraph.c (input_symtab): Replace call to compute_working_sets
>> > to get_working_sets.
>> > * gcov-
On Mon, Apr 1, 2013 at 2:27 PM, Rong Xu wrote:
>
>
>
> On Fri, Mar 29, 2013 at 1:06 PM, Teresa Johnson
> wrote:
>>
>> On Fri, Mar 29, 2013 at 11:16 AM, Jan Hubicka wrote:
>> > Hi,
>> > currently we use Theresa's code to determine hot/cold decis
On Thu, Mar 28, 2013 at 2:27 AM, Richard Biener
wrote:
> On Wed, Mar 27, 2013 at 6:22 PM, Teresa Johnson wrote:
>> I found that the node weight updates on cloned nodes during ipa-cp were
>> leading to incorrect/insane weights. Both the original and new node weight
>> computa
Ping.
Thanks, Teresa
On Sun, Mar 31, 2013 at 9:39 AM, Teresa Johnson wrote:
> On Sun, Mar 31, 2013 at 1:36 AM, Andrew Pinski wrote:
>> On Sun, Mar 31, 2013 at 12:10 AM, Teresa Johnson
>> wrote:
>>> This patch allows the unused attribute to be used without warning
these cases. The documentation at
http://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html also doesn't
seem to preclude its use on C++ member variables.
Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for google branches?
2013-04-09 Teresa Johnson
* c-family/c-com
Patch to add interface for querying the profile directory prefix
specified to the -fprofile-generate= option.
Google ref b/8629045.
Tested with regression tests and internal test. Ok for google branches?
2013-04-17 Teresa Johnson
* libgcc/libgcov.c (__gcov_get_profile_prefix): New
continue;
> + decl = get_function_decl_from_block (block);
>loc = BLOCK_SOURCE_LOCATION (block);
Do you want to move up the assignment to loc and use loc in the new if
statement?
>pos_stack[idx].file = expand_location (loc).file;
>pos_stack[idx].line = expand_locat
c) == UNKNOWN_LOCATION)
> continue;
> - loc = BLOCK_SOURCE_LOCATION (block);
> + decl = get_function_decl_from_block (block);
>pos_stack[idx].file = expand_location (loc).file;
>pos_stack[idx].line = expand_location (loc).line;
>pos_stack[idx - 1].func =
>
> On S
. So far I haven't seen any performance effects, so I am
hoping to send this for review today or tomorrow.
Thanks,
Teresa
On Mon, Apr 22, 2013 at 10:27 AM, Jan Hubicka wrote:
>> On Wed, Mar 27, 2013 at 6:22 PM, Teresa Johnson wrote:
>> > I found that the node weight updates on
p://gcc.gnu.org/ml/gcc-patches/2012-11/msg01303.html
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02141.html (most recent
version of patch).
Teresa
>
> Jakub
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
les, so there would
>> be a large loss of precision when merging, since the range of counter
>> values sharing a single histogram is larger at the high end of the
>> histogram. I'll experiment with increasing the size of the histogram
>> to see how much that would reduce the error.
>
> Thanks! I guess increasing histogram to size matching approximately the
> number of counters in the binary should more or less eliminate the precision
> errors.
>
> Honza
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
looking at the patch - could you upload it it make it easier
for me to add comments?
Thanks,
Teresa
>
> Thanks
> Sri
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
On Wed, Apr 24, 2013 at 6:37 AM, Teresa Johnson wrote:
> On Mon, Apr 22, 2013 at 11:16 AM, Jan Hubicka wrote:
>> Hi,
>> sorry for getting back to this late.
>>> >> That's a larger error than I had expected from the merging, although
>>> >> as yo
gt; --- gcc/testsuite/g++.dg/tree-prof/func_reorder_gold_plugin_6.C (revision 0)
> +++ gcc/testsuite/g++.dg/tree-prof/func_reorder_gold_plugin_6.C (revision 0)
> @@ -0,0 +1,53 @@
> +/* Check if use_maxcount works as expected. This makes the node
> pro
Fixed a place where the wrong dump file was being used, leading to
an inconsistency and seg fault when dump_file was non-NULL but
cgraph_dump_file was NULL.
Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
Thanks,
Teresa
2014-05-09 Teresa Johnson
* cgraphunit.c
I discovered that the support for the documented -fdump-* options
"optimized", "missed", "note" and "optall" was missing. Added that and
fixed a minor typo in the documentation.
Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
Th
asses regression tests. Ok for google branches?
Thanks,
Teresa
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
Patch to add support for user-guided feedback-directed library optimization.
Contains support for builtins and attributes for specifying user-supplied
routine
Thanks for catching that, I will fix it.
Teresa
On Fri, May 9, 2014 at 7:49 PM, Andi Kleen wrote:
> Teresa Johnson writes:
>>
>> Passes regression tests. Ok for google branches?
>
> +{
> + char parameter[1000];
> + sprintf (parameter, "%s=%
On Tue, May 13, 2014 at 1:39 AM, Richard Biener
wrote:
> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson wrote:
>> I discovered that the support for the documented -fdump-* options
>> "optimized", "missed", "note" and "optall" was missing. Ad
irected value profiling will also be supported but not in this patch.
>
> David
>
> On May 10, 2014 2:59 PM, "Andi Kleen" wrote:
>>
>> On Fri, May 09, 2014 at 08:11:40PM -0700, Teresa Johnson wrote:
>> > Thanks for catching that, I will fix it.
>>
>&
Ping.
Teresa
On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson wrote:
> This patch applies profile fixups to COMDATs on the dyn ipa callgraph
> at the end of LIPO module grouping (either in the profile gen run or
> in gcov-tool). This is to address issues with missing profiles in the
>
May 19, 2014 at 10:08 PM, Teresa Johnson wrote:
>> Ping.
>> Teresa
>>
>> On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson wrote:
>>> This patch applies profile fixups to COMDATs on the dyn ipa callgraph
>>> at the end of LIPO module grouping (either in the pr
On Tue, May 20, 2014 at 8:39 AM, Xinliang David Li wrote:
> On Tue, May 20, 2014 at 6:32 AM, Teresa Johnson wrote:
>> On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li
>> wrote:
>>> Why duplicating the merger functions in dyn-ipa.c? Should those in
>>> lib
probably ought to
>> > map
>> > it to fatal_error in GCC binary.
>> >
>> > thanks,
>> > Honza
>>
>> Ok, here is the new patch. Bootstrapped and tested on
>> x86_64-unknown-linux-gnu. Ok for trunk?
>>
>> Thanks, Teresa
ks,
Teresa
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
Support for embedding arbitrary build information from the profile-generate
compile into the gcda file in a new BUILD_INFO record. Lines from a file
passed to the -fprofile-generate compile via a new
-fprofil
gt;
> struct gcov_info {
>...
> char ** build_info;
> };
>
> For regular case, it is null, for case where the build info is
> available, make it point to a string array (with an null end marker
> string).
>
> David
>
>
>
>
>
> On Fri, May 23, 2014
ldinfo)
> +read_buildinfo ();
>
>
> Why building it in init, not finalize routine as the rest of the gcov info?
Not sure what the issue is? We are just reading in the file here.
Teresa
>
>
> David
>
> On Fri, May 23, 2014 at 1:59 PM, Teresa Johnson wrote:
>> Do
On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson wrote:
> On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote:
>> On 03/26/14 17:44, Teresa Johnson wrote:
>>>
>>> Recently I discovered that the profile updates being performed by jump
>>> threading were incorrec
had a null result_vdef.
Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk?
2014-01-15 Teresa Johnson
* tree-ssa-sccvn.c (visit_reference_op_call): Handle NULL vdef.
Index: tree-ssa-sccvn.c
===
--- tre
Regression tested, ok for google/4_8?
Thanks,
Teresa
2014-01-15 Teresa Johnson
* loop-unroll.c (code_size_limit_factor): Handle int overflow.
Index: loop-unroll.c
===
--- loop-unroll.c (revision 206601)
+++ loop
On Wed, Jan 15, 2014 at 10:46 AM, Jeff Law wrote:
> On 01/15/14 10:07, Teresa Johnson wrote:
>>
>> Handle NULL vdef for call in the case where we have a matching vnresult
>> that has a vdef (it already handles the NULL vdef case when !vnresult).
>> This
>> can h
On Wed, Jan 15, 2014 at 12:00 PM, Teresa Johnson wrote:
> On Wed, Jan 15, 2014 at 10:46 AM, Jeff Law wrote:
>> On 01/15/14 10:07, Teresa Johnson wrote:
>>>
>>> Handle NULL vdef for call in the case where we have a matching vnresult
>>> that has a vdef (it alr
ions you can use to control passes explicitly:
> -fdisable-... -fenable-
>
> To disable early inline:
>
> -fdisable-tree-einline
>
> David
>
> On Wed, Jan 15, 2014 at 1:17 PM, Teresa Johnson wrote:
>> On Wed, Jan 15, 2014 at 12:00 PM, Teresa Johnson
>> wr
> but we may also have assert like wrapper.
> I see we do not provide gcov_error outside libgcov, we probably ought to map
> it to fatal_error in GCC binary.
>
> thanks,
> Honza
Ok, here is the new patch. Bootstrapped and tested on
x86_64-unknown-linux-gnu. Ok for trunk?
Thanks, Te
This patch fixes a bug in the dumping code, whereby an inner loop
index variable was the same as the outer loop index variable, and the
redef caused an infinite loop.
Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk?
2014-02-03 Teresa Johnson
* tree-vect-slp.c
r replaces the pattern specified in the argument. The format is:
>>>> old_str1:new_str1[,old_str2:new_str2]*, only the first occurrence is
>>>> replaced.
>>>> -u skips the run-time module grouping computation and reuses the one
>>>> comes with the profiles (which is user editable).
>>>>
>>>> Tested with profiles from google internal benchmarks.
>>>>
>>>
>>> Also use strcasestr for case insenstive operation.
>>
>> Done.
>>
>>>
>>> David
>>>
>>>> -Rong
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
>
> The attached patch uses a callback function to unify the integer and
> floating-point scaling in gcov-tool. (Also fix a bug in fp scaling of
> ic and dc counters in earlier code).
>
> Tested with spec2006 profiles.
>
> OK for checking in?
>
> Thanks,
>
> -Rong
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
>> function
>> layout as it is not possible to figure out the thunk section from the name
>> alone. With this patch, the thunk's section name is suffixed with the
>> mangled
>> name of the thunk and this solves the problem.
>>
>> Is this patch ok for google/gcc-4_8?
>>
>> Sri
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
g the guessed
probabilities during inlining).
Patch is below. Bootstrapped and tested on x86-64-unknown-linux-gnu.
Also tested on
a profile-use build of SPEC cpu2006. Ok for trunk when stage 1 reopens?
Thanks,
Teresa
2014-02-10 Teresa Johnson
* graphite.c (graphite_finalize): Pas
d section in the hot section. */
> + assert (!is_prefix_of (".text.unlikely", kept->full_name));
> + kept->split_section = section;
> + cold_section = section;
> + }
> + assert (cold_section != NULL && cold_section->comdat_group == NULL);
> + cold_section->is_split_cold_section = 1;
> + }
...
Thanks,
Teresa
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
On Thu, Dec 19, 2013 at 10:19 PM, Teresa Johnson wrote:
> On Thu, Dec 12, 2013 at 5:13 PM, Jan Hubicka wrote:
>>> On Wed, Dec 11, 2013 at 1:21 AM, Martin Liška
>>> wrote:
>>> > Hello,
>>> >I prepared a collection of systemtap graphs for GIMP.
On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam wrote:
> On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson wrote:
>>
>> On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote:
>>>
>>> On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson
>>> wrote:
&g
On Tue, Feb 11, 2014 at 4:51 PM, Sriraman Tallam wrote:
> On Tue, Feb 11, 2014 at 4:39 PM, Teresa Johnson wrote:
>> On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam wrote:
>>> On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson
>>> wrote:
>>>>
>>
ate (counts vs
estimated frequencies).
Teresa
>
> David
>
> On Mon, Feb 10, 2014 at 2:12 PM, Teresa Johnson wrote:
>> This patch attempts to address the lost profile issue for COMDATs in
>> more circumstances, exposed by function splitting.
>>
>> My earlier patch ha
a
>
> David
>
> On Tue, Feb 11, 2014 at 5:04 PM, Teresa Johnson wrote:
>> On Tue, Feb 11, 2014 at 2:56 PM, Xinliang David Li
>> wrote:
>>> Is it better to add some logic in counts_to_freq to determine if the
>>> profile count needs to be dropped complete
On Tue, Feb 11, 2014 at 6:13 PM, Xinliang David Li wrote:
> On Tue, Feb 11, 2014 at 5:36 PM, Teresa Johnson wrote:
>> On Tue, Feb 11, 2014 at 5:16 PM, Xinliang David Li
>> wrote:
>>> Why is call graph needed to determine whether to drop the profile?
>>
>>
On Wed, Feb 12, 2014 at 6:45 AM, Teresa Johnson wrote:
> On Tue, Feb 11, 2014 at 6:13 PM, Xinliang David Li wrote:
>> On Tue, Feb 11, 2014 at 5:36 PM, Teresa Johnson wrote:
>>> On Tue, Feb 11, 2014 at 5:16 PM, Xinliang David Li
>>> wrote:
>>>> Why is ca
On Tue, Feb 11, 2014 at 2:21 PM, Teresa Johnson wrote:
> On Thu, Dec 19, 2013 at 10:19 PM, Teresa Johnson wrote:
>> On Thu, Dec 12, 2013 at 5:13 PM, Jan Hubicka wrote:
>>>> On Wed, Dec 11, 2013 at 1:21 AM, Martin Liška
>>>> wrote:
>>>> > Hello
the call by a check to
> cgraph_function_with_gimple_body_p. Regression and spec testing are
> clean.
>
> Teresa
Ping - Honza, does this patch look ok for stage 1?
Thanks,
Teresa
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
nrolling for very hot loops. */
>sum_to_header_ratio = profile_info->sum_all / loop->header->count;
>hotness_ratio_threshold = PARAM_VALUE
> (PARAM_UNROLLPEEL_HOTNESS_THRESHOLD);
>/* When the profile count sum to loop entry header ratio is smaller
> than
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
Ping. Jeff, any update on when you can look at this?
Thanks,
Teresa
On Tue, May 27, 2014 at 7:10 AM, Teresa Johnson wrote:
> On Thu, Apr 17, 2014 at 6:23 AM, Teresa Johnson wrote:
>> On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote:
>>> On 03/26/14 17:44, Te
This patch will rewrite references to function decls in all statements
after LIPO linking so that the subsequent cgraph rebuild will set up
references correctly.
Passes regression and internal testing. Ok for google/4_9?
Thanks,
Teresa
2014-07-15 Teresa Johnson
Google ref b/16190119
AFDO invokes cgraph_node_for_asm during VPT to get the cgraph node for
a callee. Use the resolved node so we don't add a reference to the
un-resolved node after LIPO fixup.
Passes regression tests and internal test. Ok for google/4_9?
Thanks,
Teresa
2014-07-23 Teresa Johnson
G
On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote:
> On 03/26/14 17:44, Teresa Johnson wrote:
>>
>> Recently I discovered that the profile updates being performed by jump
>> threading were incorrect in many cases, particularly in the case where
>> the threading path con
On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson wrote:
> On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote:
>> On 03/26/14 17:44, Teresa Johnson wrote:
>>>
>>> Recently I discovered that the profile updates being performed by jump
>>> threading were incorrec
This patch adds dummy references to libgcov for the symbols accessed
via weak references from application code to ensure they are resolved
at link time. Passes regression tests. Ok for google-4_8?
Thanks,
Teresa
2014-03-10 Teresa Johnson
Google ref b/13338320.
* libgcov-driver.c: Add dummy
On Fri, Feb 28, 2014 at 9:13 AM, Teresa Johnson wrote:
>>>> Here's the new patch. The only changes from the earlier patch are in
>>>> handle_missing_profiles, where we now get the counts off of the entry
>>>> and call stmt bbs, and in tree_profiling, w
Minor dumping fix.
Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for stage 1?
Thanks,
Teresa
2014-03-21 Teresa Johnson
* ipa-utils.c (ipa_print_order): Use specified dump file.
Index: ipa-utils.c
===
--- ipa
08165), instead of a block in the
optimized code.
Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for either trunk or
stage 1?
Thanks,
Teresa
2014-04-08 Teresa Johnson
* tree-cfg.c (remove_bb): Don't dump details during bb removal.
2014-04-08 Teresa Johnson
* gcc.dg
cif-code.def ipa-ref.h ipa-ref-inline.h $(LINKER_PLUGIN_API_H) is-a.h
+ cif-code.def ipa-ref.h ipa-ref-inline.h $(LINKER_PLUGIN_API_H) is-a.h \
+ l-ipo.h
DF_H = df.h $(BITMAP_H) $(REGSET_H) sbitmap.h $(BASIC_BLOCK_H) \
alloc-pool.h $(TIMEVAR_H)
VALTRACK_H = valtrack.h $(BITMAP_H)
he call to
check_bb_profile, which was not actually checking if flags contained
TDF_DETAILS, also fixed in the new patch below.
>
> Either way ok for stage1.
>
> Thanks,
> Richard.
Thanks, I have retested with the new patch below and will wait for
stage 1 before committing.
Teres
On Wed, Apr 16, 2014 at 10:39 PM, Jeff Law wrote:
> On 03/26/14 17:44, Teresa Johnson wrote:
>>
>> Recently I discovered that the profile updates being performed by jump
>> threading were incorrect in many cases, particularly in the case where
>> the threading path con
On Tue, Dec 11, 2012 at 10:12 AM, Jan Hubicka wrote:
>> On 2012.12.11 at 09:13 -0800, Teresa Johnson wrote:
>> > Ping.
>> > Teresa
>> >
>> > On Mon, Nov 19, 2012 at 4:58 PM, Teresa Johnson
>> > wrote:
>> > > This patch was proposed
there is very little that can be done to avoid the same
> mistakes, or new ones, creeping back in and breaking builds with older
> compilers.
>
>
>> What are your thoughts on this?
>
> At least: Thanks for uncovering the gcov-io.c bug :-)
Yes, thanks for fixing this. The fix looks good to me.
Thanks,
Teresa
>
> Ciao!
> Steven
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
On Wed, Dec 12, 2012 at 7:25 AM, Richard Biener wrote:
> On Wed, 12 Dec 2012, Teresa Johnson wrote:
>
>> On Wed, Dec 12, 2012 at 2:21 AM, Steven Bosscher
>> wrote:
>> > On Wed, Dec 12, 2012 at 6:07 AM, Aldy Hernandez wrote:
>> >> I don't know how muc
ation dumped in response to -fopt-info is also
>> present in regular dump file(s) when corresponding dumps are
>> enabled. Thus in above examples, the loop optimization info is also
>> present in *.loop2_unroll dump file since the command line specified a
>> dump file via "-fdump-rtl-loop2_unroll" in addition to -fopt-info.
>>
>> (As a side note, while doing the conversion, I found that the MSG_*
>> dump flags are unwieldy when used in conjunction with other
>> flags. Perhaps these flags should be renamed/shortened. I propose the
>> following
>>MSG_MISSED_OPTIMIZATION ==> MSG_MISSED
>>MSG_OPTIMIZED_LOCATIONS ==> MSG_OPTIMIZED
>> But that is pure renaming and can be done separately.)
>>
>> I have bootstrapped and tested this patch on x86_64 and found no new
>> failures. Okay for trunk?
>>
>> Thanks,
>> Sharad
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
301 - 400 of 503 matches
Mail list logo
