Re: [patch] Add counter inits to zero_iter_bb in expand_omp_for_init_counts

2015-10-01 Thread Tom de Vries
On 01/10/15 14:49, Jakub Jelinek wrote: On Thu, Oct 01, 2015 at 02:46:01PM +0200, Tom de Vries wrote: this patch adds initialization in zero_iter_bb of counters introduced in expand_omp_for_init_counts. This removes the need to set TREE_NO_WARNING on those counters. Why do you think

Re: [PING][PR67476] Add param parloops-schedule

2015-10-04 Thread Tom de Vries
On 22/09/15 12:58, Bernd Schmidt wrote: On 09/22/2015 09:19 AM, Tom de Vries wrote: These two patches: - https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00938.html - https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00940.html add a param parloop-schedule=<static|dynamic|guided|auto|runt

[Committed] Add gcc.dg/vect/pr62171.c

2015-09-28 Thread Tom de Vries
Hi, this patch adds testcase gcc.dg/vect/pr62171.c. The testcase passes thanks to the fix for PR67673. Committed to trunk. Thanks, - Tom Add gcc.dg/vect/pr62171.c 2015-09-28 Tom de Vries <t...@codesourcery.com> * gcc.dg/vect/pr62171.c: New test. --- gcc/testsuite/gcc.dg/vect/pr6

Re: [PATCH] Don't create superfluous parm in expand_omp_taskreg

2015-09-24 Thread Tom de Vries
On 24/09/15 08:23, Thomas Schwinge wrote: Hi Tom! On Tue, 11 Aug 2015 20:53:39 +0200, Tom de Vries <tom_devr...@mentor.com> wrote: Don't create superfluous parm in expand_omp_taskreg 2015-08-11 Tom de Vries <t...@codesourcery.com> * omp-low.c (expand_omp_taskreg): If

[PATCH][PR67666] Handle single restrict pointer in struct in create_variable_info_for_1

2015-09-22 Thread Tom de Vries
have the desired effect. This patch fixes the handling of structs with a single field in alias analysis. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle single restrict pointer in struct in create_variable_info_for_1 2015-09-22 Tom de Vries <t...@codesourcery.com>

[PING][PR67476] Add param parloops-schedule

2015-09-22 Thread Tom de Vries
Hi, These two patches: - https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00938.html - https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00940.html add a param parloop-schedule=. Thanks, - Tom

[PATCH][PR67671] Handle restrict pointer references as restrict in AA

2015-09-22 Thread Tom de Vries
both clique/base annotations for the the second example. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle restrict pointer references as restrict in AA 2015-09-22 Tom de Vries <t...@codesourcery.com> PR tree-optimization/67671 * tree-ssa-structalias.c (create_variabl

[gomp4, committed] Skip inner loops in oacc kernels region

2015-09-25 Thread Tom de Vries
Hi, this patch fixes an ICE when trying to parallelize inner loops in an oacc kernels region. The patch fixes it by not trying to parallelize those inner loops. Committed to gomp-4_0-branch. Thanks, - Tom Skip inner loops in oacc kernels region 2015-09-24 Tom de Vries &l

Re: [PATCH] Fix warnings from including fdl.texi into gnat-style.texi

2015-12-08 Thread Tom de Vries
On 23/03/15 16:00, Gerald Pfeifer wrote: On Fri, 20 Mar 2015, Tom de Vries wrote: The gnat-style.texi part is OK. I cannot approve the fdl part though. Gerald, Can you approve the fdl part? Let's assume I can. Okay. Can you just describe the _why_ a bit in a @comment (in simple words

Re: [PATCH, PR68640] Clear restrict in install_var_field

2015-12-08 Thread Tom de Vries
On 08/12/15 10:41, Tom de Vries wrote: Cliques are not computed in IPA PTA and the above would require IPA. FTR, this is a generic (not openmp-related) example, and AFAIU a more generic form of the issue that is being raised. ... static void __attribute__((noinline, noclone)) bar (int *a, int

Re: [PATCH, PR68640] Clear restrict in install_var_field

2015-12-08 Thread Tom de Vries
On 08/12/15 10:22, Richard Biener wrote: On Tue, 8 Dec 2015, Jakub Jelinek wrote: On Tue, Dec 08, 2015 at 09:49:49AM +0100, Tom de Vries wrote: diff --git a/gcc/omp-low.c b/gcc/omp-low.c index d1d1e3c..ac4a94d 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -1389,6 +1389,12

[PATCH, PR68640] Clear restrict in install_var_field

2015-12-08 Thread Tom de Vries
earing the restrict qualifier on pointer types in install_var_field. Build non-bootstrap c compiler and tested gcc/gomp.exp and target-libgomp/c.exp. OK for stage3 trunk if bootstrap and reg-test succeeds? Thanks, - Tom Clear restrict in install_var_field 2015-12-02 Tom de Vries <t...@codesou

Re: [OpenACC 0/7] host_data construct

2015-12-02 Thread Tom de Vries
On 30/11/15 20:30, Julian Brown wrote: libgomp/ * oacc-parallel.c (GOACC_host_data): New function. * libgomp.map (GOACC_host_data): Add to GOACC_2.0.1. * testsuite/libgomp.oacc-c-c++-common/host_data-1.c: New test. * testsuite/libgomp.oacc-c-c++-common/host_data-2.c: New

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-01 Thread Tom de Vries
On 01/12/15 15:44, Jakub Jelinek wrote: On Tue, Dec 01, 2015 at 03:25:42PM +0100, Tom de Vries wrote: Handle BUILT_IN_GOACC_PARALLEL in ipa-pta 2015-12-01 Tom de Vries <t...@codesourcery.com> * tree-ssa-structalias.c (find_func_aliases_for_builtin_call) (find_func_cl

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-02 Thread Tom de Vries
On 03/12/15 01:10, Tom de Vries wrote: I've managed to reproduce it. The difference between pass and fail is whether the compiler is configured with or without accelerator. I'll look into it. In the configuration with accelerator, the flag node->force_output is on for foo._omp

Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-12-03 Thread Tom de Vries
On 30/11/15 14:32, Jakub Jelinek wrote: On Mon, Nov 30, 2015 at 02:24:18PM +0100, Richard Biener wrote: OK for stage3 trunk if bootstrap and reg-test succeeds? -|| node->address_taken); +|| (node->address_taken +&&

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-03 Thread Tom de Vries
On 03/12/15 09:59, Richard Biener wrote: On Thu, 3 Dec 2015, Tom de Vries wrote: On 03/12/15 01:10, Tom de Vries wrote: I've managed to reproduce it. The difference between pass and fail is whether the compiler is configured with or without accelerator. I'll look

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-03 Thread Tom de Vries
On 11/11/15 12:00, Jakub Jelinek wrote: On Wed, Nov 11, 2015 at 11:51:02AM +0100, Richard Biener wrote: The option -foffload-alias=pointer instructs the compiler to assume that objects references in an offload region do not alias. The option -foffload-alias=all instructs the compiler to make

Fix buildbreaker with isl 0.14

2015-12-03 Thread Tom de Vries
[ was: Re: [PATCH] [graphite] handle missing isl_ast_expr ] On 03/12/15 00:56, Tom de Vries wrote: Hi, This break the build for me, with isl 0.14. ... src/gcc/graphite-isl-ast-to-gimple.c: In member function ‘tree_node* translate_isl_ast_to_gimple::binary_op_to_tree(tree, isl_ast_expr

Re: [PATCH, PR68716] Fix GOMP/GOACC_parallel handling in find_func_clobbers

2015-12-09 Thread Tom de Vries
On 09/12/15 11:03, Jakub Jelinek wrote: On Wed, Dec 09, 2015 at 11:01:31AM +0100, Tom de Vries wrote: PR tree-optimization/68716 * tree-ssa-structalias.c (find_func_clobbers): Fix handling of BUILT_IN_GOMP_PARALLEL and BUILT_IN_GOMP_PARALLEL. Pasto in ChangeLog entry

[PATCH, PR68716] Fix GOMP/GOACC_parallel handling in find_func_clobbers

2015-12-09 Thread Tom de Vries
[ was: Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta ] On 30/11/15 13:11, Tom de Vries wrote: On 30/11/15 10:16, Richard Biener wrote: On Mon, 30 Nov 2015, Tom de Vries wrote: Hi, this patch fixes PR46032. It handles a call: ... __builtin_GOMP_parallel (fn, data

[gomp4, committed] backport: "Fix oacc kernels default mapping for scalars"

2015-12-09 Thread Tom de Vries
Hi, I've backported the patch "Fix oacc kernels default mapping for scalars" from trunk to gomp-4_0-branch. Committed to gomp-4_0-branch. Thanks, - Tom backport: "Fix oacc kernels default mapping for scalars" 2015-12-02 Tom de Vries <t...@codesourcery.com

Re: [PATCH] Fix oacc kernels default mapping for scalars

2015-12-02 Thread Tom de Vries
On 02/12/15 19:03, Thomas Schwinge wrote: Hi! Copying Nathan for your information, in case you had not yet seen that gcc/gimplify.c:oacc_default_clause change: On Fri, 27 Nov 2015 12:29:21 +0100, Tom de Vries<tom_devr...@mentor.com> wrote: >The OpenACC 2.0a standard says t

Re: [PATCH] [graphite] handle missing isl_ast_expr

2015-12-02 Thread Tom de Vries
Hi, This break the build for me, with isl 0.14. ... src/gcc/graphite-isl-ast-to-gimple.c: In member function ‘tree_node* translate_isl_ast_to_gimple::binary_op_to_tree(tree, isl_ast_expr*, ivs_params&)’: src/gcc/graphite-isl-ast-to-gimple.c:591:10: error: ‘isl_ast_op_zdiv_r’ was not declared

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-02 Thread Tom de Vries
On 02/12/15 18:58, Thomas Schwinge wrote: Hi! On Tue, 1 Dec 2015 15:25:42 +0100, Tom de Vries<tom_devr...@mentor.com> wrote: >Handle BUILT_IN_GOACC_PARALLEL in ipa-pta >* c-c++-common/goacc/kernels-alias-ipa-pta-2.c: New test. >* c-c++-common/goacc/kernels-alias-ipa-pt

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-02 Thread Tom de Vries
On 03/12/15 00:31, Tom de Vries wrote: On 02/12/15 18:58, Thomas Schwinge wrote: Hi! On Tue, 1 Dec 2015 15:25:42 +0100, Tom de Vries<tom_devr...@mentor.com> wrote: >Handle BUILT_IN_GOACC_PARALLEL in ipa-pta >* c-c++-common/goacc/kernels-alias-ipa-pta-2.c: New test. >

Re: [PR68001, CilkPlus] Fix for PR68001

2015-12-01 Thread Tom de Vries
On 30/11/15 21:43, Zamyatin, Igor wrote: FAIL: obj-c++.dg/property/dotsyntax-11.mm -fgnu-runtime (test for errors, line 51) FAIL: obj-c++.dg/property/dotsyntax-11.mm -fgnu-runtime (test for errors, line 56) FAIL: obj-c++.dg/property/dotsyntax-11.mm -fgnu-runtime (test for errors, line 59)

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-02 Thread Tom de Vries
On 02/12/15 10:45, Jakub Jelinek wrote: On Fri, Nov 27, 2015 at 12:42:09PM +0100, Tom de Vries wrote: --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -1366,10 +1366,12 @@ build_sender_ref (tree var, omp_context *ctx) return build_sender_ref ((splay_tree_key) var, ctx); } -/* Add a new field

[PATCH] Add pass parameter to TERMINATE_PASS_LIST

2015-12-11 Thread Tom de Vries
that INSERT_PASSES_AFTER and TERMINATE_PASS_LIST are paired. OK for stage3/stage1 trunk, if bootstrap and reg-test succeeds? Thanks, - Tom Add pass parameter to TERMINATE_PASS_LIST 2015-12-11 Tom de Vries <t...@codesourcery.com> * pass_manager.h (TERMINATE_PASS_LIST): Add pass ar

[PATCH] Remove unpaired TERMINATE_PASS_LIST in passes.def

2015-12-11 Thread Tom de Vries
Hi, this patch removes a TERMINATE_PASS_LIST from passes.def that is not paired with any INSERT_PASSES_AFTER. Bootstrapped and reg-tested on x86_64. OK for stage3 trunk? Thanks, - Tom Remove unpaired TERMINATE_PASS_LIST in passes.def 2015-12-11 Tom de Vries <t...@codesourcery.

[PATCH] Handle sizes and kinds params of GOACC_paralllel in find_func_clobbers

2015-12-11 Thread Tom de Vries
ks, - Tom Handle sizes and kinds params of GOACC_paralllel in find_func_clobbers 2015-12-11 Tom de Vries <t...@codesourcery.com> * tree-ssa-structalias.c (find_func_clobbers): Handle sizes and kinds parameters of GOACC_paralllel. --- gcc/tree-ssa-structalias.c | 16 ++

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-11 Thread Tom de Vries
On 13/11/15 12:39, Jakub Jelinek wrote: We simply have some compiler internal interface between the caller and callee of the outlined regions, each interface in between those has its own structure type used to communicate the info; we can attach attributes on the fields, or some flags to

[committed, obvious] Remove invalid assert in find_func_aliases_for_builtin_call

2015-12-10 Thread Tom de Vries
[ was : Re: [PATCH, PR68716] Fix GOMP/GOACC_parallel handling in find_func_clobbers ] On 09/12/15 11:01, Tom de Vries wrote: [ was: Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta ] On 30/11/15 13:11, Tom de Vries wrote: On 30/11/15 10:16, Richard Biener wrote: On Mon, 30 Nov

[RFC] Dump ssaname info for default defs

2015-12-11 Thread Tom de Vries
Hi, atm, we dump ssa-name info for lhs-es of statements. That leaves out the ssa names with default defs. This proof-of-concept patch prints the ssa-name info for default defs, in the following format: ... __attribute__((noclone, noinline)) bar (intD.6 * cD.1755, intD.6 * dD.1756) # PT =

Re: [RFC] Dump ssaname info for default defs

2015-12-14 Thread Tom de Vries
On 14/12/15 09:47, Richard Biener wrote: On Fri, Dec 11, 2015 at 6:05 PM, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, atm, we dump ssa-name info for lhs-es of statements. That leaves out the ssa names with default defs. This proof-of-concept patch prints the ssa-name info for d

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-14 Thread Tom de Vries
On 14/12/15 14:26, Richard Biener wrote: On Sun, 13 Dec 2015, Tom de Vries wrote: On 11/12/15 14:00, Richard Biener wrote: On Fri, 11 Dec 2015, Tom de Vries wrote: On 13/11/15 12:39, Jakub Jelinek wrote: We simply have some compiler internal interface between the caller and callee

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-13 Thread Tom de Vries
On 11/12/15 14:00, Richard Biener wrote: On Fri, 11 Dec 2015, Tom de Vries wrote: On 13/11/15 12:39, Jakub Jelinek wrote: We simply have some compiler internal interface between the caller and callee of the outlined regions, each interface in between those has its own structure type used

[PIING][PATCH, 9/16] Add pass_parallelize_loops_oacc_kernels

2015-12-13 Thread Tom de Vries
On 24/11/15 13:24, Tom de Vries wrote: On 16/11/15 12:59, Tom de Vries wrote: On 09/11/15 20:52, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto

Re: [PATCH, 4/16] Implement -foffload-alias

2015-12-16 Thread Tom de Vries
On 16/12/15 14:16, Richard Biener wrote: On Mon, 14 Dec 2015, Tom de Vries wrote: On 14/12/15 14:26, Richard Biener wrote: On Sun, 13 Dec 2015, Tom de Vries wrote: On 11/12/15 14:00, Richard Biener wrote: On Fri, 11 Dec 2015, Tom de Vries wrote: On 13/11/15 12:39, Jakub Jelinek wrote

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-16 Thread Tom de Vries
On 10/12/15 14:14, Tom de Vries wrote: [ copy-pasting-with-quote from https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00420.html , for some reason I didn't get this email ] On Thu, 3 Dec 2015, Tom de Vries wrote: The flag is set here in expand_omp_target: ... 12682 /* Prevent IPA from

Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-10 Thread Tom de Vries
[ copy-pasting-with-quote from https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00420.html , for some reason I didn't get this email ] On Thu, 3 Dec 2015, Tom de Vries wrote: The flag is set here in expand_omp_target: ... 12682 /* Prevent IPA from removing child_fn as unreachable

Re: [PATCH] Handle sizes and kinds params of GOACC_paralllel in find_func_clobbers

2015-12-14 Thread Tom de Vries
On 11/12/15 13:31, Richard Biener wrote: On Fri, 11 Dec 2015, Tom de Vries wrote: Hi, while testing the oacc kernels patch series on top of trunk, using the optimal handling of BUILTIN_IN_GOACC_PARALLEL in fipa-pta I ran into a failure where the stores to the omp_data_sizes array were

Re: [PATCH] Fix warnings from including fdl.texi into gnat-style.texi

2015-12-14 Thread Tom de Vries
On 08/12/15 19:10, Gerald Pfeifer wrote: Hi Tom, On Tue, 8 Dec 2015, Tom de Vries wrote: Can you approve the fdl part? Let's assume I can. Okay. was the 'Okay' above: - a figure of speech (as I read it), or - an actual approval (conditional on the adding of the comment) ? I should have

[gomp4, committed] Handle ptr iterator in acc loop

2015-12-09 Thread Tom de Vries
Hi, this patch ensures that the [0][0][0] initializer of the acc loop in the testcase is properly compiled. Committed to gomp-4_0-branch. Thanks, - Tom Handle ptr iterator in acc loop 2015-12-09 Tom de Vries <t...@codesourcery.com> * omp-low.c (expand_omp_for_generic): Gimplify se

Re: Ping [PATCH] c++/42121 - diagnose invalid flexible array members

2015-12-15 Thread Tom de Vries
On 14/12/15 17:45, Martin Sebor wrote: gcc/testsuite/ChangeLog: 2015-12-02 Martin Sebor c++/42121 c++/68478 c++/68613 c++/68689 c++/68710 * g++.dg/compat/struct-layout-1_generate.c: Avoid generating further fields after

[PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

2016-01-05 Thread Tom de Vries
[ was: Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta ] On 16/12/15 17:02, Tom de Vries wrote: On 10/12/15 14:14, Tom de Vries wrote: [ copy-pasting-with-quote from https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00420.html , for some reason I didn't get this email ] On Thu, 3 Dec 2015

[RFC] Use gfc_decl_attributes in fortran frontend

2015-12-17 Thread Tom de Vries
Hi, Consider this patch, which reduces max_len of the oacc function attribute to 0: ... diff --git a/gcc/fortran/f95-lang.c b/gcc/fortran/f95-lang.c index 8556b70..60f4ad3 100644 --- a/gcc/fortran/f95-lang.c +++ b/gcc/fortran/f95-lang.c @@ -93,7 +93,7 @@ static const struct attribute_spec

Re: [PATCH, 4/16] Implement -foffload-alias

2015-11-27 Thread Tom de Vries
On 23/11/15 12:41, Richard Biener wrote: On Sat, 21 Nov 2015, Tom de Vries wrote: >On 13/11/15 12:39, Jakub Jelinek wrote: > >On Fri, Nov 13, 2015 at 12:29:51PM +0100, Richard Biener wrote: > > > >thanks for the explanation. Filed as PR68331 - '[meta-bug] f

Re: [PATCH, 4/16] Implement -foffload-alias

2015-11-27 Thread Tom de Vries
On 27/11/15 12:42, Tom de Vries wrote: On 23/11/15 12:41, Richard Biener wrote: On Sat, 21 Nov 2015, Tom de Vries wrote: >On 13/11/15 12:39, Jakub Jelinek wrote: > >On Fri, Nov 13, 2015 at 12:29:51PM +0100, Richard Biener wrote: > > > >thanks for the explanation. File

[PATCH] Fix oacc kernels default mapping for scalars

2015-11-27 Thread Tom de Vries
variables including the scalar ones have 'present_or_copy' defaults. This patch makes sure scalar variables get the 'copy' default. Bootstrapped and reg-tested on x86_64. OK for stage3 trunk? Thanks, - Tom Fix oacc kernels default mapping for scalars 2015-11-27 Tom de Vries <t...@codesourcery.

Re: [RFC] Getting LTO incremental linking work

2015-11-28 Thread Tom de Vries
On 28/11/15 10:35, Tom de Vries wrote: On 26/11/15 00:07, Jan Hubicka wrote: (flinker_output): New flag. Hi, this seems to have cause a regression when using a compiler configured for offloading (giving ~1000 fails in libgomp testing). For test-case libgomp.c/examples-4/array_sections-3.c

Re: [RFC] Getting LTO incremental linking work

2015-11-28 Thread Tom de Vries
On 26/11/15 00:07, Jan Hubicka wrote: (flinker_output): New flag. Hi, this seems to have cause a regression when using a compiler configured for offloading (giving ~1000 fails in libgomp testing). For test-case libgomp.c/examples-4/array_sections-3.c, we enter run_gcc in lto-wrapper with

Re: [RFC] Getting LTO incremental linking work

2015-11-28 Thread Tom de Vries
On 28/11/15 13:02, Ilya Verbin wrote: 2015-11-28 14:01 GMT+03:00 Tom de Vries <tom_devr...@mentor.com>: This patch fixes the failures. I'm not sure if this is the right or complete fix though. I think it's ok, at least until we decide how to rework the offloading stuff in lto-wrappe

[PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-11-30 Thread Tom de Vries
. Bootstrapped and reg-tested on x86_64. OK for stage3 trunk? Thanks, - Tom Handle BUILT_IN_GOMP_PARALLEL in pta 2015-11-30 Tom de Vries <t...@codesourcery.com> PR tree-optimization/46032 * tree-ssa-structalias.c (find_func_aliases_for_builtin_call) (find_func_clobbers):

Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-11-30 Thread Tom de Vries
On 30/11/15 14:24, Richard Biener wrote: On Mon, 30 Nov 2015, Tom de Vries wrote: On 30/11/15 10:16, Richard Biener wrote: On Mon, 30 Nov 2015, Tom de Vries wrote: Hi, this patch fixes PR46032. It handles a call: ... __builtin_GOMP_parallel (fn, data, num_threads, flags

Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-11-30 Thread Tom de Vries
On 30/11/15 17:48, Jakub Jelinek wrote: On Mon, Nov 30, 2015 at 05:36:25PM +0100, Tom de Vries wrote: +int +main (void) +{ + unsigned results[nEvents]; + unsigned pData[nEvents]; + unsigned coeff = 2; + + init ([0], [0]); + +#pragma omp parallel for + for (int idx = 0; idx < (int)nEve

Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-11-30 Thread Tom de Vries
On 30/11/15 10:16, Richard Biener wrote: On Mon, 30 Nov 2015, Tom de Vries wrote: Hi, this patch fixes PR46032. It handles a call: ... __builtin_GOMP_parallel (fn, data, num_threads, flags) ... as: ... fn (data) ... in ipa-pta. This improves ipa-pta alias analysis in the parallelized

Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

2015-12-01 Thread Tom de Vries
nd perhaps some other effective target conditions)? I've moved the tests, and added dg-require-effective-target vect_int in pr46032.c. Committed to trunk as obvious. Thanks, - Tom Move pr46032*.c tests 2015-12-01 Tom de Vries <t...@codesourcery.com> * gcc.dg/pr46032.c: Move to ... *

[PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta

2015-12-01 Thread Tom de Vries
[ was: Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta ] On 30/11/15 17:36, Tom de Vries wrote: On 30/11/15 14:24, Richard Biener wrote: On Mon, 30 Nov 2015, Tom de Vries wrote: On 30/11/15 10:16, Richard Biener wrote: On Mon, 30 Nov 2015, Tom de Vries wrote: Hi, this patch

Re: [PATCH] Improve verification of loop->latch in verify_loop_structure

2015-11-26 Thread Tom de Vries
On 26/11/15 13:15, Richard Biener wrote: On Thu, 26 Nov 2015, Alan Lawrence wrote: This caused an ICE compiling value.c from gdb on aarch64-none-linux-gnu; the testcase, after preprocessing on aarch64, ICEs on both aarch64 and x86_64, but is about 1MB - I'm working on reducing that down to

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-11-17 Thread Tom de Vries
On 14/11/15 00:35, Jeff Law wrote: Anyway, bootstrapped and regression tested on x86_64-linux-gnu. Installed on the trunk. [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation * Makefile.in (OBJS): Add gimple-ssa-split-paths.o *

Re: Add gencfn-macros.c

2015-11-18 Thread Tom de Vries
On 07/11/15 13:35, Richard Sandiford wrote: This patch automatically generates case macros such as: CASE_CFN_SQRT for each {F,,L} floating-point built-in function and each {,L,LL,IMAX} integer built-in function. The macros match the same built-in functions as CASE_FLT_FN and CASE_INT_FN

[PATCH, PR68373 ] Call scev_const_prop in pass_parallelize_loops::execute

2015-11-17 Thread Tom de Vries
x86_64. OK for stage3/stage1? Thanks, - Tom Call scev_const_prop in pass_parallelize_loops::execute 2015-11-17 Tom de Vries <t...@codesourcery.com> PR tree-optimization/68373 * tree-parloops.c (pass_parallelize_loops::execute): Call scev_const_prop. * gcc.dg/autopar/pr68373.c:

Re: [PATCH] Improve comments in pass_tree_loop_init::execute

2015-11-17 Thread Tom de Vries
On 17/11/15 12:41, Richard Biener wrote: On Tue, 17 Nov 2015, Tom de Vries wrote: Hi, this no-functional-changes patch improves comments in pass_tree_loop_init::execute. For the discussion related to the comment for scev_initialize, see: - https://gcc.gnu.org/ml/gcc-patches/2013-02/msg01127

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-18 Thread Tom de Vries
On 17/11/15 15:53, Tom de Vries wrote: And the above LIM example is none for why you need two LIM passes... Indeed. I'm planning a separate reply to explain in more detail the need for the two pass_lims. I. I managed to get rid of the two pass_lims for the motivating example that I used

Re: Combined constructs' clause splitting

2015-11-18 Thread Tom de Vries
On 19/11/15 01:03, Cesar Philippidis wrote: On 11/08/2015 07:45 AM, Tom de Vries wrote: On 07/11/15 12:45, Thomas Schwinge wrote: Hi! On Fri, 6 Nov 2015 15:31:23 -0800, Cesar Philippidis <ce...@codesourcery.com> wrote: I've applied this patch to gomp-4_0-branch which backports most

Re: [PATCH, PR68373 ] Call scev_const_prop in pass_parallelize_loops::execute

2015-11-19 Thread Tom de Vries
On 17/11/15 23:20, Tom de Vries wrote: [ was: Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def ] Hi, Consider test-case test.c, with a use of the final value of the iteration variable (return i): ... unsigned int foo (int *a, unsigned int n) { unsigned int i; for (i = 0

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-20 Thread Tom de Vries
On 20/11/15 11:37, Richard Biener wrote: I'd rather make loop_optimizer_init do nothing if requested flags are already set and no fixup is needed Thus sth like Index: gcc/loop-init.c === --- gcc/loop-init.c (revision

[committed, trivial] Fix typo and trailing whitespace in dump-file strings in parloops

2015-11-20 Thread Tom de Vries
ng whitespace in dump-file strings in parloops 2015-11-19 Tom de Vries <t...@codesourcery.com> * tree-parloops.c (build_new_reduction): Fix trailing whitespace in dump-file string. (try_create_reduction_list): Same. Fix typo in dump-file string. --- gcc/tree-parloops.c | 4 ++-- 1

[PATCH, PR68460] Always call free_stmt_vec_info_vec in gather_scalar_reductions

2015-11-20 Thread Tom de Vries
[ was: Re: [PATCH] Fix parloops gimple_uid usage ] On 09/10/15 23:09, Tom de Vries wrote: @@ -2392,6 +2397,9 @@ gather_scalar_reductions (loop_p loop, reduction_info_table_type *reduction_list loop_vec_info simple_inner_loop_info = NULL; bool allow_double_reduc = true

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-20 Thread Tom de Vries
On 20/11/15 14:29, Richard Biener wrote: I agree it's somewhat of an odd behavior but all passes should either be placed in a sub-pipeline with an outer loop_optimizer_init()/finalize () call or call both themselves. Hmm, but adding loop_optimizer_finalize at the end of pass_lim breaks the

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-19 Thread Tom de Vries
rnels pass group in passes.def 2015-11-09 Tom de Vries <t...@codesourcery.com> * omp-low.c (pass_expand_omp_ssa::clone): New function. * passes.def: Add pass_oacc_kernels pass group. * tree-ssa-loop-ch.c (pass_ch::clone): New function. * tree-ssa-loop-im.c (tree_ssa_lim): Make st

[PATCH] Check NULL loop->latch in verify_loop_structure

2015-11-22 Thread Tom de Vries
of adding this check, I needed to fix expand_omp_for_generic, which missed an initialization of a loop latch. Bootstrapped and reg-tested on x86_64. OK for stage3 trunk? Thanks, - Tom Check NULL loop->latch in verify_loop_structure 2015-11-22 Tom de Vries <t...@codesource

[PATCH] Don't reapply loops flags if unnecessary in loop_optimizer_init

2015-11-22 Thread Tom de Vries
more complicated because of the need to handle LOOPS_MAY_HAVE_MULTIPLE_LATCHES differently than the rest of the flags. Bootstrapped and reg-tested on x86_64. OK for stage3 trunk? Thanks, - Tom Don't reapply loops flags if unnecessary in loop_optimizer_init 2015-11-22 Tom de Vries &l

Re: [PATCH] Don't reapply loops flags if unnecessary in loop_optimizer_init

2015-11-23 Thread Tom de Vries
On 23/11/15 11:29, Richard Biener wrote: On Mon, 23 Nov 2015, Tom de Vries wrote: [ was: Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def ] On 20/11/15 11:37, Richard Biener wrote: I'd rather make loop_optimizer_init do nothing if requested flags are already set and no fixup

[PATCH] Mark by_ref mem_ref in build_receiver_ref as non-trapping

2015-11-21 Thread Tom de Vries
[ was: Re: [Committed] Mark *.omp_data_i as non-trapping ] On 13/07/15 11:49, Tom de Vries wrote: [ was: Re: [gomp4, committed] Handle nested loops in kernels regions ] On 13/07/15 10:36, Jakub Jelinek wrote: On Mon, Jul 13, 2015 at 10:19:56AM +0200, Thomas Schwinge wrote: We rely

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-23 Thread Tom de Vries
On 23/11/15 12:31, Richard Biener wrote: From the dump below I understand you want no memory references in > >the outer loop? > >So the issue seems to be that store motion fails > >to insert the preheader load / exit store to the outermost loop > >possible and thus another LIM pass is needed to

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-24 Thread Tom de Vries
On 24/11/15 15:33, Richard Biener wrote: On Tue, 24 Nov 2015, Tom de Vries wrote: On 24/11/15 14:13, Richard Biener wrote: On Tue, 24 Nov 2015, Tom de Vries wrote: On 23/11/15 11:02, Richard Biener wrote: On Fri, 20 Nov 2015, Tom de Vries wrote: On 20/11/15 14:29, Richard Biener wrote

[PATCH] Improve verification of loop->latch in verify_loop_structure

2015-11-24 Thread Tom de Vries
[ was: Re: [PATCH] Check NULL loop->latch in verify_loop_structure ] On 23/11/15 11:28, Richard Biener wrote: On Mon, 23 Nov 2015, Tom de Vries wrote: Hi, In verify_loop_structure, we stop checking the latch once we find that it's NULL. This patch tries a bit har

[PING][PATCH, 12/16] Handle acc loop directive

2015-11-24 Thread Tom de Vries
On 09/11/15 21:06, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-24 Thread Tom de Vries
On 23/11/15 11:02, Richard Biener wrote: On Fri, 20 Nov 2015, Tom de Vries wrote: On 20/11/15 14:29, Richard Biener wrote: I agree it's somewhat of an odd behavior but all passes should either be placed in a sub-pipeline with an outer loop_optimizer_init()/finalize () call or call both

Re: [PATCH, 9/16] Add pass_parallelize_loops_oacc_kernels

2015-11-24 Thread Tom de Vries
On 16/11/15 12:59, Tom de Vries wrote: On 09/11/15 20:52, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series

Re: [PATCH, 6/16] Add pass_oacc_kernels

2015-11-24 Thread Tom de Vries
On 19/11/15 14:50, Tom de Vries wrote: On 11/11/15 11:58, Richard Biener wrote: On Mon, 9 Nov 2015, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto

[PING][PATCH, 3/16] Ignore reduction clause on kernels directive

2015-11-24 Thread Tom de Vries
On 09/11/15 16:50, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-24 Thread Tom de Vries
On 24/11/15 14:13, Richard Biener wrote: On Tue, 24 Nov 2015, Tom de Vries wrote: >On 23/11/15 11:02, Richard Biener wrote: > >On Fri, 20 Nov 2015, Tom de Vries wrote: > > > > >On 20/11/15 14:29, Richard Biener wrote: > > > >I agree it's somewhat of a

Re: [PATCH, 6/16] Add pass_oacc_kernels

2015-11-19 Thread Tom de Vries
On 11/11/15 11:58, Richard Biener wrote: On Mon, 9 Nov 2015, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch

Re: [PATCH, 4/16] Implement -foffload-alias

2015-11-21 Thread Tom de Vries
On 13/11/15 12:39, Jakub Jelinek wrote: On Fri, Nov 13, 2015 at 12:29:51PM +0100, Richard Biener wrote: thanks for the explanation. Filed as PR68331 - '[meta-bug] fipa-pta issues'. Any feedback on the '#pragma GCC offload-alias=' bit above? Is that sort of what you had in

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-21 Thread Tom de Vries
On 20/11/15 11:28, Richard Biener wrote: On Thu, 19 Nov 2015, Tom de Vries wrote: >On 17/11/15 15:53, Tom de Vries wrote: > > >And the above LIM example > > >is none for why you need two LIM passes... > > > >Indeed. I'm planning a separate reply t

[Committed, PR69108] Handle case that outer phi res is not used in a phi in gather_scalar_reductions

2016-01-11 Thread Tom de Vries
in a phi in gather_scalar_reductions 2016-01-07 Tom de Vries <t...@codesourcery.com> PR tree-optimization/69108 * tree-parloops.c (gather_scalar_reductions): Handle case that outer phi res is not used in a phi. * gcc.dg/autopar/pr69108.c: New test. --- gcc/testsuite/gcc.dg/autopar/pr6

[Committed, PR69058] Don't parallelize loops if libgomp not supported

2016-01-11 Thread Tom de Vries
de Vries <t...@codesourcery.com> PR tree-optimization/69058 * tree-parloops.c (pass_parallelize_loops::execute): Return 0 if libgomp not supported. --- gcc/tree-parloops.c | 4 1 file changed, 4 insertions(+) diff --git a/gcc/tree-parloops.c b/gcc/tree-parloops.c index 5bd9c06..e

[Committed, PR69109] Don't allow latch with phi in try_transform_to_exit_first_loop_alt

2016-01-11 Thread Tom de Vries
Don't allow latch with phi in try_transform_to_exit_first_loop_alt 2016-01-07 Tom de Vries <t...@codesourcery.com> PR tree-optimization/69109 * tree-parloops.c (try_transform_to_exit_first_loop_alt): Don't allow latch with phi. * gcc.dg/autopar/pr69109-2.c: New test. * gcc.dg/a

[PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-12 Thread Tom de Vries
datarefs->safe_push (dr); } references.release (); ... I'm not familiar enough with the dependency analysis code to know where exactly this should be fixed. ] Bootstrapped and reg-tested on x86_64. OK for trunk? OK for release branches? Thanks, - Tom Don't return NULL access

Re: [PATCH, PR69169] Fix infinite recursion in create_variable_info_for_1

2016-01-13 Thread Tom de Vries
On 13/01/16 09:40, Richard Biener wrote: On Wed, 13 Jan 2016, Tom de Vries wrote: Hi, Consider testcase test.c: ... struct pgm_slist_t { struct pgm_slist_t *__restrict next; }; void fn1 (struct pgm_slist_t p1) { } ... The compilation of the testcase enters into infinite recursion, due

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-12 Thread Tom de Vries
tore). I think avoiding a NULL access_fns is ok but it should be done unconditionally, not only for the DECL_P case. Ok, I'll retest and commit this patch. Thanks, - Tom Don't return NULL access_fns in dr_analyze_indices 2016-01-12 Tom de Vries <t...@codesourcery.com> * tree-data-ref.c

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

2016-01-12 Thread Tom de Vries
On 12/01/16 14:04, Richard Biener wrote: On Tue, 12 Jan 2016, Tom de Vries wrote: On 12/01/16 12:22, Richard Biener wrote: Doesnt' the same issue apply to unsigned int *p; static void __attribute__((noinline, noclone)) foo (void) { unsigned int z; for (z = 0; z < N; ++z) ++

[PATCH, PR69169] Fix infinite recursion in create_variable_info_for_1

2016-01-12 Thread Tom de Vries
Hi, Consider testcase test.c: ... struct pgm_slist_t { struct pgm_slist_t *__restrict next; }; void fn1 (struct pgm_slist_t p1) { } ... The compilation of the testcase enters into infinite recursion, due to the more aggressive restrict support added recently. The patch fixes this by:- -

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
On 30/05/16 11:46, Richard Biener wrote: This patch fixes the assert conservatively by aborting graphite code >generation when encountering a phi with more than two arguments in >copy_bb_and_scalar_dependences. > >Bootstrapped and reg-tested on x86_64. > >OK for trunk, 6 branch? Did you check

[PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
atively by aborting graphite code generation when encountering a phi with more than two arguments in copy_bb_and_scalar_dependences. Bootstrapped and reg-tested on x86_64. OK for trunk, 6 branch? Thanks, - Tom Handle 3-arg phi in copy_bb_and_scalar_dependences 2016-05-30 Tom de Vries &l

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
On 30/05/16 12:56, Richard Biener wrote: On Mon, 30 May 2016, Tom de Vries wrote: >On 30/05/16 11:46, Richard Biener wrote: > > >This patch fixes the assert conservatively by aborting graphite code > > > >generation when encountering a phi with

[PATCH, PR69067] Remove assert in get_def_bb_for_const

2016-05-29 Thread Tom de Vries
ATORS, b2, b1)) b1 = b2; } gcc_assert (b1); return b1; } ... IV. Attached patch fixes this by removing the assert. Bootstrapped and reg-tested on x86_64. OK for trunk, 6-branch? Thanks, - Tom Remove assert in get_def_bb_for_const 2016-05-29 Tom de Vries <t...@codesour

<    6   7   8   9   10   11   12   13   14   15   >